Re: [PATCH]: Fix sparc64 build...

2009-12-06 Thread Felix Zielcke
Am Freitag, den 04.12.2009, 13:34 -0800 schrieb David Miller: > From: Robert Millan > Date: Fri, 4 Dec 2009 21:58:25 +0100 > > > On Thu, Dec 03, 2009 at 01:03:09PM -0800, David Miller wrote: > >> > >> Thanks, but I don't feel comfortable enough with bzr yet. > >> > >> I had to struggle just to

Broken common.rmk change

2009-12-06 Thread David Miller
Robert, the set of objects used to build grub-mkdevicemap on sparc64-ieee1275 is not the same as those used on other architectures. So this change was not correct: 2009-11-26 Robert Millan * conf/common.rmk (sbin_UTILITIES): Add `grub-mkdevicemap'. ... * conf/i386-coreboot.rm

Re: handling mount points in grub-mkrelpath

2009-12-06 Thread Felix Zielcke
Am Freitag, den 04.12.2009, 22:23 +0100 schrieb Robert Millan: > Hi, > > The old behaviour seems correct, so there's no need to break > compatibility. > > Please could you commit this in trunk? > Thanks. Commited now. -- Felix Zielcke Proud Debian Maintainer and GNU GRUB developer ___

Re: Broken common.rmk change

2009-12-06 Thread Robert Millan
On Sun, Dec 06, 2009 at 01:21:46AM -0800, David Miller wrote: > > Robert, the set of objects used to build grub-mkdevicemap on > sparc64-ieee1275 is not the same as those used on other architectures. > So this change was not correct: > > 2009-11-26 Robert Millan > > * conf/common.rmk (s

Re: [PATCH] Syntax checker for GRUB script config file

2009-12-06 Thread BVK Chaitanya
On Fri, Dec 4, 2009 at 9:42 PM, Robert Millan wrote: > On Fri, Dec 04, 2009 at 07:12:12AM +, BVK wrote: >> >> Attached patch (experimental) adds a new tool, grub-script-check, that >> can be used to check grub.cfg file syntax.  Idea is to use this tool >> during update-grub to catch any syntax

meaning of absent --users prameters.

2009-12-06 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Hello. Currently authentication system works as following: menuentry "name" --users "a,b,c" { } Means that only superusers and users "a", "b" and "c" are permitted to boot this menuentry. To allow only superusers to boot an entry one would need: menuentry "name" --users "" { } And absence of --use

gettext: commands/hdparm.c

2009-12-06 Thread Carles Pina i Estany
Hello, commands/hdparm.c has some grub_printf's: grub_printf ("Model:\"%.40s\"\n", le16_to_char (tmp, &idw[27], 40)); grub_printf ("Firmware: \"%.8s\"\n", le16_to_char (tmp, &idw[23], 8)); grub_printf ("Serial: \"%.20s\"\n", le16_to_char (tmp, &idw[10], 20)); To have a proper alignm

gettext: commands/*

2009-12-06 Thread Carles Pina i Estany
Hello, I've started to add gettext support in commands/* See the attached patch and ChangeLog. It's not completely exhaustive (hdparm is not in this patch). Comments before committing? Notice the the grub_register_command use N_(" ") and then these strings gets registered in commands/help.c w

Re: meaning of absent --users prameters.

2009-12-06 Thread Bruce Dubbs
Vladimir 'φ-coder/phcoder' Serbinenko wrote: Hello. Currently authentication system works as following: menuentry "name" --users "a,b,c" { } Means that only superusers and users "a", "b" and "c" are permitted to boot this menuentry. To allow only superusers to boot an entry one would need: menue

Re: meaning of absent --users prameters.

2009-12-06 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Bruce Dubbs wrote: > Vladimir 'φ-coder/phcoder' Serbinenko wrote: >> Hello. Currently authentication system works as following: >> >> menuentry "name" --users "a,b,c" { >> } >> Means that only superusers and users "a", "b" and "c" are permitted to >> boot this menuentry. To allow only superusers to

Re: meaning of absent --users prameters.

2009-12-06 Thread Bruce Dubbs
Vladimir 'φ-coder/phcoder' Serbinenko wrote: Bruce Dubbs wrote: Vladimir 'φ-coder/phcoder' Serbinenko wrote: Hello. Currently authentication system works as following: menuentry "name" --users "a,b,c" { } Means that only superusers and users "a", "b" and "c" are permitted to boot this menuentr

Re: meaning of absent --users prameters.

2009-12-06 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Bruce Dubbs wrote: > Vladimir 'φ-coder/phcoder' Serbinenko wrote: >> Bruce Dubbs wrote: >>> Vladimir 'φ-coder/phcoder' Serbinenko wrote: Hello. Currently authentication system works as following: menuentry "name" --users "a,b,c" { } Means that only superusers and users "a",

Re: meaning of absent --users prameters.

2009-12-06 Thread Bruce Dubbs
Vladimir 'φ-coder/phcoder' Serbinenko wrote: Actually the real question is about interpretation of missing --users. Actually your suggestion --users superusers has a problem that user "superusers" may actually exist. BTW: menuentry "name" --users $superusers { is already accepted OK. Sorry fo

Re: [bug #27710] variable type not exported into new context

2009-12-06 Thread Andreas Born
As of r1917 grub_env_context_open still doesn't mark exported variables as global in the new context. Attached patch exports them with grub_env_export in the new context. Andreas Born schrieb: URL: Summary: variable type not exported int

Re: [bug #27695] parser.sh ignores the closing quote when preceeded by a variable

2009-12-06 Thread Andreas Born
Problem exists still as of r1917. I've attached a rediffed version of Vladimir's patch. The behaviour without the patch changed (it's even more confusing), but it's basically still the same: grub> echo "$root" grub>" hd0,1 Vladimir 'phcoder' Serbinenko schrieb: Andreas Born wrote: URL: <

Re: [PATCH] create variables when exporting them

2009-12-06 Thread Andreas Born
Same here. Nothing changed as of r1917 and I didn't get any further feedback either. I've attached a rediffed version, too. Andreas Born schrieb: Here you go: ChangeLog: 2009-10-15 Andreas Born * kern/env.c (grub_env_export): Create nonexistent variables before exporting. The mixe

Re: Broken common.rmk change

2009-12-06 Thread David Miller
From: Robert Millan Date: Sun, 6 Dec 2009 14:10:26 +0100 > We're actually in the process of getting rid of device.map; Meanwhile, please fix the regression you added to the tree. :-) And I'll look into what you've mentioned to see if that kind of scheme will work properly on Sparc. __

Re: gettext: commands/*

2009-12-06 Thread Carles Pina i Estany
Hi, On Dec/06/2009, Carles Pina i Estany wrote: > - grub_printf ("The files are identical.\n"); > + grub_printf (_("The files are identical.\n")); Vladimir suggested in IRC that instead of using: grub_printf (grub_gettext (str)) // This is with _() expanded I could use: grub_printf_

Re: Broken common.rmk change

2009-12-06 Thread David Miller
From: Robert Millan Date: Sun, 6 Dec 2009 14:10:26 +0100 > grub-mkconfig generates a grub.cfg that relies on UUIDs instead > of hardcoding, etc. Well, for one thing I don't use initrd's for my Linux kernels, therefore specifying root devices via UUIDs isn't going to work. _

Re: [PATCH] Syntax checker for GRUB script config file

2009-12-06 Thread BVK Chaitanya
ChangeLog entry was missing, this attachment has it fixed. -- bvk.chaitanya === modified file 'ChangeLog' --- old/ChangeLog 2009-12-02 07:36:13 + +++ new/ChangeLog 2009-12-06 15:50:49 + @@ -1,3 +1,7 @@ +2009-12-06 BVK Chaitanya + + * script/parser.y: Bug fixes in gra

[PATCH]: Fix CDROM skipping in ieee1275 ofdisk iterator.

2009-12-06 Thread David Miller
We skip CDROMs in the block device iterator because they simply can't be openned safely unless we absolutely know there is a CDROM drive there and there is in fact a disc in the drive. Openning it blindly results in either a 10 second hang during the open call, or even worse a crash in OpenFirmwa

mkrelpath doesn't do what it should...

2009-12-06 Thread David Miller
I was trying to figure out why the kernel image paths generated automatically for me by grub-mkconfig were not correct. I have /boot on a seperate partition, but in the generated config files it uses paths like /boot/vmlinux-2632 etc. The problem is grub-mkrelpath and it's usage in the scrips su