Re: About firmware facilities

2009-09-19 Thread Vladimir 'phcoder' Serbinenko
Brendan Trotter wrote: >> No. Usuable means only that firmware isn't destroyed. Any device may >> be in a different state >> > > Any device (that the firmware assumes is in a certain state) may be > left in a different state (that the firmware no longer knows about)? > > For a very simple exam

Re: -Werror and --disable-werror

2009-09-19 Thread Vladimir 'phcoder' Serbinenko
Robert Millan wrote: > Hi, > > -Werror is not in effect. This will help ensuring that all new code is > checked to be warning-free before commit (incidentally, I found a newly > introduced bug thanks to this just minutes before enabling it). > > If you mean this change: + /* Any value differ

Re: [GITGRUB] New menu interface (implementation)

2009-09-19 Thread Michal Suchanek
Hello 2009/9/16 Bean : > set gfxmode="640x480" > loadfont /unifont.pf2 > ismod vbe > insmod png > menutest > > It runs four tests, it would pause after each test, press any key to continue. > > 1, It starts with text mode with three rects, the second rect have 3 > texts, but the last one is outsi

Re: [GITGRUB] New menu interface (implementation)

2009-09-19 Thread Michal Suchanek
Hello why does the menu system have a glyph drawing function? Is the one in font.c not suitable? Why are there two methods for returning text width and height, one in gfx_region in pixels, the other in text_region in characters? Does size in characters make any sense? There might be proportional

Re: [GITGRUB] New menu interface (implementation)

2009-09-19 Thread richardvo...@gmail.com
On Sat, Sep 19, 2009 at 1:45 PM, Michal Suchanek wrote: > Hello > > why does the menu system have a glyph drawing function? > > Is the one in font.c not suitable? > > Why are there two methods for returning text width and height, one in > gfx_region in pixels, the other in text_region in character

Re: -Werror and --disable-werror

2009-09-19 Thread Robert Millan
On Sat, Sep 19, 2009 at 04:12:59PM +0200, Vladimir 'phcoder' Serbinenko wrote: > Robert Millan wrote: > > Hi, > > > > -Werror is not in effect. This will help ensuring that all new code is > > checked to be warning-free before commit (incidentally, I found a newly > > introduced bug thanks to this

Re: [GITGRUB] New menu interface (implementation)

2009-09-19 Thread Bean
On Sat, Sep 19, 2009 at 10:38 PM, Michal Suchanek wrote: > Hello > > 2009/9/16 Bean : > >> set gfxmode="640x480" >> loadfont /unifont.pf2 >> ismod vbe >> insmod png >> menutest >> >> It runs four tests, it would pause after each test, press any key to >> continue. >> >> 1, It starts with text mod

Re: About firmware facilities

2009-09-19 Thread Robert Millan
On Tue, 2009-09-15 at 04:27 +0930, Brendan Trotter wrote: > On Tue, Sep 15, 2009 at 1:02 AM, Robert Millan wrote: > > Anyhow, my priority for GRUB is strong driver-based support. We could > > recruit > > someone to develop the framework in next year's GSoC (unless somebody steps > > in, of cours

Re: [PATCH]: Save boot record before writing to the dest_drive

2009-09-19 Thread Robert Millan
On Mon, Sep 14, 2009 at 09:14:49PM +0530, kashyap garimella wrote: > On Mon, Sep 14, 2009 at 9:05 PM, Robert Millan wrote: > > > On Sat, Sep 12, 2009 at 07:35:45PM +0530, kashyap garimella wrote: > > > Greetings! > > > > > > I have added the following new features: > > > > > > 1) when grub-setup

Re: [PATCH] Build info documentation

2009-09-19 Thread Robert Millan
Excellent. This was much needed. On Tue, Sep 15, 2009 at 06:20:13AM +0100, Colin Watson wrote: > I'm not quite sure I've got everything right here, so please review. My knowledge of texinfo is very limited. Perhaps Jordi will comment on this. In any case, if nobody objects to it during the we

unnecessary parameter in grub_term_register_{input,output} ()

2009-09-19 Thread Robert Millan
Maybe there's some subtle detail I'm missing, but it seems to me that it's completely pointless to pass the `name' parameter in all calls to these two functions: static inline void grub_term_register_input (const char *name __attribute__ ((unused)), grub_term_input_t t

Re: [PATCH]: Save boot record before writing to the dest_drive

2009-09-19 Thread Colin Watson
On Sat, Sep 19, 2009 at 11:10:49PM +0200, Robert Millan wrote: > I'm sorry, but I really see very limited usefulness in this. It's only > potentially useful to expert users, but those should know how to backup > sectors in their disk already. Of course, like many restore facilities, it's only use

Re: unnecessary parameter in grub_term_register_{input,output} ()

2009-09-19 Thread Bean
On Sun, Sep 20, 2009 at 5:39 AM, Robert Millan wrote: > > Maybe there's some subtle detail I'm missing, but it seems to me that it's > completely pointless to pass the `name' parameter in all calls to these > two functions: > >  static inline void >  grub_term_register_input (const char *name __at

Re: -Werror and --disable-werror

2009-09-19 Thread richardvo...@gmail.com
On Sat, Sep 19, 2009 at 9:12 AM, Vladimir 'phcoder' Serbinenko wrote: > Robert Millan wrote: >> Hi, >> >> -Werror is not in effect.  This will help ensuring that all new code is >> checked to be warning-free before commit (incidentally, I found a newly >> introduced bug thanks to this just minutes

Re: [PATCH]: Save boot record before writing to the dest_drive

2009-09-19 Thread richardvo...@gmail.com
On Sat, Sep 19, 2009 at 5:09 PM, Colin Watson wrote: > On Sat, Sep 19, 2009 at 11:10:49PM +0200, Robert Millan wrote: >> I'm sorry, but I really see very limited usefulness in this.  It's only >> potentially useful to expert users, but those should know how to backup >> sectors in their disk alrea