Re: Patch for make install

2009-07-01 Thread Vladimir 'phcoder' Serbinenko
Hello On Wed, Jul 1, 2009 at 2:54 AM, Pavel Roskin wrote: > On Tue, 2009-06-30 at 22:20 +0200, Yves BLUSSEAU wrote: >> Hi, >> >> this patch correct installation of headers files on Mac OSX. >> >> Bug: >>        cp: ./include/grub/cpu is a directory (not copied). >> >> I have done a make install un

Re: [PATCH 1/3] Improve genmoddep.awk

2009-07-01 Thread Pavel Roskin
Quoting Bean : On Wed, Jul 1, 2009 at 12:51 PM, Pavel Roskin wrote: Quoting Bean : Perhaps you could also take a look at my previous patch [PATCH] Use symbol database to maintain module dependence It add a program grub-symdb to maintain symbol database and therefore eliminate def- and unf-

Re: [PATCH] export -boot parameter as qemu_boot{0,1,2}

2009-07-01 Thread Robert Millan
On Mon, Jun 29, 2009 at 06:59:22PM -0400, Pavel Roskin wrote: > On Mon, 2009-06-29 at 15:49 +0200, Robert Millan wrote: > > > > Use of a nested function seems totally unwarranted. > > > > I did it to make the code more readable. Declaring functions that will > > be used locally inside their scop

Re: [PATCH] use $(target_cpu) in conf/*.rmk

2009-07-01 Thread Robert Millan
On Mon, Jun 29, 2009 at 09:05:12PM -0400, Pavel Roskin wrote: > Quoting Robert Millan : > >> >> This patch replaces a few hardcoded architecture names in conf/*.rmk >> with $(target_cpu). It makes it easier to share code. >> >> As a result of this, the setjmp module declarations are unified. >> >>

Re: [PATCH] get rid of util/$(target_cpu)/$(platform)/misc.c

2009-07-01 Thread Robert Millan
Committed. On Mon, Jun 29, 2009 at 03:19:02PM +0200, Robert Millan wrote: > > This patch gets rid of util/$(target_cpu)/$(platform)/misc.c by integrating > them into util/misc.c. > > It paves the way for unification of grub-emu. > > -- > Robert Millan > > The DRM opt-in fallacy: "Your data

Re: [PATCH 2/3] Don't put modules without dependencies into moddep.lst

2009-07-01 Thread Robert Millan
On Tue, Jun 30, 2009 at 08:35:09PM -0400, Pavel Roskin wrote: > +if (modlist != "") { Are you sure this does what you expect? I read it as "compare this char * with this const char *", which will always return false. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We w

Re: [PATCH 1/3] Improve genmoddep.awk

2009-07-01 Thread Robert Millan
On Wed, Jul 01, 2009 at 01:22:29PM +0800, Bean wrote: > On Wed, Jul 1, 2009 at 12:51 PM, Pavel Roskin wrote: > > Quoting Bean : > > > >> Perhaps you could also take a look at my previous patch > >> > >> [PATCH] Use symbol database to maintain module dependence > >> > >> It add a program grub-symdb

Re: [PATCH 2/3] Don't put modules without dependencies into moddep.lst

2009-07-01 Thread Pavel Roskin
Quoting Robert Millan : On Tue, Jun 30, 2009 at 08:35:09PM -0400, Pavel Roskin wrote: +if (modlist != "") { Are you sure this does what you expect? I read it as "compare this char * with this const char *", which will always return false. Yes, this check does the right thing. And we d

Re: grub-install --root-directory=/mnt /dev/sda1 fails

2009-07-01 Thread Felix Zielcke
Am Montag, den 01.06.2009, 21:39 +0200 schrieb Felix Zielcke: > Am Mittwoch, den 06.05.2009, 17:12 +0200 schrieb Vladimir 'phcoder' > Serbinenko: > > Don't we already have a function which transforms host directory into > > grub > > directory? AFAIR we have. > > There's just the shell function in

Re: [PATCH] use $(target_cpu) in conf/*.rmk

2009-07-01 Thread Pavel Roskin
On Wed, 2009-07-01 at 15:00 +0200, Robert Millan wrote: > > I'm actually thinking of making dl.c similar to each other by using the > > notation without "32" and "64". At least it would be easier to compare > > them. > > Yeah, I was thinking that too. Committed :-) -- Regards, Pavel Roskin

Re: [PATCH] get rid of util/$(target_cpu)/$(platform)/misc.c

2009-07-01 Thread Pavel Roskin
On Mon, 2009-06-29 at 15:19 +0200, Robert Millan wrote: > This patch gets rid of util/$(target_cpu)/$(platform)/misc.c by integrating > them into util/misc.c. > > It paves the way for unification of grub-emu. The patch breaks compilation of any utilities other than grub-emu due to undefined main_

Re: Is it possible to install grub4dos on utfs partiton?

2009-07-01 Thread Hongyi Zhao
On Sat, 27 Jun 2009 16:25:18 -0700, walt wrote: >This is a good place to ask your question: > >http://www.boot-land.net/forums/index.php?showforum=66 Thanks a lot. -- .: Hongyi Zhao [ hongyi.zhao AT gmail.com ] Free as in Freedom :. ___ Grub-devel

[PATCH] Fix compilation of utilities

2009-07-01 Thread Pavel Roskin
ChangeLog: * util/misc.c: Move grub_reboot() and grub_halt() ... * util/grub-emu.c: ... here. Make main_env static. * include/grub/util/misc.h: Remove main_env. --- include/grub/util/misc.h |1 - util/grub-emu.c | 18 +- util/misc.c

Bug in gencmdlist.sh (or is it?)

2009-07-01 Thread Duboucher Thomas
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, I was working on some Grub2 module a few days ago and I spent a lot of time on this. Basically, I was unable to correctly generate the file command.lst; my new commands simply didn't appeared in it. I finally found that gen

Re: Patch for make install

2009-07-01 Thread Pavel Roskin
On Tue, 2009-06-30 at 22:20 +0200, Yves BLUSSEAU wrote: > Hi, > > this patch correct installation of headers files on Mac OSX. > > Bug: >cp: ./include/grub/cpu is a directory (not copied). > > I have done a make install under OSX and linux after applying the > patch. Now it works on th

[PATCH] Fix warning in grub-emu compilation for i386-coreboot

2009-07-01 Thread Pavel Roskin
Add include/grub/util/console.h, which matches utils/console.c and always declares grub_console_init() and grub_console_fini(), unlike the machine specific headers. ChangeLog: * include/grub/util/console.h: New file. * util/console.c: Use it. * util/grub-emu.c: Likewise. -

Re: Bug in gencmdlist.sh (or is it?)

2009-07-01 Thread Pavel Roskin
On Thu, 2009-07-02 at 00:34 +0200, Duboucher Thomas wrote: > I was working on some Grub2 module a few days ago and I spent a lot of > time on this. Basically, I was unable to correctly generate the file > command.lst; my new commands simply didn't appeared in it. > I finally found that

where is grub2 roadmap?

2009-07-01 Thread zhang Peter
Does anybody know how to get grub2 devel roadmap? I'd like to take a look at it and decide how to join this open project. Thanks! ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: Bug in gencmdlist.sh (or is it?)

2009-07-01 Thread Duboucher Thomas
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Pavel Roskin a écrit : > On Thu, 2009-07-02 at 00:34 +0200, Duboucher Thomas wrote: > >> I was working on some Grub2 module a few days ago and I spent a lot of >> time on this. Basically, I was unable to correctly generate the file >> command.lst