[PATCH] Support splitting SOURCE in multiple rmk files

2009-06-24 Thread Bean
Hi, In the current build system, all source files to build an executable must reside in a single rmk file, this makes it difficult to break down the build system in more logical blocks. This patch fixes this by utilizing some tricks of GNU make. First, you can specify the dependence of target in

Re: Fw: gettext support

2009-06-24 Thread Jordi Mallach
On Tue, Jun 23, 2009 at 12:45:39PM +0200, Javier Martín wrote: > Why not? A msgid does not necessarily mean a \n, you can printf("%s %s", > _("first"), _("second")) just OK without an intervening line break. In > this particular case the gettext "directives" [0] don't tell us either > to merge or s

support for crashkernel= in 10_linux.in

2009-06-24 Thread Michael Vogt
Hello, in ubuntu we are working on making it easier to capture kernel crashes. The system we use is based around kdump and it works by triggering a kexec of a special crashdump kernel if the regular kernels crashes. In order for this to work the normal kernel needs a additional commandline option

Re: [PATCH] search -d|--disk

2009-06-24 Thread Robert Millan
On Wed, Jun 24, 2009 at 12:33:52PM +0930, Arthur Marsh wrote: > > Please cc: me when this patch is merged - I'd like to get to the bottom > of why: > > search --no-floppy --fs-uuid --set bfdeb6d6-0b77-4beb-a63d-bdc3e455b8ea > > fails. (See https://savannah.gnu.org/bugs/?26834 ) > > Being able to

Re: [PATCH] Support splitting SOURCE in multiple rmk files

2009-06-24 Thread Robert Millan
On Wed, Jun 24, 2009 at 04:52:26PM +0800, Bean wrote: > diff --git a/conf/common.rmk b/conf/common.rmk > index dc78df9..3402faf 100644 > --- a/conf/common.rmk > +++ b/conf/common.rmk > @@ -2,8 +2,9 @@ > > # For grub-mkelfimage. > bin_UTILITIES += grub-mkelfimage > -grub_mkelfimage_SOURCES = util

Re: support for crashkernel= in 10_linux.in

2009-06-24 Thread Robert Millan
Hi Michael, On Wed, Jun 24, 2009 at 01:20:49PM +0200, Michael Vogt wrote: > diff -Nur -x '*.orig' -x '*~' grub2-1.96+20090611/util/grub.d/10_linux.in > grub2-1.96+20090611.new/util/grub.d/10_linux.in > --- grub2-1.96+20090611/util/grub.d/10_linux.in 2009-06-24 > 10:17:45.202761012 +0200 >

Re: [PATCH] Support splitting SOURCE in multiple rmk files

2009-06-24 Thread Bean
On Wed, Jun 24, 2009 at 8:06 PM, Robert Millan wrote: > On Wed, Jun 24, 2009 at 04:52:26PM +0800, Bean wrote: >> diff --git a/conf/common.rmk b/conf/common.rmk >> index dc78df9..3402faf 100644 >> --- a/conf/common.rmk >> +++ b/conf/common.rmk >> @@ -2,8 +2,9 @@ >> >>  # For grub-mkelfimage. >>  bin

Re: support for crashkernel= in 10_linux.in

2009-06-24 Thread Michael Vogt
On Wed, Jun 24, 2009 at 02:11:59PM +0200, Robert Millan wrote: > Hi Michael, Hi Robert, Thanks for your quick reply. > On Wed, Jun 24, 2009 at 01:20:49PM +0200, Michael Vogt wrote: > > diff -Nur -x '*.orig' -x '*~' grub2-1.96+20090611/util/grub.d/10_linux.in > > grub2-1.96+20090611.new/util/gru

Re: support for crashkernel= in 10_linux.in

2009-06-24 Thread Pavel Roskin
On Wed, 2009-06-24 at 15:11 +0200, Michael Vogt wrote: > Maybe - my rational was to keep recovery mode as simple as > possible. And also in case there is a issue with the crashkernel= > commandlinethe user is still able to use recovery mode (its pretty > unlikely that there are problems though).

Re: [PATCH] Support splitting SOURCE in multiple rmk files

2009-06-24 Thread Vladimir 'phcoder' Serbinenko
Sory for not being present last few days - I split my time between non-grub things and making zfs work welll in grub2 (I'm already able to boot FreeBSD off ZFS with branch I have in my personal repo) > > Hi, > > You can use = or +=, actually the macro is used by genmk.rb to > generate the rules, i

Re: [PATCH] Support splitting SOURCE in multiple rmk files

2009-06-24 Thread Robert Millan
On Wed, Jun 24, 2009 at 08:13:35PM +0800, Bean wrote: > >> +bin_UTILITIES += grub-mkelfimage > >> +grub_mkelfimage_SOURCES = util/resolve.c > >> + > >>  pkglib_MODULES += cpuid.mod > >>  cpuid_mod_SOURCES = commands/i386/cpuid.c > >>  cpuid_mod_CFLAGS = $(COMMON_CFLAGS) > > > > This looks very conf

Re: support for crashkernel= in 10_linux.in

2009-06-24 Thread Robert Millan
On Wed, Jun 24, 2009 at 03:18:08PM -0400, Pavel Roskin wrote: > On Wed, 2009-06-24 at 15:11 +0200, Michael Vogt wrote: > > > Maybe - my rational was to keep recovery mode as simple as > > possible. And also in case there is a issue with the crashkernel= > > commandlinethe user is still able to use

[PATCH] fix for loading modules from read-only memory area (Re: clean patch for i386-qemu port (Re: [PATCH] i386-qemu port))

2009-06-24 Thread Robert Millan
On Wed, Jun 24, 2009 at 03:00:32AM +0200, Robert Millan wrote: > A possible solution to this could be to make grub_dl_load_core() create a > copy of the module and work on the copy. This could even be ifdef'ed, > but I doubt the performance hit would be significant. I found a better approach; in

Re: [PATCH] Support splitting SOURCE in multiple rmk files

2009-06-24 Thread Bean
On Thu, Jun 25, 2009 at 4:07 AM, Vladimir 'phcoder' Serbinenko wrote: > Sory for not being present last few days - I split my time between non-grub > things and making zfs work welll in grub2 (I'm already able to boot FreeBSD > off ZFS with branch I have in my personal repo) >> >> Hi, >> >> You can

[RFC] New menu design based on MVC

2009-06-24 Thread Bean
Hi, The current menu system is a little chaotic, the various components are mixed together which make it difficult to maintain and extend. Therefore, I propose a new design which seperates model, view and controller. Model. It's the menu items. Currently, menu are added using menuitem statement,