Re: [PATCH] Faster text rendering by optimizing font glyph lookup

2009-06-11 Thread Felix Zielcke
Am Montag, den 09.02.2009, 08:24 -0800 schrieb Colin D Bennett: > On Mon, 9 Feb 2009 15:11:16 +0100 > Robert Millan wrote: > > > On Sun, Feb 08, 2009 at 01:49:53PM -0800, Colin D Bennett wrote: > > > This patch greatly—*tremendously*, even, if higher-numbered Unicode > > > characters are used—spe

[PATCH] Capitalise "Linux"

2009-06-11 Thread Colin Watson
"Linux" is a proper noun and should be capitalised in user-visible text. Index: util/grub.d/10_linux.in === --- util/grub.d/10_linux.in (revision 2297) +++ util/grub.d/10_linux.in (working copy) @@ -141,9 +141,9 @@ linux_

[PATCH] grub-pe2elf --help talks about grub-editenv

2009-06-11 Thread Colin Watson
Looks like a copy-and-paste job gone slightly wrong. Index: util/grub-pe2elf.c === --- util/grub-pe2elf.c (revision 2297) +++ util/grub-pe2elf.c (working copy) @@ -40,10 +40,10 @@ usage (int status) { if (status) -fprintf (

Re: grub-mkconfig fails on every non i386-pc because of gfxterm/vbe

2009-06-11 Thread Vladimir 'phcoder' Serbinenko
On Thu, Jun 4, 2009 at 12:11 AM, Felix Zielcke wrote: > Am Mittwoch, den 03.06.2009, 16:55 -0400 schrieb Pavel Roskin: >> On Wed, 2009-06-03 at 11:43 +0200, Felix Zielcke wrote: >> > I wonder why nobody on this list noticed this yet. >> > Jordi reported this already on Debian a while ago [0] >> > >

Re: [PATCH] drivemap fixes

2009-06-11 Thread Vladimir 'phcoder' Serbinenko
Committed On Mon, Jun 8, 2009 at 1:40 PM, Vladimir 'phcoder' Serbinenko wrote: > On Mon, Jun 8, 2009 at 4:10 AM, Pavel Roskin wrote: >>  Also, it would be great >> if you specify, which exactly problems the patch fixes. > You missed that part because it was in the previous drivemap thread. > It fi

Re: [PATCH] grub-pe2elf --help talks about grub-editenv

2009-06-11 Thread Pavel Roskin
On Thu, 2009-06-11 at 17:01 +0100, Colin Watson wrote: > Looks like a copy-and-paste job gone slightly wrong. > > Index: util/grub-pe2elf.c Applied. Thank you! By the way, I welcome contributions from Ubuntu, the first major distro to adopt GRUB2! -- Regards, Pavel Roskin __

Warning free build achieved for most platforms

2009-06-11 Thread Pavel Roskin
Hello! As of now, GRUB builds without warnings for all platforms except i386-coreboot. The build is done using gcc 4.4.0 for i386 and x86_64 and gcc 4.3.3 for PowerPC and SPARC64. Actually, the coreboot warnings should really be errors. In particular, kern/i386/coreboot/init.c calls grub_at_key

Re: [PATCH] Capitalise "Linux"

2009-06-11 Thread Pavel Roskin
On Thu, 2009-06-11 at 16:23 +0100, Colin Watson wrote: > "Linux" is a proper noun and should be capitalised in user-visible text. Applied, thanks! -- Regards, Pavel Roskin ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/li

Re: Warning free build achieved for most platforms

2009-06-11 Thread Vladimir 'phcoder' Serbinenko
Hello On Thu, Jun 11, 2009 at 7:25 PM, Pavel Roskin wrote: > Hello! > > As of now, GRUB builds without warnings for all platforms except > i386-coreboot.  The build is done using gcc 4.4.0 for i386 and x86_64 > and gcc 4.3.3 for PowerPC and SPARC64. > It's not entirely true. If you compile under F

Re: Warning free build achieved for most platforms

2009-06-11 Thread Pavel Roskin
On Thu, 2009-06-11 at 19:40 +0200, Vladimir 'phcoder' Serbinenko wrote: > It's not entirely true. If you compile under FreeBSD you see a bunch > of warnings coming from the code inside #ifdef __FreeBSD__. Similar > thing happens with Apple's toolchain. It includes warnings > specifically added wit

Re: [PATCH] savedefault

2009-06-11 Thread Vladimir 'phcoder' Serbinenko
Hello On Mon, Jun 8, 2009 at 9:37 AM, Bean wrote: > On Sun, Jun 7, 2009 at 10:51 PM, Vladimir 'phcoder' > Serbinenko wrote: >> Hello. Welcome back >> >> On Sun, Jun 7, 2009 at 11:35 AM, Bean wrote: >>> Hi, >>> >>> Actually, I'm thinking about a more generic method to implement this >>> feature wit

Re: [PATCH] add drivemap support to 30_os-prober.in and use UUIDs

2009-06-11 Thread Felix Zielcke
Am Sonntag, den 07.06.2009, 17:37 +0200 schrieb Felix Zielcke: > Attached patch uses `prepare_grub_to_access_device' to set the root in > the generated entrys. > And it adds drivemap to the chainload ones, if root isn't (hd0). > > The Debian grub-installer adds map only with Dos and Windows, shoul

Re: [2290] 2009-06-10 Pavel Roskin

2009-06-11 Thread Christian Franke
Pavel Roskin wrote: Revision: 2290 http://svn.sv.gnu.org/viewvc/?view=rev&root=grub&revision=2290 Author: proski Date: 2009-06-10 18:32:13 + (Wed, 10 Jun 2009) Log Message: --- 2009-06-10 Pavel Roskin * configure.ac: Use -nostdlib when probing for the targe

Re: [2290] 2009-06-10 Pavel Roskin

2009-06-11 Thread Vladimir 'phcoder' Serbinenko
On Thu, Jun 11, 2009 at 9:39 PM, Christian Franke wrote: > Pavel Roskin wrote: >> >> Revision: 2290 >>          http://svn.sv.gnu.org/viewvc/?view=rev&root=grub&revision=2290 >> Author:   proski >> Date:     2009-06-10 18:32:13 + (Wed, 10 Jun 2009) >> Log Message: >> --- >> 2009-06-10  

Re: [2290] 2009-06-10 Pavel Roskin

2009-06-11 Thread Christian Franke
Vladimir 'phcoder' Serbinenko wrote: The link test in grub_PROG_TARGET_CC fails due to missing '__main' symbol from libgcc. According to gcc 4.3.2 man page, '-nostdlib' usually requires '-lgcc'. Try compiling but not linking using -c option. If it works you can commit it since we never do

Re: [2290] 2009-06-10 Pavel Roskin

2009-06-11 Thread Vladimir 'phcoder' Serbinenko
On Thu, Jun 11, 2009 at 9:57 PM, Christian Franke wrote: > Vladimir 'phcoder' Serbinenko wrote: >>> >>> The link test in grub_PROG_TARGET_CC fails due to missing '__main' symbol >>> from libgcc. According to gcc 4.3.2 man page, '-nostdlib' usually >>> requires >>> '-lgcc'. >>> >> >> Try compiling b

Re: [PATCH] savedefault

2009-06-11 Thread Robert Millan
Hi! On Mon, Jun 01, 2009 at 12:48:38PM +0200, Vladimir 'phcoder' Serbinenko wrote: > cat << EOF > +load_env > set default=${GRUB_DEFAULT} Does the "set" line override the settings in load_env? It looks like it would. > --- a/util/grub.d/10_freebsd.in > +++ b/util/grub.d/10_freebsd.in > @@ -5

Re: [2290] 2009-06-10 Pavel Roskin

2009-06-11 Thread Pavel Roskin
On Thu, 2009-06-11 at 21:57 +0200, Christian Franke wrote: > Complete linking is not used during build but during configure. The > following tests rely on it: > > grub_PROG_LD_BUILD_ID_NONE > grub_CHECK_BSS_START_SYMBOL > grub_CHECK_END_SYMBOL > > I would suggest to undo commit 2290 for now. OK

Re: [2290] 2009-06-10 Pavel Roskin

2009-06-11 Thread Pavel Roskin
On Thu, 2009-06-11 at 22:05 +0200, Vladimir 'phcoder' Serbinenko wrote: > > I would suggest to undo commit 2290 for now. > I think we should commit Pavel's patch on using same ld everywhere. You mean the ld script? I'll try to resurrect it, but now I'll need to have a special case for the Apple

Re: [2290] 2009-06-10 Pavel Roskin

2009-06-11 Thread Vladimir 'phcoder' Serbinenko
On Thu, Jun 11, 2009 at 10:20 PM, Pavel Roskin wrote: > On Thu, 2009-06-11 at 22:05 +0200, Vladimir 'phcoder' Serbinenko wrote: > >> > I would suggest to undo commit 2290 for now. >> I think we should commit Pavel's patch on using same ld everywhere. > > You mean the ld script?  I'll try to resurre

Re: [2290] 2009-06-10 Pavel Roskin

2009-06-11 Thread Pavel Roskin
On Thu, 2009-06-11 at 22:27 +0200, Vladimir 'phcoder' Serbinenko wrote: > Possibilities > 1) to test both with and without -nostdlib and check that at least one > works. I don't like this one Me neither. > 2) rename main to main,start,_start,__start,_main or __main. Just find > one that works by

Re: [2290] 2009-06-10 Pavel Roskin

2009-06-11 Thread Vladimir 'phcoder' Serbinenko
On Thu, Jun 11, 2009 at 10:34 PM, Pavel Roskin wrote: > On Thu, 2009-06-11 at 22:27 +0200, Vladimir 'phcoder' Serbinenko wrote: >> 2) rename main to main,start,_start,__start,_main or __main. Just find >> one that works by bruteforce in script > > We can use -Wl,--defsym,___main=0x8100 as it's done

Re: [2290] 2009-06-10 Pavel Roskin

2009-06-11 Thread Christian Franke
Pavel Roskin wrote: We can use -Wl,--defsym,___main=0x8100 as it's done elsewhere in configure.ac. Let me just check it doesn't break anything. This (r2310) works on Cygwin, thanks. -- Regards, Christian Franke ___ Grub-devel mailing list Grub

Re: [PATCH] Faster text rendering by optimizing font glyph lookup

2009-06-11 Thread Vladimir 'phcoder' Serbinenko
On Thu, Jun 11, 2009 at 12:28 PM, Felix Zielcke wrote: > Am Montag, den 09.02.2009, 08:24 -0800 schrieb Colin D Bennett: >> On Mon, 9 Feb 2009 15:11:16 +0100 >> Robert Millan wrote: >> >> > On Sun, Feb 08, 2009 at 01:49:53PM -0800, Colin D Bennett wrote: >> > > This patch greatly—*tremendously*, e

Re: [PATCH] Re: grub-install --root-directory=/mnt /dev/sda1 fails

2009-06-11 Thread Felix Zielcke
Am Donnerstag, den 11.06.2009, 01:00 +0200 schrieb Felix Zielcke: > Am Dienstag, den 09.06.2009, 23:51 +0200 schrieb Vladimir 'phcoder' > Serbinenko: > > > + > > +char *grub_make_system_path_relative_to_its_root (char *path) > > +{ > > + > > + struct stat st; > > + char buf[500], buf2[500]; > >

Re: [PATCH] Re: grub-install --root-directory=/mnt /dev/sda1 fails

2009-06-11 Thread Felix Zielcke
Am Freitag, den 12.06.2009, 01:21 +0200 schrieb Felix Zielcke: > Am Donnerstag, den 11.06.2009, 01:00 +0200 schrieb Felix Zielcke: > > Am Dienstag, den 09.06.2009, 23:51 +0200 schrieb Vladimir 'phcoder' > > Serbinenko: > > > > > + > > > +char *grub_make_system_path_relative_to_its_root (char *path

Re: [PATCH] savedefault

2009-06-11 Thread Pavel Roskin
Quoting Robert Millan : + saved_entry=\${chosen_entry} + save_env saved_entry EOF prepare_grub_to_access_device ${GRUB_DEVICE_BOOT} | sed -e "s/^/\t/" cat << EOF I think it'd really be a good idea to either factorize this into a function (ala prepare_grub_to_access_device), or make it

Re: grub-mkconfig fails on every non i386-pc because of gfxterm/vbe

2009-06-11 Thread Pavel Roskin
Quoting Felix Zielcke : So you would prefer something like the attached patch? Though then we'll need to tell people to explicit enable gfxterm. Pavel? Seems like you missed my mail. No, it's still in my INBOX. The patch looks reasonable, but I didn't have a chance to test it yet. -- Re

Re: [PATCH] hfs+ uuid

2009-06-11 Thread Pavel Roskin
Quoting Vladimir 'phcoder' Serbinenko : If the variable name is not specified, I think xnu_uuid should just output the UUID without any explanations.  Explanations belong to the help, not to the normal output. GRUB2 becomes increasingly more complex. We try to document it on grub.enbug.org but

Re: $lib_DATA gets installed to both $libdir/grub and $pkglibdir

2009-06-11 Thread Pavel Roskin
Quoting Felix Zielcke : Is there any reason why we install the $lib_DATA files (grub-mkconfig_lib and update-grub_lib) to both $libdir/grub and $pkglibdir, e.g. /usr/lib/grub and /usr/lib/grub/i386-pc? In Makefile.in PKGLIB includes $(lib_DATA) Fixed. -- Regards, Pavel Roskin _

Re: [PATCH] drivemap fixes

2009-06-11 Thread Pavel Roskin
Quoting Vladimir 'phcoder' Serbinenko : On Mon, Jun 8, 2009 at 4:10 AM, Pavel Roskin wrote:  Also, it would be great if you specify, which exactly problems the patch fixes. You missed that part because it was in the previous drivemap thread. It would be helpful if you summarize the changes i