Re: [PATCH] add true and false commands

2009-06-08 Thread Felix Zielcke
Am Freitag, den 05.06.2009, 15:04 +0200 schrieb Felix Zielcke: > Am Freitag, den 05.06.2009, 14:26 +0200 schrieb Marco Gerards: > > Felix Zielcke writes: > > > > So what should I do now? > > > Placing it in normal.mod or minicmd.mod where it's included in rescue > > > mode or placing it into a tr

Re: [PATCH] savedefault

2009-06-08 Thread Bean
On Sun, Jun 7, 2009 at 10:51 PM, Vladimir 'phcoder' Serbinenko wrote: > Hello. Welcome back > > On Sun, Jun 7, 2009 at 11:35 AM, Bean wrote: >> Hi, >> >> Actually, I'm thinking about a more generic method to implement this >> feature with events. The menu viewer fire events at certain >> circumstan

Re: [PATCH 4/4] Define fields in terms of the Class Code register

2009-06-08 Thread Marco Gerards
Oliver Henshaw writes: Can you please send in patches in such a way they are recognised as text or inline? Please include a Changelog entry. -- Marco ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] add drivemap support to 30_os-prober.in and use UUIDs

2009-06-08 Thread Vladimir 'phcoder' Serbinenko
On Sun, Jun 7, 2009 at 5:55 PM, Pavel Roskin wrote: > On Sun, 2009-06-07 at 17:37 +0200, Felix Zielcke wrote: >> Attached patch uses `prepare_grub_to_access_device' to set the root in >> the generated entrys. >> And it adds drivemap to the chainload ones, if root isn't (hd0). >> >> The Debian grub-

echo and hello bug

2009-06-08 Thread James Jarvis
I have submitted a bug in to the bugzilla at https://savannah.gnu.org/bugs/?26744 in which hello just hangs. I have tried a few tests around this to see if I can get any output via hello from the command line (from menu pressing C) but I cannot. The problem also occurs if I use echo. Any sugg

Re: [PATCH] drivemap fixes

2009-06-08 Thread Vladimir 'phcoder' Serbinenko
On Mon, Jun 8, 2009 at 4:10 AM, Pavel Roskin wrote: >  Also, it would be great > if you specify, which exactly problems the patch fixes. You missed that part because it was in the previous drivemap thread. It fixes 2 problems: grub2 passes incorrect boot number and %dl not being restored after int

Re: echo and hello bug

2009-06-08 Thread Vladimir 'phcoder' Serbinenko
On Mon, Jun 8, 2009 at 1:34 PM, James Jarvis wrote: > I have submitted a bug in to the bugzilla at > > https://savannah.gnu.org/bugs/?26744 > > in which hello just hangs. > > I have tried a few tests around this to see if I can get any output via > hello from the command line (from menu pressing C)

$lib_DATA gets installed to both $libdir/grub and $pkglibdir

2009-06-08 Thread Felix Zielcke
Is there any reason why we install the $lib_DATA files (grub-mkconfig_lib and update-grub_lib) to both $libdir/grub and $pkglibdir, e.g. /usr/lib/grub and /usr/lib/grub/i386-pc? In Makefile.in PKGLIB includes $(lib_DATA) -- Felix Zielcke ___ Grub-dev

Re: [PATCH] gracefully ignore inability to retrieve C/H/S on LBA disks

2009-06-08 Thread Vladimir 'phcoder' Serbinenko
committed On Sun, May 17, 2009 at 3:34 PM, Vladimir 'phcoder' Serbinenko wrote: > Hello. Here is a workaround for buggy BIOSes not supplying C/H/S geometry > > -- > Regards > Vladimir 'phcoder' Serbinenko > -- Regards Vladimir 'phcoder' Serbinenko

Re: echo and hello bug

2009-06-08 Thread James Jarvis
Vladimir 'phcoder' Serbinenko wrote: On Mon, Jun 8, 2009 at 1:34 PM, James Jarvis wrote: I have submitted a bug in to the bugzilla at https://savannah.gnu.org/bugs/?26744 in which hello just hangs. I have tried a few tests around this to see if I can get any output via hello from the comma

[PATCH 0/4] Re: Grub needs to check the programming interface for usb controllers

2009-06-08 Thread oliver . henshaw
Here's a second try. I used quilt to manage the patch series but mailed them by hand instead of exporting to a mailbox, and didn't realise that they weren't named as *.patch (otherwise I think the content type would have been fine). I should probably move on to git, but I was a little intimidate

[PATCH 2/4] Fix inteface definition for ohci

2009-06-08 Thread oliver . henshaw
Changelog: * bus/usb/ohci.c: Set interf with correct field. --- bus/usb/ohci.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: grub2/bus/usb/ohci.c === --- grub2.orig/bus/usb/ohci.c +++ grub2/bus/usb/ohci.c @@

[PATCH 3/4] Check usb programming interface

2009-06-08 Thread oliver . henshaw
Changelog: * bus/usb/ohci.c: Check programming interface is ohci. Add grub_dprintf for symmetry with bus/usb/uhci.c. * bus/usb/uhci.c: Check programming interface is uhci. Add interf variable for Programming Interface. Print in

[PATCH 4/4] Define fields in terms of the Class Code register

2009-06-08 Thread oliver . henshaw
Changelog: * bus/usb/ohci.c: Define the Class, Subclass and Programming Interface fields in terms of the 3 byte Class Code register. * bus/usb/uhci.c: Likewise. --- bus/usb/ohci.c |9 + bus/usb/uhci.c |9 + 2 files changed, 10 ins

[PATCH 1/4] Minor Cleanup

2009-06-08 Thread oliver . henshaw
Changelog: * bus/usb/uhci.c: Remove un-needed doubled lines. * bus/usb/ohci.c: Likewise. Change interf to grub_uint32_t. Remove whitespace inside comment. --- bus/usb/ohci.c |7 ++- bus/usb/uhci.c |2 -- 2 files changed, 2 insertions(+), 7 deletions(-) Index: grub2/bu

Re: [PATCH 0/4] Re: Grub needs to check the programming interface for usb controllers

2009-06-08 Thread Pavel Roskin
On Mon, 2009-06-08 at 18:45 +0100, oliver.hens...@gmail.com wrote: > Here's a second try. I used quilt to manage the patch series but > mailed them by hand instead of exporting to a mailbox, and didn't > realise that they weren't named as *.patch (otherwise I think the > content type would have be

Re: multiboot take partial mmap

2009-06-08 Thread Vladimir 'phcoder' Serbinenko
On Fri, Jun 5, 2009 at 11:10 AM, Colin Watson wrote: > On Fri, Jun 05, 2009 at 03:24:09AM +0200, Vladimir 'phcoder' Serbinenko wrote: >> On Thu, Jun 4, 2009 at 10:07 PM, Andrey Valyaev wrote: >> > PS: latest svn revision (from 2243) failed with message: >> > >> > gcc -Icommands -I./commands -I. -I.

Re: [PATCH] hfs+ uuid

2009-06-08 Thread Vladimir 'phcoder' Serbinenko
On Sun, May 3, 2009 at 6:55 PM, Pavel Roskin wrote: > On Sun, 2009-05-03 at 12:42 +0200, Vladimir 'phcoder' Serbinenko wrote: >> This is a patch to support UUIDs on HFS+. MD5 code is copied from >> Michael Gorven's patch which is copied from libgcrypt nearly verbatim. >> Thanks for Cris for the inf

Re: [PATCH] hfs+ uuid

2009-06-08 Thread Vladimir 'phcoder' Serbinenko
Attachement forgotten On Mon, Jun 8, 2009 at 10:50 PM, Vladimir 'phcoder' Serbinenko wrote: > On Sun, May 3, 2009 at 6:55 PM, Pavel Roskin wrote: >> On Sun, 2009-05-03 at 12:42 +0200, Vladimir 'phcoder' Serbinenko wrote: >>> This is a patch to support UUIDs on HFS+. MD5 code is copied from >>> Mic

Re: [PATCH] add a --disk-module option to grub-install

2009-06-08 Thread Felix Zielcke
Am Freitag, den 05.06.2009, 23:26 +0200 schrieb Vladimir 'phcoder' Serbinenko: > -# generic method (used on coreboot) > +if [ "$disk_module" = ata ] ; then > +# generic method (used on coreboot and ata mod) > uuid="`$grub_probe --target=fs_uuid --device ${grub_device}`"

Re: multiboot take partial mmap

2009-06-08 Thread Colin Watson
On Mon, Jun 08, 2009 at 10:43:42PM +0200, Vladimir 'phcoder' Serbinenko wrote: > Is this code copyrighted by you? I think it's really too obvious to be copyrightable, but if it's copyrightable by anyone it's by me, GPLv2 or later. I have an assignment pending although the paperwork doesn't seem to

[PATCH] Re: grub-install --root-directory=/mnt /dev/sda1 fails

2009-06-08 Thread Felix Zielcke
Am Montag, den 01.06.2009, 21:39 +0200 schrieb Felix Zielcke: > Am Mittwoch, den 06.05.2009, 17:12 +0200 schrieb Vladimir 'phcoder' > Serbinenko: > > Don't we already have a function which transforms host directory into > > grub > > directory? AFAIR we have. > > There's just the shell function in

Re: [PATCH] hfs+ uuid

2009-06-08 Thread Pavel Roskin
On Mon, 2009-06-08 at 22:50 +0200, Vladimir 'phcoder' Serbinenko wrote: > Here is the improved patch. I deliberately ignored md5 comments > because this part will be gone anyway whel Michael Gorven signs his > copyright assignment and we incorporate luks patches Please consider if it would be bet

Re: [PATCH] Link usb controller struct only when initialised

2009-06-08 Thread Vladimir 'phcoder' Serbinenko
Commited with small stylistic change: comments start with an uppercase letter and end with 2 spaces On Sun, Jun 7, 2009 at 8:37 PM, Oliver Henshaw wrote: > When controller initialisation is aborted in grub_uhci_pci_iter > (grub_ohci_pci_iter) control > jumps to "fail:", where any allocated memory

Re: [PATCH] Link usb controller struct only when initialised

2009-06-08 Thread Pavel Roskin
On Tue, 2009-06-09 at 01:57 +0200, Vladimir 'phcoder' Serbinenko wrote: > Commited with small stylistic change: comments start with an uppercase > letter and end with 2 spaces Thanks! By the way, it would be nice to rewrite uhci.c and ohci.c using GRUB lists (include/grub/list.h). And rewriting

Re: echo and hello bug

2009-06-08 Thread Peter Cros
May be of interest - This is the module subset I am using with fat grub efi rev 2202 for 64/32bit efi on Imac81, MacBookPro41, MacBook21. ( ./fatglue.py grub2202fat.efi grub2202-32.efi grub2202-64.efi ) I dont use hello, but echo works. appleldr boot cat cmp chain configfile crc date echo ext2