Re: [RFC] USB Support

2008-08-28 Thread Felix Zielcke
Am Mittwoch, den 27.08.2008, 21:56 +0200 schrieb Marco Gerards: > Hi, Hello Marco, not that big as you might have expected, but maybe not that bad start. I try to get more used to this :) > - Broken OHCI support, it works in QEMu but I haven't tested on real > hardware. Please do not review

grub 1.96 svn 20080813 and circular lvm2 metadata

2008-08-28 Thread Hans Lambermont
Hi all, My colleague Jan Derk Gerlings found a bug in the way grub 1.96, svn version 20080813 (and earlier) reads the circular lvm2 metadata buffer. If the lvm2 metadata is too large to fit in the buffer given an offset, then it is continued at the start of the buffer. In this case the current gr

Re: grub 1.96 svn 20080813 and circular lvm2 metadata

2008-08-28 Thread Felix Zielcke
Am Donnerstag, den 28.08.2008, 13:14 +0200 schrieb Hans Lambermont: > Hi all, Hello, > My colleague Jan Derk Gerlings found a bug in the way grub 1.96, svn > version 20080813 (and earlier) reads the circular lvm2 metadata buffer. Great, on Debian BTS we have 2 bugs [0] related to LVM and I wasn

[PATCH] new static const char[] modname

2008-08-28 Thread Felix Zielcke
Javier brought up [0], with his drivemap patch, the idea to use static const char[] modname = "module name" Here's now a patch for a few files I found where this seems to be useful. I don't think it's useful to add the variable for files which ends up in a file.mod but where it's not used at all.

Re: [PATCH] new static const char[] modname

2008-08-28 Thread Felix Zielcke
Seems like it isn't that bad to review your own patches _before_ sending them and actually to compile them .. -- Felix Zielcke Index: disk/lvm.c === --- disk/lvm.c (Revision 1831) +++ disk/lvm.c (Arbeitskopie) @@ -24,6 +24,8 @@ #in

Re: [PATCH] new static const char[] modname

2008-08-28 Thread Marco Gerards
Felix Zielcke <[EMAIL PROTECTED]> writes: > Seems like it isn't that bad to review your own patches _before_ sending > them and actually to compile them .. ...and include a changelog entry? ;-) -- Marco ___ Grub-devel mailing list Grub-devel@gnu.org

Re: [PATCH] new static const char[] modname

2008-08-28 Thread Felix Zielcke
Am Donnerstag, den 28.08.2008, 20:31 +0200 schrieb Marco Gerards: > Felix Zielcke <[EMAIL PROTECTED]> writes: > > > Seems like it isn't that bad to review your own patches _before_ sending > > them and actually to compile them .. > > ...and include a changelog entry? ;-) That's evolution's fault

Re: [Question] multi-CDROM Devices

2008-08-28 Thread Pavel Roskin
On Tue, 2008-08-26 at 09:40 +0800, y.volta wrote: > Hi, > > i tried the latest grub2 on my virtual machine with two CD-ROMs. > but, i can access only one of them. I read the biosdisk.c, here is > a "static int cd_drive = 0;" > > so i think, we can modify it to support more than one CD-RO

Re: Build problems on powerpc

2008-08-28 Thread Pavel Roskin
On Fri, 2008-08-15 at 19:34 +0300, Vesa Jääskeläinen wrote: > Thomas Champagne wrote: > > kernel_elf-kern_disk.o: In function `grub_disk_close': > > /home/lafeuil/grub2/kern/disk.c:318: undefined reference to > > `grub_get_time_ms' I've fixed it. kern/time.c should be linked into kernel.elf. >

[PATCH] Add grub_prefix for PowerPC

2008-08-28 Thread Pavel Roskin
ChangeLog: * kern/powerpc/ieee1275/crt0.S: Include grub/symbol.h and grub/cpu/kernel.h. Add start label for consistency with other platforms. Add grub_prefix immediately after start. Add jump to the code after grub_prefix. * include/grub/powerpc/kernel.h:

[patch] background_image: image centering and scaling

2008-08-28 Thread Olaf Mandel
Hello, on (some) computers with LCD monitors, the image is not automatically scaled to full screen if the video mode is set to a lower resolution. So the user has to set the gfxmode variable to the correct value in this case. But then the background image provided by their distribution needs to be