[PATCH] Ignore case when opening files in FAT

2008-07-25 Thread Bean
Hi, As FAT is basically a case insensitive file system, we should ignore case when opening files. For example, normally efi image would be placed in EFI/grub directory. After startup, the prefix would be set to something like (hd0,1)/EFI/grub/. But inside grub, it convert pathname to lowercase, E

Re: [PATCH] Ignore case when opening files in FAT

2008-07-25 Thread Markus Halm
Hi, > +#define GRUB_FAT_MAXPATH 260 I may be wrong, but AFAIK FAT only supports a length of 255 chars for filenames, including the path. So this should be set to 255 instead of 260. Or did I miss something? --- Markus ___ Grub-devel mailing list

Re: Linking

2008-07-25 Thread Viswesh S
Hi, So if I add a module or add a new command,which are the files which I should modify in general and which all gets generated automatically. Is this somewhere documented ? Why is it that hello command is put in a separate directory, while lspci is put inside the commands directory. Is there a s

Re: Linking

2008-07-25 Thread Viswesh S
The reason for hello to be put in a directory because it is a module and not a simple command.Understood myself - Original Message From: Viswesh S <[EMAIL PROTECTED]> To: The development of GRUB 2 Sent: Friday, 25 July, 2008 3:44:48 PM Subject: Re: Linking Hi,   So if I add a module

Re: [PATCH] Ignore case when opening files in FAT

2008-07-25 Thread Bean
On Fri, Jul 25, 2008 at 3:49 PM, Markus Halm <[EMAIL PROTECTED]> wrote: > Hi, > >> +#define GRUB_FAT_MAXPATH 260 > I may be wrong, but AFAIK FAT only supports a length of 255 chars for > filenames, including the path. So this should be set to 255 instead of 260. > Or did I miss something? Hi,

Re: Linking

2008-07-25 Thread Colin D Bennett
On Fri, 25 Jul 2008 03:22:57 -0700 (PDT) Viswesh S <[EMAIL PROTECTED]> wrote: > The reason for hello to be put in a directory because it is a module > and not a simple command.Understood myself Actually, no. Every C source file in the 'commands' directory is currently a module itself. I think t

Re: Linking

2008-07-25 Thread Viswesh S
Suppose I am adding a new command,so should I create a new file for that command and modify only the command,rmk accordingly? All the other files get autogenerated by autogen.sh ? Is this sufficient ? Viswesh - Original Message From: Colin D Bennett <[EMAIL PROTECTED]> To: grub-devel@g

Re: Linking

2008-07-25 Thread Colin D Bennett
On Fri, 25 Jul 2008 07:33:41 -0700 (PDT) Viswesh S <[EMAIL PROTECTED]> wrote: > Suppose I am adding a new command,so should I create a new file for > that command and modify only the command,rmk accordingly? All the > other files get autogenerated by autogen.sh ? Is this sufficient ? > Viswesh Ye

Remove conf/*.mk from svn (was: Re: Linking)

2008-07-25 Thread Colin D Bennett
On Thu, 24 Jul 2008 22:17:06 -0700 (PDT) Viswesh S <[EMAIL PROTECTED]> wrote: > I have modified the conf/common.mk accordingly as shown below. GRUB developers, I think we should remove conf/*.mk from the Subversion repository. If people are going to be developing on GRUB and checking out svn br

[PATCH] Misc patches for grub2

2008-07-25 Thread Bean
Hi, This is a collection of miscellaneous patches, it includes: 1, move util/envblk.c to lib/envblk.c As envblk.c is used by module loadenv and tool grub-editenv, I think it's better to move it to lib directory. 2. seperate hexdump function, and move it to lib/hexdump.c hexdump module consists

Re: [PATCH] Misc patches for grub2

2008-07-25 Thread Chris Knadle
On Friday 25 July 2008, Bean wrote: > 4. rename appleloader command to bootcamp > > The name appleloader may be a little confusing, bootcamp seems to be a > better choice. Rather than patching all of the content from appleloader.c to bootcamp.c you may want to consider doing a 'git-mv' to rena

Re: [PATCH] Misc patches for grub2

2008-07-25 Thread Bean
On Sat, Jul 26, 2008 at 1:19 AM, Chris Knadle <[EMAIL PROTECTED]> wrote: > On Friday 25 July 2008, Bean wrote: >> 4. rename appleloader command to bootcamp >> >> The name appleloader may be a little confusing, bootcamp seems to be a >> better choice. > > Rather than patching all of the content fr

Re: Remove conf/*.mk from svn

2008-07-25 Thread Christian Franke
Colin D Bennett wrote: On Thu, 24 Jul 2008 22:17:06 -0700 (PDT) Viswesh S <...> wrote: I have modified the conf/common.mk accordingly as shown below. GRUB developers, I think we should remove conf/*.mk from the Subversion repository. If people are going to be developing on GRUB and

Re: [PATCH] Misc patches for grub2

2008-07-25 Thread Chris Knadle
On Friday 25 July 2008, Bean wrote: > On Sat, Jul 26, 2008 at 1:19 AM, Chris Knadle <[EMAIL PROTECTED]> wrote: > > On Friday 25 July 2008, Bean wrote: > >> 4. rename appleloader command to bootcamp > >> > >> The name appleloader may be a little confusing, bootcamp seems to be a > >> better choice.

Re: grub-probe fails to find PC partition due to Apple disklabel

2008-07-25 Thread Robert Millan
On Wed, Jul 23, 2008 at 04:47:42PM -0400, Chris Knadle wrote: > On Wednesday 23 July 2008, Chris Knadle wrote: > > Right now part_map_iterate() detects an Apple partition based on Sector 0 > > [which is unavoidable, since Sector 0 is not going to have an HFS+ magic > > number] > >Sorry, I mean

Re: Putting core.img anywhere

2008-07-25 Thread Robert Millan
On Wed, Jul 23, 2008 at 11:40:27AM +0200, Jean-Christophe Haessig wrote: > > Furthermore, the scheme you propose looks overly complicated [1] > > Complicated ?? You must be kidding me ! A ten-year old would understand > it. It is way more complicated to include filesystem support in a > bootloader

Re: [PATCH] Abort grub-install if prefix cannot be determined

2008-07-25 Thread Robert Millan
On Thu, Jul 24, 2008 at 07:39:24AM +0200, Christian Franke wrote: > grub-install does not check error return from > make_system_path_relative_to_its_root() fails. > > BTW: Unlike the other scripts, grub-install does not 'set -e'. Is this > intentional or historic ?-) I think it's historic. Wou

Re: [PATCH] update-grub for Cygwin

2008-07-25 Thread Robert Millan
On Thu, Jul 24, 2008 at 10:19:17PM +0200, Christian Franke wrote: > + case "`uname 2>/dev/null`" in > +CYGWIN*) Could this be done at build time instead? (when generating update-grub from update-grub.in) -- Robert Millan I know my rights; I want my phone call! What good is a phone call…

Re: [PATCH] update-grub for Cygwin

2008-07-25 Thread Robert Millan
On Thu, Jul 24, 2008 at 10:39:04PM +0200, Christian Franke wrote: > + > +d="`${grub_probe} -t drive "$p" 2>/dev/null`" || exit 0 Please avoid reliing on '-t drive'. It's based on device.map which just contains guesswork. prepare_grub_to_access_device() is a much better option. -- Robert Millan

Re: Remove conf/*.mk from svn (was: Re: Linking)

2008-07-25 Thread Robert Millan
On Fri, Jul 25, 2008 at 08:18:27AM -0700, Colin D Bennett wrote: > On Thu, 24 Jul 2008 22:17:06 -0700 (PDT) > Viswesh S <[EMAIL PROTECTED]> wrote: > > > I have modified the conf/common.mk accordingly as shown below. > > GRUB developers, > > I think we should remove conf/*.mk from the Subversion

Re: [PATCH] Ignore case when opening files in FAT

2008-07-25 Thread Robert Millan
On Fri, Jul 25, 2008 at 03:28:45PM +0800, Bean wrote: > Hi, > > As FAT is basically a case insensitive file system, we should ignore > case when opening files. I don't agree with this. FAT itself just stores names in ASCII, which provides both cases. It's up to the reader whether to be case sen

Re: [PATCH] Misc patches for grub2

2008-07-25 Thread Robert Millan
On Sat, Jul 26, 2008 at 12:38:59AM +0800, Bean wrote: > 4. rename appleloader command to bootcamp > > The name appleloader may be a little confusing, bootcamp seems to be a > better choice. I'm not sure if this would comply with Apple trademarks. What does this command do? -- Robert Millan I

Re: Issue with boot != root and chainloading

2008-07-25 Thread Robert Millan
On Thu, Jul 24, 2008 at 12:49:05PM -0400, Pavel Roskin wrote: > > As I said, GRUB uses its internal ID instead of BIOS ID. We need to fix > it. Why not just remove that logic and use UUIDs instead? It would also simplify the code both in grub-setup and in kernel, maybe even make it smaller. --

Re: Issue with boot != root and chainloading

2008-07-25 Thread Pavel Roskin
On Fri, 2008-07-25 at 23:08 +0200, Robert Millan wrote: > On Thu, Jul 24, 2008 at 12:49:05PM -0400, Pavel Roskin wrote: > > > > As I said, GRUB uses its internal ID instead of BIOS ID. We need to fix > > it. > > Why not just remove that logic and use UUIDs instead? It would also simplify > the

Re: [PATCH] Abort grub-install if prefix cannot be determined

2008-07-25 Thread Pavel Roskin
On Fri, 2008-07-25 at 22:37 +0200, Robert Millan wrote: > On Thu, Jul 24, 2008 at 07:39:24AM +0200, Christian Franke wrote: > > grub-install does not check error return from > > make_system_path_relative_to_its_root() fails. > > > > BTW: Unlike the other scripts, grub-install does not 'set -e'. I

[PATCH] use UUIDs for cross-disk installs (Re: Issue with boot != root and chainloading)

2008-07-25 Thread Robert Millan
On Fri, Jul 25, 2008 at 05:47:00PM -0400, Pavel Roskin wrote: > On Fri, 2008-07-25 at 23:08 +0200, Robert Millan wrote: > > On Thu, Jul 24, 2008 at 12:49:05PM -0400, Pavel Roskin wrote: > > > > > > As I said, GRUB uses its internal ID instead of BIOS ID. We need to fix > > > it. > > > > Why not

Re: grub-probe fails to find PC partition due to Apple disklabel

2008-07-25 Thread Chris Knadle
On Friday 25 July 2008, Robert Millan wrote: > On Wed, Jul 23, 2008 at 04:47:42PM -0400, Chris Knadle wrote: > > On Wednesday 23 July 2008, Chris Knadle wrote: > > > Right now part_map_iterate() detects an Apple partition based on Sector > > > 0 [which is unavoidable, since Sector 0 is not going to

Re: Bug#475718: Bug #475718 grub gets confused by hybrid apple/pc partmap

2008-07-25 Thread Robert Millan
On Fri, Jul 25, 2008 at 07:36:25PM -0400, Chris Knadle wrote: > >If you ask me, I think this unfortunately looks like a complex detection > problem -- which I think is eventually going to start with a *successful* > detection of the Apple partition (because Apple + PC partitions can > co-ex

Re: Bug#475718: Bug #475718 grub gets confused by hybrid apple/pc partmap

2008-07-25 Thread Chris Knadle
On Friday 25 July 2008, Robert Millan wrote: > On Fri, Jul 25, 2008 at 07:36:25PM -0400, Chris Knadle wrote: > >If you ask me, I think this unfortunately looks like a complex > > detection problem -- which I think is eventually going to start with a > > *successful* detection of the Apple parti

Re: [PATCH] use UUIDs for cross-disk installs (Re: Issue with boot != root and chainloading)

2008-07-25 Thread Pavel Roskin
On Sat, 2008-07-26 at 00:10 +0200, Robert Millan wrote: > See attached patch. I'm afraid it doesn't make kernel smaller as promised; > I expected to get rid of make_install_device() in kernel, but later noticed > that this is still needed for non-cross installs. I like your patch. We should try

Re: [PATCH] Ignore case when opening files in FAT

2008-07-25 Thread Bean
On Sat, Jul 26, 2008 at 4:51 AM, Robert Millan <[EMAIL PROTECTED]> wrote: > On Fri, Jul 25, 2008 at 03:28:45PM +0800, Bean wrote: >> Hi, >> >> As FAT is basically a case insensitive file system, we should ignore >> case when opening files. > > I don't agree with this. FAT itself just stores names

Re: [PATCH] Misc patches for grub2

2008-07-25 Thread Bean
On Sat, Jul 26, 2008 at 4:53 AM, Robert Millan <[EMAIL PROTECTED]> wrote: > On Sat, Jul 26, 2008 at 12:38:59AM +0800, Bean wrote: >> 4. rename appleloader command to bootcamp >> >> The name appleloader may be a little confusing, bootcamp seems to be a >> better choice. > > I'm not sure if this woul