See ChangeLog for description. I'd really like to receive some review on
this one, since the code it touches is so fragile (although I tested it on a
typical setup and it works).
--
Robert Millan
I know my rights; I want my phone call!
What good is a phone call… if you are unable to speak?
(
On Tue, Jul 01, 2008 at 03:25:32PM +0200, Robert Millan wrote:
>
> See ChangeLog for description. I'd really like to receive some review on
> this one, since the code it touches is so fragile (although I tested it on a
> typical setup and it works).
Tough luck. Inmediately after this I noticed
On Mon, Jun 30, 2008 at 09:06:28PM +0800, Bean wrote:
> Hi,
>
> This is the new patch, some changes:
>
> 1, envblk.h, remove GRUB_ENVBLK_RDIR and the like, they're not needed
> in this patch.
> 2, util/envblk.c, use grub_* function for string manipulation.
> 3, commands/loadenv.c, use grub_disk_r
On Mon, Jun 30, 2008 at 12:23:42PM -0400, Pavel Roskin wrote:
> On Mon, 2008-06-30 at 18:08 +0800, Bean wrote:
>
> > If no one objects, I'd like to commit this soon.
>
> No objection from me. I was about to ask you to commit it.
No objection either
--
Robert Millan
I know my rights; I want
On Mon, Jun 30, 2008 at 01:13:34PM -0400, Pavel Roskin wrote:
> On Sun, 2008-06-29 at 13:22 +0200, Robert Millan wrote:
> > On Thu, Jun 26, 2008 at 05:20:51PM +0200, Javier Martín wrote:
>
> > > Whoops, sorry, I meant that grub_mkimage would create two core.img
> > > images, one per kernel.img ver
On Mon, Jun 30, 2008 at 08:33:45PM +0300, Vesa Jääskeläinen wrote:
>
> One way to proceed here is to use debugger for the original benchmarking
> purpose.
>
> You would put timed breakpoints, when breakpoint is found, time would be
> recorded and then execution would be automatically continued.
On Tue, 2008-07-01 at 17:59 +0200, Robert Millan wrote:
> > Adding a complicated mechanism for having debug and non-debug images
> > looks like an overkill to me. It could create more problems than it
> > would fix.
>
> But then, what do you suggest? That we remove debug support altogether?
Ke
On Mon, Jun 30, 2008 at 05:02:50AM +0200, Javier Martín wrote:
>
> Here is the patch I was talking about, one step farther than I had first
> envisioned, i.e. not just about ext4 but an (solid?) implementation of
> "xenophobia" in the filesystem driver. This code checks the superblock
> backwards-
On Mon, Jun 30, 2008 at 08:27:50PM +0800, Bean wrote:
> On Mon, Jun 30, 2008 at 8:12 PM, Javier Martín <[EMAIL PROTECTED]> wrote:
> > El lun, 30-06-2008 a las 07:14 -0400, Isaac Dupree escribió:
> >> > +#define EXT3_FEATURE_INCOMPAT_RECOVER 0x0004 /* Needs
> >> > recovery */
> >>
> >>
On Tue, 2008-07-01 at 18:08 +0200, Robert Millan wrote:
> > We must not quit if the journal flag is set, even if we don't handle
> > it. grub-setup runs in a active system, the journal wouldn't be empty.
> > If we just quit, we can't even install.
>
> I think we should be more conservative here,
Dear grub developers,
Debian's grub1 had a nice feature where its update-grub script would
create additional stanzas with different arguments for each kernel
it found. You configured it like this:
## altoption boot targets option
## multiple altoptions lines are allowed
## e.g. altoptions=(
On Tue, Jul 01, 2008 at 12:01:57PM -0400, Pavel Roskin wrote:
> On Tue, 2008-07-01 at 17:59 +0200, Robert Millan wrote:
>
> > > Adding a complicated mechanism for having debug and non-debug images
> > > looks like an overkill to me. It could create more problems than it
> > > would fix.
> >
> >
Hi,
Not sure why grub-devel didn't receive the updates, as it was CCed. Anyway,
SVN is enabled now.
See https://savannah.gnu.org/svn/?group=grub
and https://savannah.gnu.org/support/?106422
--
Robert Millan
I know my rights; I want my phone call!
What good is a phone call… if you are unab
Robert Millan wrote:
Hi,
Not sure why grub-devel didn't receive the updates, as it was CCed. Anyway,
SVN is enabled now.
See https://savannah.gnu.org/svn/?group=grub
and https://savannah.gnu.org/support/?106422
grub-devel is member only mailing list and it should stay like that.
But nice t
On Tue, Jul 01, 2008 at 08:48:04PM +0300, Vesa Jääskeläinen wrote:
> Robert Millan wrote:
> >Hi,
> >
> >Not sure why grub-devel didn't receive the updates, as it was CCed.
> >Anyway,
> >SVN is enabled now.
> >
> >See https://savannah.gnu.org/svn/?group=grub
> >
> >and https://savannah.gnu.org/sup
On Tue, Jul 01, 2008 at 06:55:37PM +0200, martin f krafft wrote:
> Dear grub developers,
>
> Debian's grub1 had a nice feature where its update-grub script would
> create additional stanzas with different arguments for each kernel
> it found. You configured it like this:
>
> ## altoption boot t
El mar, 01-07-2008 a las 12:25 -0400, Pavel Roskin escribió:
> On Tue, 2008-07-01 at 18:08 +0200, Robert Millan wrote:
>
> > > We must not quit if the journal flag is set, even if we don't handle
> > > it. grub-setup runs in a active system, the journal wouldn't be empty.
> > > If we just quit, we
On Tue, 2008-07-01 at 20:42 +0200, Javier Martín wrote:
> Well, what can I say about this: INCOMPAT_* flags are so for a reason,
> and they are telling us "don't even try to read this filesystem if you
> don't implement this". It's true that _maybe_ the files we need don't
> have extents, or compr
On Tue, Jul 01, 2008 at 08:42:39PM +0200, Javier Martín wrote:
> partition as "unrecognized" and then I had to specifically request it to
> be mounted as ext2 with a possible --ignore-incompatible flag,
A --ignore-incompatible flag doesn't sound like a nice thing to do; it means
we're passing our
On Tue, 2008-07-01 at 19:25 +0200, Robert Millan wrote:
> Hi,
>
> Not sure why grub-devel didn't receive the updates, as it was CCed. Anyway,
> SVN is enabled now.
>
> See https://savannah.gnu.org/svn/?group=grub
>
> and https://savannah.gnu.org/support/?106422
I've changed git import to use t
El mar, 01-07-2008 a las 22:48 +0200, Robert Millan escribió:
> On Tue, Jul 01, 2008 at 08:42:39PM +0200, Javier Martín wrote:
> > partition as "unrecognized" and then I had to specifically request it to
> > be mounted as ext2 with a possible --ignore-incompatible flag,
>
> A --ignore-incompatible
El mar, 01-07-2008 a las 22:48 +0200, Robert Millan escribió:
> On Tue, Jul 01, 2008 at 08:42:39PM +0200, Javier Martín wrote:
> > partition as "unrecognized" and then I had to specifically request it to
> > be mounted as ext2 with a possible --ignore-incompatible flag,
>
> A --ignore-incompatible
ChangeLog:
* fs/xfs.c (struct grub_xfs_dir_header): Use names similar to
those in Linux XFS code. Provide a way to access 64-bit parent
inode.
(grub_xfs_iterate_dir): Use the new names. Avoid reading past
the end of struct grub_xfs_dir_header.
---
fs/xfs.
On Tue, 2008-07-01 at 19:19 +0200, Robert Millan wrote:
> On Tue, Jul 01, 2008 at 12:01:57PM -0400, Pavel Roskin wrote:
> > On Tue, 2008-07-01 at 17:59 +0200, Robert Millan wrote:
> >
> > > > Adding a complicated mechanism for having debug and non-debug images
> > > > looks like an overkill to me.
This doesn't make any difference to the compiled files, but suppresses
linker warnings on systems where build ID is enabled by default, such as
Fedora 9.
ChangeLog:
* Makefile.in (MODULE_LDFLAGS): New variable.
* aclocal.m4 (grub_PROG_LD_BUILD_ID_NONE): New macro. Check if
Hello!
I wonder if we would be better off without grub_size_t. I cannot think
of any code that could use it legitimately.
The ordinary size_t is used to represent the result of sizeof, i.e. size
of a structure. There is no need for grub to support data structures
exceeding 4 gigabytes. If we w
El mar, 01-07-2008 a las 22:14 -0400, Pavel Roskin escribió:
> Hello!
>
> I wonder if we would be better off without grub_size_t. I cannot think
> of any code that could use it legitimately.
>
> The ordinary size_t is used to represent the result of sizeof, i.e. size
> of a structure. There is
Quoting Javier Martín <[EMAIL PROTECTED]>:
El mar, 01-07-2008 a las 22:14 -0400, Pavel Roskin escribió:
Hello!
I wonder if we would be better off without grub_size_t. I cannot think
of any code that could use it legitimately.
The ordinary size_t is used to represent the result of sizeof, i.e
28 matches
Mail list logo
