Re: grub-probe detects ext4 wronly as ext2

2008-06-30 Thread Felix Zielcke
From: "JavierMartín" <[EMAIL PROTECTED]> Sent: Monday, June 30, 2008 5:02 AM Phew, that was all (I hope) Cheers! Habbit Thank you for the patch. Just tried it out, it works fine ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.or

Re: [PATCH] Loading windows in macbook

2008-06-30 Thread Bean
Hi, Oh, actually a20 of macbook can be disabled with fast a20 port 92. However, the current a20 code do the keyboard controller test before trying port 92, which cause it to hang. To fix it, I only need to adjust the order of tests. -- Bean diff --git a/kern/i386/pc/startup.S b/kern/i386/pc/star

Re: [PATCH] Patch for the open hackware

2008-06-30 Thread Bean
On Wed, Jun 18, 2008 at 1:45 AM, Bean <[EMAIL PROTECTED]> wrote: > On Wed, Jun 18, 2008 at 1:39 AM, Robert Millan <[EMAIL PROTECTED]> wrote: >> On Tue, Jun 17, 2008 at 11:44:36PM +0800, Bean wrote: >>> + if (grub_ieee1275_test_flag (GRUB_IEEE1275_FLAG_CANNOT_INTERPRET)) >>> +{ >>> + grub_

Re: grub-probe detects ext4 wronly as ext2

2008-06-30 Thread Isaac Dupree
+#define EXT3_FEATURE_INCOMPAT_RECOVER 0x0004 /* Needs recovery */ +#define EXT2_DRIVER_SUPPORTED_INCOMPAT ( EXT2_FEATURE_INCOMPAT_FILETYPE ) I suspect this will mean that journalled ext3 when the system crashed (so the filesystem "needs recovery" from the journal) won't load. (O

Re: grub-probe detects ext4 wronly as ext2

2008-06-30 Thread Javier Martín
El lun, 30-06-2008 a las 07:14 -0400, Isaac Dupree escribió: > > +#define EXT3_FEATURE_INCOMPAT_RECOVER 0x0004 /* Needs > > recovery */ > > > +#define EXT2_DRIVER_SUPPORTED_INCOMPAT ( EXT2_FEATURE_INCOMPAT_FILETYPE ) > > I suspect this will mean that journalled ext3 when the system

Re: grub-probe detects ext4 wronly as ext2

2008-06-30 Thread Bean
On Mon, Jun 30, 2008 at 8:12 PM, Javier Martín <[EMAIL PROTECTED]> wrote: > El lun, 30-06-2008 a las 07:14 -0400, Isaac Dupree escribió: >> > +#define EXT3_FEATURE_INCOMPAT_RECOVER 0x0004 /* Needs >> > recovery */ >> >> > +#define EXT2_DRIVER_SUPPORTED_INCOMPAT ( EXT2_FEATURE_INCOMPAT

Re: grub-probe detects ext4 wronly as ext2

2008-06-30 Thread Javier Martín
Hi there, El lun, 30-06-2008 a las 20:27 +0800, Bean escribió: > Hi, > > We must not quit if the journal flag is set, even if we don't handle > it. grub-setup runs in a active system, the journal wouldn't be empty. > If we just quit, we can't even install. > If you mean the "needs_recovery" fla

Re: [PATCH] Save/Load environment variable support

2008-06-30 Thread Bean
Hi, This is the new patch, some changes: 1, envblk.h, remove GRUB_ENVBLK_RDIR and the like, they're not needed in this patch. 2, util/envblk.c, use grub_* function for string manipulation. 3, commands/loadenv.c, use grub_disk_read/grub_disk_write to read/write disk, the problem of lower level api

Re: [PATCH] Patch for the open hackware

2008-06-30 Thread Pavel Roskin
On Mon, 2008-06-30 at 18:08 +0800, Bean wrote: > If no one objects, I'd like to commit this soon. No objection from me. I was about to ask you to commit it. -- Regards, Pavel Roskin ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.or

Re: [PATCH] add a counter in grub_dprintf

2008-06-30 Thread Pavel Roskin
On Sun, 2008-06-29 at 13:22 +0200, Robert Millan wrote: > On Thu, Jun 26, 2008 at 05:20:51PM +0200, Javier Martín wrote: > > Whoops, sorry, I meant that grub_mkimage would create two core.img > > images, one per kernel.img version, and then grub_install would copy > > them as usual. Then grub_setu

Re: [PATCH] add a counter in grub_dprintf

2008-06-30 Thread Vesa Jääskeläinen
Pavel Roskin wrote: On Sun, 2008-06-29 at 13:22 +0200, Robert Millan wrote: On Thu, Jun 26, 2008 at 05:20:51PM +0200, Javier Martín wrote: Whoops, sorry, I meant that grub_mkimage would create two core.img images, one per kernel.img version, and then grub_install would copy them as usual. The

Re: [PATCH] Fix chainloding + Chainloading into logical partitions

2008-06-30 Thread Fulvio Scapin
2008/6/30 Lucas Gadani <[EMAIL PROTECTED]>: > Hello, > > This is my first patch for GRUB, and I haven't found any coding > styles/formatting, nor developer documentation, so, if there's > something wrong, please, forgive me and point me to the right > direction. > > Current implementation of the c

Re: [PATCH] Small fix in grub-setup

2008-06-30 Thread Pavel Roskin
On Mon, 2008-06-30 at 03:58 +0200, Javier Martín wrote: > Here goes a small fix to a grub-setup error that has driven /me crazy > for the last 4 hours: in the recent split between core_path and > core_path_dev, one occurrence of the former that should have been turned > into the latter was not, thu

Re: New developer available :)

2008-06-30 Thread walt
Bean wrote: On Mon, Jun 30, 2008 at 4:43 AM, walt<[EMAIL PROTECTED]> wrote: ...I'm using grub4dos because grub2 won't (yet) boot a floppy image or chainload Vista's bootmgr. Hi, Well, you can actually achieve these function with some external tools. Using memdisk, you can emulate a floppy/h

Re: [RFC PATCH] Sector 2 of non-embedded core.img: write early or patch later?

2008-06-30 Thread Pavel Roskin
On Sat, 2008-06-28 at 12:58 +0800, Bean wrote: > On Sat, Jun 28, 2008 at 5:24 AM, Pavel Roskin <[EMAIL PROTECTED]> wrote: > > I tend to prefer the later ("write early") approach, but I'd like to see > > some feedback before I commit it. > > Hi, > > The problem of write early is that it changes th

Re: New developer available :)

2008-06-30 Thread Bean
On Tue, Jul 1, 2008 at 5:59 AM, walt <[EMAIL PROTECTED]> wrote: > Bean wrote: >> >> On Mon, Jun 30, 2008 at 4:43 AM, walt<[EMAIL PROTECTED]> wrote: >>> >>> ...I'm using grub4dos because >>> grub2 won't (yet) boot a floppy image or chainload Vista's bootmgr. > >> Hi, >> >> Well, you can actually ac