Sugguestion: separate input and output driver

2008-05-29 Thread Bean
Currently, input and output are bundled together, this make it quite difficult to extend. Input: Keyboard, Serial Output: Text mode, Video mode Now, the binding is fixed using individual module: Keyboard + Text = console Keyboard + Video = gfxterm Serial + Text = serial Serial + Video = ? And

Grub long delays loading

2008-05-29 Thread Guenter.Ebermann
Hello, I'am running Grub on a standard i386 compatible PC. Grub comes pre-compiled from debian stable distribution. The hard drive where Grub is installed is Serial ATA. 1. Output of /etc/fstab: proc/proc procdefaults0 0 rootfs / reiserfs

Re: [PATCH] x86_64 EFI support for grub2

2008-05-29 Thread Robert Millan
On Thu, May 29, 2008 at 01:52:15PM +0800, Bean wrote: > + > +COMMON_ASFLAGS = -nostdinc -fno-builtin -m64 > +COMMON_CFLAGS = -fno-builtin -m64 > +COMMON_LDFLAGS = -melf_x86_64 -nostdlib How much does this file differ from its i386 version? If it's just a few flags, we could solve this with variab

Re: [PATCH] Scan root device dynamically at startup

2008-05-29 Thread Robert Millan
On Wed, May 28, 2008 at 10:53:07PM +0800, Bean wrote: > > In function grub_set_root_dev (main.c), it uses prefix to calculated > root, so setting prefix is sufficient. > > About the name, well, findprefix works for me too. > > > Also, what this module is doing looks very similar to "search --set

Re: Sugguestion: separate input and output driver

2008-05-29 Thread Robert Millan
On Thu, May 29, 2008 at 04:09:54PM +0800, Bean wrote: > struct grub_input > { > } > > + > > struct grub_output > { > } I suggest grub_term_input / grub_term_output, to avoid confusion with disk I/O. -- Robert Millan I know my rights; I want my phone call! What good is a phone call… if you a

Re: Sugguestion: separate input and output driver

2008-05-29 Thread Robert Millan
On Thu, May 29, 2008 at 04:09:54PM +0800, Bean wrote: > Currently, input and output are bundled together, this make it quite > difficult to extend. > > Input: > Keyboard, Serial > > Output: > Text mode, Video mode > > Now, the binding is fixed using individual module: > > Keyboard + Text = cons

Re: [PATCH] Scan root device dynamically at startup

2008-05-29 Thread Bean
On Thu, May 29, 2008 at 5:58 PM, Robert Millan <[EMAIL PROTECTED]> wrote: > On Wed, May 28, 2008 at 10:53:07PM +0800, Bean wrote: >> >> In function grub_set_root_dev (main.c), it uses prefix to calculated >> root, so setting prefix is sufficient. >> >> About the name, well, findprefix works for me

Re: Sugguestion: separate input and output driver

2008-05-29 Thread Marco Gerards
Bean <[EMAIL PROTECTED]> writes: > Currently, input and output are bundled together, this make it quite > difficult to extend. > > Input: > Keyboard, Serial > > Output: > Text mode, Video mode > > Now, the binding is fixed using individual module: > > Keyboard + Text = console > Keyboard + Video =

Re: [PATCH] Scan root device dynamically at startup

2008-05-29 Thread Tomáš Ebenlendr
Dne 29 Květen 2008, 12:46, Bean napsal(a): > I think this is the most convenient way of installing grub2 in vista. > User don't need any customization. They just add the entry and copy > /boot/grub to any supported partition. Besides, our driver currently > don't support UUID, and some partition

Re: [PATCH] Scan root device dynamically at startup

2008-05-29 Thread Robert Millan
On Thu, May 29, 2008 at 02:05:59PM +0200, Tomáš Ebenlendr wrote: > > Dne 29 Květen 2008, 12:46, Bean napsal(a): > > > I think this is the most convenient way of installing grub2 in vista. > > User don't need any customization. They just add the entry and copy > > /boot/grub to any supported parti

Re: [PATCH] Scan root device dynamically at startup

2008-05-29 Thread Robert Millan
On Thu, May 29, 2008 at 06:46:25PM +0800, Bean wrote: > > > > I've been thinking a bit more about this, and my impression is that it the > > approach is quite ad-hoc. For example, some similar problems that this > > solution wouldn't solve, but that a very similar solution would: > > > > a- norma

[PATCH] UUID support

2008-05-29 Thread Robert Millan
This patch implements UUID support in ext2, then in grub-probe and search command, and finally in update-grub scripts. The result is that when UUID can be used (i.e. our /boot is ext2), update-grub puts the number in grub.cfg as a parameter to search command, and no longer relies on hardcoded val

GRUB integral types? Why grub_uint32_t and not uint32_t?

2008-05-29 Thread Colin D Bennett
I was wondering why it is necessary to use the integral types with the "grub_" prefix instead of the standard uint32_t, int16_t, etc.? It makes the most simple code much more verbose when we have to write "grub_" so many times, and this seems like a case where it is not needed. Colin __

Re: GRUB integral types? Why grub_uint32_t and not uint32_t?

2008-05-29 Thread Robert Millan
On Thu, May 29, 2008 at 08:57:56AM -0700, Colin D Bennett wrote: > I was wondering why it is necessary to use the integral types with > the "grub_" prefix instead of the standard uint32_t, int16_t, etc.? > > It makes the most simple code much more verbose when we have to write > "grub_" so many ti

Re: [PATCH] UUID support

2008-05-29 Thread Bean
On Thu, May 29, 2008 at 11:13 PM, Robert Millan <[EMAIL PROTECTED]> wrote: > > This patch implements UUID support in ext2, then in grub-probe and search > command, and finally in update-grub scripts. > > The result is that when UUID can be used (i.e. our /boot is ext2), update-grub > puts the numbe

Re: [PATCH] UUID support

2008-05-29 Thread Robert Millan
On Fri, May 30, 2008 at 12:50:42AM +0800, Bean wrote: > > BTW, I think we can embed the UUID of the root device in > core.img/grub.elf, so that when the traditional root device fails to > locate normal.mod, it uses the UUID to scan for root device. Good idea. But I'd check for UUID first. When

Re: [PATCH] UUID support

2008-05-29 Thread Bean
On Fri, May 30, 2008 at 2:17 AM, Robert Millan <[EMAIL PROTECTED]> wrote: > On Fri, May 30, 2008 at 12:50:42AM +0800, Bean wrote: >> >> BTW, I think we can embed the UUID of the root device in >> core.img/grub.elf, so that when the traditional root device fails to >> locate normal.mod, it uses the

Re: Grub long delays loading

2008-05-29 Thread Pavel Roskin
On Thu, 2008-05-29 at 10:41 +0200, [EMAIL PROTECTED] wrote: > Hello, > > I'am running Grub on a standard i386 compatible PC. Grub comes pre-compiled > from debian stable distribution. This mailing list is about GRUB2. I heard it's available in Debian, but I'm not sure about the stable distributi

Re: Grub long delays loading

2008-05-29 Thread Vesa Jääskeläinen
Pavel Roskin wrote: The mailing list about GRUB1 is [EMAIL PROTECTED] Now a days more descriptive: [EMAIL PROTECTED] http://lists.gnu.org/mailman/listinfo/help-grub ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listi

Re: [PATCH] arbitrary drive names in device.map

2008-05-29 Thread Pavel Roskin
On Wed, 2008-05-28 at 23:36 +0200, Robert Millan wrote: > Hi, > > This patch fixed the device.map handlers to accept any device name for grub > drives, rather than just BIOS-style "hd[0-9]" and "fd[0-9]". It makes > update-grub usable on OFW, Coreboot, etc. > > Any comments? That's a very welco

Re: Replacing the legacy "map" command

2008-05-29 Thread Pavel Roskin
On Wed, 2008-05-28 at 16:24 +0200, Robert Millan wrote: > On Tue, May 27, 2008 at 11:59:22AM -0400, Pavel Roskin wrote: > > > > Again, I'd like to see the command name shortened, perhaps to "drivemap" > > or "map". It's not like users will need to distinguish BIOS and > > non-BIOS mappings. > >

Re: Replacing the legacy "map" command

2008-05-29 Thread Javier Martín
Then "drivemap" it is. I've already been delving into the depths of The Source, though I'd have preferred it to be commented a bit more exhaustively. Some times it's difficult to guess which methods to call, and it took me a bit to realize that I had to check with the disk "device" to see if it was

Re: Replacing the legacy "map" command

2008-05-29 Thread Pavel Roskin
Quoting Javier Martín <[EMAIL PROTECTED]>: Then "drivemap" it is. I've already been delving into the depths of The Source, though I'd have preferred it to be commented a bit more exhaustively. Some times it's difficult to guess which methods to call, and it took me a bit to realize that I had to

Re: grub-probe gets a segfault

2008-05-29 Thread Pavel Roskin
Quoting "Isaac M. Marcos" <[EMAIL PROTECTED]>: So I'd recommend to get this patch in. If that makes you feel better about this, how about adding a warning message in this fail condition? (though, note we have many fail conditions like this one in that function, and these don't have any warning