Re: [PATCH] jpeg image reader

2008-01-13 Thread Bean
Hi, change the handling of width/height that's not aligned, now it use the exact size instead of padding. /* * GRUB -- GRand Unified Bootloader * Copyright (C) 2008 Free Software Foundation, Inc. * * GRUB is free software: you can redistribute it and/or modify * it under the terms of

Re: ata.mod hangs (Re: Some grub2 problems/questions)

2008-01-13 Thread Robert Millan
On Sat, Jan 12, 2008 at 04:14:38PM -0800, walt wrote: > > I'm happy to report that the ata module no longer hangs as I described > above. I'm guessing (just a guess) that this commit fixed it: > > 2008-01-10 Robert Millan <[EMAIL PROTECTED]> > * kern/device.c (grub_device_iterate): Do not

Re: (still ?) root on LVM problems

2008-01-13 Thread Robert Millan
On Sun, Jan 13, 2008 at 01:12:42AM +0100, Jean-Christophe Haessig wrote: > Le dimanche 13 janvier 2008 à 00:26 +0100, Robert Millan a écrit : > > > Try re-running grub-setup with verbose flag on, and see what it prints. > > orion:/test/grub2# /usr/local/sbin/grub-setup --verbose '(hd1)' > grub-se

Re: Fwd: grub2: FTBFS on powerpc (__floatundisf in ls is not defined)

2008-01-13 Thread Robert Millan
On Wed, Dec 26, 2007 at 10:21:16AM +0100, Robert Millan wrote: > diff -ur grub2-1.95+20071101/include/grub/powerpc/libgcc.h > grub2-1.95+20071101.new/include/grub/powerpc/libgcc.h > --- grub2-1.95+20071101/include/grub/powerpc/libgcc.h 2007-07-21 > 23:32:24.0 + > +++ grub2-1.95+2007

Re: (still ?) root on LVM problems

2008-01-13 Thread Jean-Christophe Haessig
Le dimanche 13 janvier 2008 à 11:57 +0100, Robert Millan a écrit : > LVM doesn't reserve any space at the beginning of its partitions? Most > filesystems do. I created a new empty volume group with an empty disk to do some testing. The lvm label identifying physical disks can be put in sector 0

Re: ata.mod hangs (Re: Some grub2 problems/questions)

2008-01-13 Thread Vesa Jääskeläinen
Robert Millan wrote: On Sat, Jan 12, 2008 at 04:14:38PM -0800, walt wrote: Unfortunately, ata.mod still doesn't recognize the disk on the Promise sata controller. But, that's expected at this point? Yes. Some SATA controllers emulate PATA, but not all do. I suppose there are multiple contr

Re: (still ?) root on LVM problems

2008-01-13 Thread Robert Millan
On Sun, Jan 13, 2008 at 01:12:44PM +0100, Jean-Christophe Haessig wrote: > Le dimanche 13 janvier 2008 à 11:57 +0100, Robert Millan a écrit : > > > LVM doesn't reserve any space at the beginning of its partitions? Most > > filesystems do. > > I created a new empty volume group with an empty disk

Re: [PATCH] Use getopt_long() instead of argp_parse() in grub-emu

2008-01-13 Thread Marco Gerards
Christian Franke <[EMAIL PROTECTED]> writes: > Unlike the other GRUB2 utils, grub-emu uses the glibc extension > argp_parse(). It is unavailable on Cygwin, which might also be the > case for other platforms where glibc is not the native runtime. > > This patch changes this back to the more traditi

Re: revision control of `configure'

2008-01-13 Thread Marco Gerards
Pavel Roskin <[EMAIL PROTECTED]> writes: > On Tue, 2008-01-08 at 12:57 +0100, Robert Millan wrote: >> http://cvs.savannah.gnu.org/viewvc/grub2/configure?root=grub&view=log >> >> Does it make sense to keep `configure' under revision control? Almost every >> commit for unrelated things tends to ch

Re: [PATCH] jpeg image reader

2008-01-13 Thread Marco Gerards
Bean <[EMAIL PROTECTED]> writes: Hi, > change the handling of width/height that's not aligned, now it use the > exact size instead of padding. You forgot the changelog entry. I'll do a quick review. Especially the longjmp stuff should be changed, IMO. Otherwise the code is of good quality and

Re: [PATCH] Bug fix for parser

2008-01-13 Thread Marco Gerards
Bean <[EMAIL PROTECTED]> writes: Hi, > I write a patch for parser related bug, it fix the following problems: > > 1, major modification for parse.y, now it should work better. For example, > > if echo aa; echo bb; then echo cc; fi > > it works properly now. Nice :-) > 2, Check for undefined var

Re: ata.mod hangs (Re: Some grub2 problems/questions)

2008-01-13 Thread walt
Robert Millan wrote: On Sat, Jan 12, 2008 at 04:14:38PM -0800, walt wrote: I'm happy to report that the ata module no longer hangs as I described above. I'm guessing (just a guess) that this commit fixed it: 2008-01-10 Robert Millan<[EMAIL PROTECTED]> * kern/device.c (grub_device_iterate

help with powerpc asm (moving grub_ieee1275_entry_fn initialization to crt0.S)

2008-01-13 Thread Robert Millan
Hi, For the i386-ieee1275 port, I'd need to move grub_ieee1275_entry_fn initialization in powerpc from cmain.c to crt0.S, so that code in cmain.c can be shared with i386. The problem is I have no clue about powerpc assembler. On i386, this is just done with a "movl %eax, EXT_C(grub_ieee1275_ent

Re: [PATCH] Bug fix for parser

2008-01-13 Thread Bean
On Jan 14, 2008 2:42 AM, Marco Gerards <[EMAIL PROTECTED]> wrote: > > @@ -99,6 +101,9 @@ grub_script_execute_cmdline (struct grub_script_cmd *cmd) > >grubcmd = grub_command_find (cmdline->cmdname); > >if (! grubcmd) > > { > > + /* Ignore errors. */ > > + grub_errno = GRUB_ER

[PATCH] portable exit() in IEEE-1275

2008-01-13 Thread Robert Millan
This patch reimplements grub_exit() portably as a wrapper. The exit client service is defined in IEEE-1275. Anyway, just to be sure: Please, can someone test my patch to check it won't break on Apple, IBM... ? -- Robert Millan I know my rights; I want my phone call! What use is a phone call

Re: Transparent decompression with file system filter

2008-01-13 Thread Yoshinori K. Okuji
On Sunday 13 January 2008 08:38, Bean wrote: > Hi, > > any suggestion about this patch ? i would like to commit it soon. I am sorry that I forgot to reply. I would like to know how you intend to approach the following issues: - If you want to support, for example, an ecrypted and compressed file

Re: Fwd: grub2: FTBFS on powerpc (__floatundisf in ls is not defined)

2008-01-13 Thread Yoshinori K. Okuji
On Sunday 13 January 2008 13:19, Robert Millan wrote: > This is becoming a nightmare. I think it's better if we just exclude > symbols starting with __ from our checks. They aren't really meant for us > to mess with. My original suggestion was that we could extract (required) symbols from libgc

Re: revision control of `configure'

2008-01-13 Thread Yoshinori K. Okuji
On Sunday 13 January 2008 19:06, Marco Gerards wrote: > Pavel Roskin <[EMAIL PROTECTED]> writes: > > On Tue, 2008-01-08 at 12:57 +0100, Robert Millan wrote: > >> http://cvs.savannah.gnu.org/viewvc/grub2/configure?root=grub&view=log > >> > >> Does it make sense to keep `configure' under revision con

[PATCH] restrict parsing of `available'

2008-01-13 Thread Robert Millan
Another patch for i386-ieee1275. Again, I'd appreciate if someone can test it on PowerPC hardware. -- Robert Millan I know my rights; I want my phone call! What use is a phone call, if you are unable to speak? (as seen on /.) * kern/powerpc/ieee1275/openfw.c (grub_available_iterate): Obtai

Re: (still ?) root on LVM problems

2008-01-13 Thread Jean-Christophe Haessig
Le dimanche 13 janvier 2008 à 14:52 +0100, Robert Millan a écrit : > What happens if you comment out the "must_embed = 1" line? orion:/test/grub2# /usr/local/sbin/grub-setup --verbose '(hd1)' grub-setup: info: prefix = /grub grub-setup: info: changing current directory to /dev/mapper grub-setup:

Re: Transparent decompression with file system filter

2008-01-13 Thread Bean
On Jan 14, 2008 3:51 AM, Yoshinori K. Okuji <[EMAIL PROTECTED]> wrote: > On Sunday 13 January 2008 08:38, Bean wrote: > > Hi, > > > > any suggestion about this patch ? i would like to commit it soon. > > I am sorry that I forgot to reply. > > I would like to know how you intend to approach the foll

Re: Fwd: grub2: FTBFS on powerpc (__floatundisf in ls is not defined)

2008-01-13 Thread Robert Millan
On Sun, Jan 13, 2008 at 08:53:49PM +0100, Yoshinori K. Okuji wrote: > On Sunday 13 January 2008 13:19, Robert Millan wrote: > > This is becoming a nightmare. I think it's better if we just exclude > > symbols starting with __ from our checks. They aren't really meant for us > > to mess with. > >

Re: [PATCH] restrict parsing of `available'

2008-01-13 Thread Robert Millan
On Sun, Jan 13, 2008 at 09:06:06PM +0100, Robert Millan wrote: > + grub_size_t available_size; Actually, this would be grub_ssize_t. -- Robert Millan I know my rights; I want my phone call! What use is a phone call, if you are unable to speak? (as seen on /.) __

[PATCH] fix endianess in IEEE-1275 integer properties

2008-01-13 Thread Robert Millan
Integer properties are always in big endian. This (incomplete) patch is my suggested approach to deal with this. I'd like to receive input about it before I complete it (checking all calls to grub_ieee1275_get_property through GRUB and replacing with grub_ieee1275_get_integer_property when appro

Re: Fwd: grub2: FTBFS on powerpc (__floatundisf in ls is not defined)

2008-01-13 Thread Yoshinori K. Okuji
On Sunday 13 January 2008 21:16, Robert Millan wrote: > On Sun, Jan 13, 2008 at 08:53:49PM +0100, Yoshinori K. Okuji wrote: > > On Sunday 13 January 2008 13:19, Robert Millan wrote: > > > This is becoming a nightmare. I think it's better if we just exclude > > > symbols starting with __ from our c

Re: Transparent decompression with file system filter

2008-01-13 Thread Yoshinori K. Okuji
On Sunday 13 January 2008 21:16, Bean wrote: > > - If you want to support, for example, an ecrypted and compressed file, > > in the current implementation, each hook must try other hooks > > recursively. I believe that this should be done at grub_file_open_ex > > rather than at every hook. Is there

Re: (still ?) root on LVM problems

2008-01-13 Thread Jean-Christophe Haessig
Le dimanche 13 janvier 2008 à 21:09 +0100, Jean-Christophe Haessig a écrit : > Le dimanche 13 janvier 2008 à 14:52 +0100, Robert Millan a écrit : > > > What happens if you comment out the "must_embed = 1" line? > > orion:/test/grub2# /usr/local/sbin/grub-setup --verbose '(hd1)' […] > grub-setup: