Re: [PATCH] split realmode and loader routines out of startup.S

2007-10-17 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > This patch splits realmode and loader routines out of startup.S. The idea > is that the LinuxBIOS port can be adapted to share more code with the rest > of GRUB instead of duplicating it. > > This is quite critical stuff, so even if the change seems tri

Re: [PATCH] split realmode and loader routines out of startup.S

2007-10-17 Thread Robert Millan
On Wed, Oct 17, 2007 at 10:32:28AM +0200, Marco Gerards wrote: > > * kern/i386/pc/startup.S (grub_linux_prot_size): Moved to ... > > * kern/i386/loader.S (grub_linux_prot_size): ... here. > > I would say: > > (...): Moved from here... > (...): ... to here. > > Can you change that? Ok (A

[PATCH] split i386-generic part of i386/pc/loader.h

2007-10-17 Thread Robert Millan
This patch splits the i386-generic part of i386/pc/loader.h into i386/loader.h. Comments? -- Robert Millan I know my rights; I want my phone call! What use is a phone call, if you are unable to speak? (as seen on /.) 2007-10-17 Robert Millan <[EMAIL PROTECTED]> * include/grub/i386/loader

Re: [PATCH] split i386-generic part of i386/pc/loader.h

2007-10-17 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: Hi, [...] > 2007-10-17 Robert Millan <[EMAIL PROTECTED]> > > * include/grub/i386/loader.h: New file. > > * include/grub/i386/pc/loader.h (grub_linux_prot_size): Moved to ... > * include/grub/i386/loader.h (grub_linux_prot_size): ... h

Re: [PATCH] split i386-generic part of i386/pc/loader.h

2007-10-17 Thread Robert Millan
Committed. -- Robert Millan I know my rights; I want my phone call! What use is a phone call, if you are unable to speak? (as seen on /.) ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] split realmode and loader routines out of startup.S

2007-10-17 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Wed, Oct 17, 2007 at 10:32:28AM +0200, Marco Gerards wrote: >> >* kern/i386/pc/startup.S (grub_linux_prot_size): Moved to ... >> >* kern/i386/loader.S (grub_linux_prot_size): ... here. >> >> I would say: >> >> (...): Moved from here... >> (.

Re: [PATCH] split realmode and loader routines out of startup.S

2007-10-17 Thread Robert Millan
On Wed, Oct 17, 2007 at 12:04:14PM +0200, Marco Gerards wrote: > > > > Linking required wrapping a lot of references with EXT_C() macro, so I opted > > for #include (note this is done for lzo1x.S already). > > Is using EXT_C a problem? I don't know this code too well, > unfortunately :( No. May

Re: [PATCH] Implement grub_sleep() and grub_ticksleep()

2007-10-17 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Tue, Oct 16, 2007 at 08:46:16PM +0200, Marco Gerards wrote: >> > >> > That's what grub_ticksleep does. grub_sleep() counts in seconds because >> > I tried to mimic POSIX which seems to be a trend for grub_* functions. I >> > think it can be used for

Re: [PATCH] split realmode and loader routines out of startup.S

2007-10-17 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Wed, Oct 17, 2007 at 12:04:14PM +0200, Marco Gerards wrote: >> > >> > Linking required wrapping a lot of references with EXT_C() macro, so I >> > opted >> > for #include (note this is done for lzo1x.S already). >> >> Is using EXT_C a problem? I don

Re: [PATCH] split i386-generic part of i386/pc/loader.h

2007-10-17 Thread Vesa Jääskeläinen
Robert Millan wrote: > This patch splits the i386-generic part of i386/pc/loader.h into > i386/loader.h. > > Comments? Why did you move stuff from i386/pc to i386 ? I do see a point on running grub2 on non-pc i386... ___ Grub-devel mailing list Grub

Re: [PATCH] ELF program header

2007-10-17 Thread Stefan Reinauer
* Robert Millan <[EMAIL PROTECTED]> [071014 14:00]: > > We tried the same but the patch was a lot bigger, trying to actually > > leave space in the beginning. Your patch might be enough, that would be > > really nice. > > That's the question. Do we really have to add more space, or is that space

Re: [PATCH] split i386-generic part of i386/pc/loader.h

2007-10-17 Thread Robert Millan
On Wed, Oct 17, 2007 at 09:17:54PM +0300, Vesa Jääskeläinen wrote: > Robert Millan wrote: > > This patch splits the i386-generic part of i386/pc/loader.h into > > i386/loader.h. > > > > Comments? > > Why did you move stuff from i386/pc to i386 ? > > I do see a point on running grub2 on non-pc i