On 09/06/07, Bean <[EMAIL PROTECTED]> wrote:
I try the following command:
set AA=1
set BB=$AA
Taking a quick look at command.c where the "set" command is defined,
it doesn't look like that feature is implemented. Even in grub_env_set
in env.c it isn't implemented.
I'm willing to implement thi
I'm willing to implement this feature... Where do you, devs, think
this would be better suited? In the set command, or in the
grub_env_set function?
Hmm, after some further thought, I think it would make more sense to
put it in grub_env_set function because that allows the feature to be
use thro
On 09/06/07, Alex Roman <[EMAIL PROTECTED]> wrote:
Hmm, after some further thought, I think it would make more sense to
put it in grub_env_set function because that allows the feature to be
use throughout the grub2 source code... It could be useful in some
places...
I'm trying to code this feat
On Sat, Jun 09, 2007 at 03:01:12AM -0400, Alex Roman wrote:
> >BTW, i notice that echo.c exists, but no echo.mod is generated.
>
> Because echo is such a "core" command it is built right into the kernel
> AFAIK...
>
But when i try to use it in the grub console, it says unknown command:
grub> e
On 09/06/07, Alex Roman <[EMAIL PROTECTED]> wrote:
I'm trying to code this feature but I'm noticing something peculiar...
In command.c, function set_command I do the following just before "var
= args[0];":
grub_printf( "args[0]: %s\n", args[0] );
If args[0] contains a '$', the string is displa
Bean <[EMAIL PROTECTED]> writes:
> I try the following command:
>
> set AA=1
> set BB=$AA
>
> then type set, it shows:
>
> AA=1
> BB=
>
> should the value of BB be 1 ?
This is a known bug :-/
> BTW, i notice that echo.c exists, but no echo.mod is generated.
I will have a look at this.
--
Marco
"Alex Roman" <[EMAIL PROTECTED]> writes:
> On 09/06/07, Bean <[EMAIL PROTECTED]> wrote:
>> I try the following command:
>>
>> set AA=1
>> set BB=$AA
>
> Taking a quick look at command.c where the "set" command is defined,
> it doesn't look like that feature is implemented. Even in grub_env_set
> i
On 09/06/07, Marco Gerards <[EMAIL PROTECTED]> wrote:
"Alex Roman" <[EMAIL PROTECTED]> writes:
> On 09/06/07, Bean <[EMAIL PROTECTED]> wrote:
>> I try the following command:
>>
>> set AA=1
>> set BB=$AA
>
> Taking a quick look at command.c where the "set" command is defined,
> it doesn't look li
"Alex Roman" <[EMAIL PROTECTED]> writes:
[...]
>> >> BTW, i notice that echo.c exists, but no echo.mod is generated.
>> >
>> > Because echo is such a "core" command it is built right into the kernel
>> > AFAIK...
>>
>> No, it's even a normal mode command.
>
> So, is it built as part of a module
Bean <[EMAIL PROTECTED]> writes:
> Add unicode support for NTFS file system driver
> Fix a bug in the unicode conversion function grub_utf16_to_utf8 in kern/misc.c
Can you please include the patches inline? That way they are easier
to review.
The normal procedure for patches is to make them con
On Sat, Jun 09, 2007 at 08:05:45PM +0200, Marco Gerards wrote:
>
> The normal procedure for patches is to make them consistent with the
> GCS (GNU Coding Standards), include a changelog. That way it is
> easier to review the patch and to include it in GRUB 2.
>
Can you give me an example ?
>
> D
11 matches
Mail list logo