[patch 2/3] grub efi initrd image memory allocation 4K alignment

2006-10-24 Thread bibo,mao
Hi, On grub efi platform, initrd image memory allocation start address must be 4K alignment, else it will fail to alloc memory for initrd image. thanks bibo,mao diff -Nruap grub2.org/loader/i386/efi/linux.c grub2/loader/i386/efi/linux.c --- grub2.org/loader/i386/efi/linux.c 2006-10-24 13:24

[PATCH 3/3] grub EFI disk device enumberating

2006-10-24 Thread bibo,mao
Hi, On EFI platform, every partition is regarded as one block device and responding EFI device path. EFI device patch has the same hierarchical relationship with the partition. This patch will search root EFI device path by current device patch, but not parent device path. Original grub can not

Pot 41980USD

2006-10-24 Thread Petra Harrell
Hey Grub-devel!.! Roller Casino, we are so surey ou are going to love our games that we are giving you up to USD888.00 FREE just fo rtrying our Casino. $ 888.00 FREE! Clikc Here Now! http://laseert.com/c/63 +++ climbed the ladder. I followed at a far more moderate pac

Re: [PATCH 3/3] grub EFI disk device enumberating

2006-10-24 Thread Johan Rydberg
"bibo,mao" <[EMAIL PROTECTED]> writes: > Previously I posted this patch, now I repost again. > Any suggestion is welcome. I will just give a comment here. Please do not treat it as a full review, I'll leave that to Okuji. > +static int compare_ancestor_path(const grub_efi_device_path_t *paren

Re: [PATCH 1/3] grub efi memory map patch

2006-10-24 Thread Johan Rydberg
"bibo,mao" <[EMAIL PROTECTED]> writes: > This patch moves find_mmap_size from i386/efi/linux.c to > kern/efi/mm.c, and renamed as grub_efi_find_mmap_size, so that > other arch on EFI platform can use this function. Good call. > Also this function solves memory map too small problem, > on some EF

Re: [PATCH 3/3] grub EFI disk device enumberating

2006-10-24 Thread Johan Rydberg
Johan Rydberg <[EMAIL PROTECTED]> writes: > This code can be shorter; you only have to compare the lengths. If > they match, you can do a memcmp on the whole device path. It could look something like this; /* Returns zero if device path SUBPATH is a subpath of device path PATH. */ static i

Re: [PATCH] generic ELF loading

2006-10-24 Thread Hollis Blanchard
On Sat, 2006-10-14 at 17:33 +0200, Yoshinori K. Okuji wrote: > On Saturday 14 October 2006 00:37, Hollis Blanchard wrote: > > This patch adds generic ELF loading infrastructure for both 32-bit and > > 64-bit ELF. It provides an "iterate" function for program headers, and a > > "load" function for c

Re: [PATCH] generic ELF loading

2006-10-24 Thread Johan Rydberg
Hollis Blanchard <[EMAIL PROTECTED]> writes: >> The idea is very good. But I don't like that loaded areas are always >> allocated >> from the heap. GRUB has a staging area for OS images on i386-pc, and I >> prefer >> to load an image directly instead of consuming the heap. > > Actually I'm not

RE: [PATCH] generic ELF loading

2006-10-24 Thread Hollis Blanchard
On Sat, 2006-10-14 at 11:03 +0800, Mao, Bibo wrote: >I do not know whether it is possible to add one element in > structure grub_elf_file structure to identify ELF type > (ELFCLASS32/ELFCLASS64) and ELF machine type, this element can be set > at function grub_elf_open. I'm not sure it saves mu

Re: [PATCH] generic ELF loading

2006-10-24 Thread Hollis Blanchard
On Sat, 2006-10-14 at 19:23 +0200, Tristan Gingold wrote: > On Sat, Oct 14, 2006 at 05:33:44PM +0200, Yoshinori K. Okuji wrote: > > On Saturday 14 October 2006 00:37, Hollis Blanchard wrote: > > > This patch adds generic ELF loading infrastructure for both 32-bit and > > > 64-bit ELF. It provides a

Re: [PATCH] generic ELF loading

2006-10-24 Thread Hollis Blanchard
On Tue, 2006-10-24 at 22:48 +0200, Johan Rydberg wrote: > Hollis Blanchard <[EMAIL PROTECTED]> writes: > > >> The idea is very good. But I don't like that loaded areas are always > >> allocated > >> from the heap. GRUB has a staging area for OS images on i386-pc, and I > >> prefer > >> to load

Re: Bug#390473: grub2: menuentry stanza doesn't accept $ { } in variable substitutions

2006-10-24 Thread Luca Capello
reopen 390473 retitle 390473 grub2: menuentry stanza with additional $ or { causes boot panic found 390473 1.95-1 thanks Hi Robert! NB: forwarding again to grub-devel, but setting M-F-T and R-T to the bug, Robert (I hope you don't mind) and myself. On Tue, 24 Oct 2006 15:29:09 +0200, Robert Mill

Re: [PATCH 1/3] grub efi memory map patch

2006-10-24 Thread bibo,mao
hi johan, Thanks for review my patch, I reply in lines. Johan Rydberg wrote: "bibo,mao" <[EMAIL PROTECTED]> writes: > This patch moves find_mmap_size from i386/efi/linux.c to > kern/efi/mm.c, and renamed as grub_efi_find_mmap_size, so that > other arch on EFI platform can use this functio

Re: [patch 2/3] grub efi initrd image memory allocation 4K alignment

2006-10-24 Thread bibo,mao
This patch is sent for second time. thanks bibo,mao diff -Nrup grub2.org/loader/i386/efi/linux.c grub2/loader/i386/efi/linux.c --- grub2.org/loader/i386/efi/linux.c 2006-10-25 12:15:25.0 +0800 +++ grub2/loader/i386/efi/linux.c 2006-10-25 11:40:24.0 +0800 @@ -587,7 +587,6

Re: [PATCH 3/3] grub EFI disk device enumberating

2006-10-24 Thread bibo,mao
Johan Rydberg wrote: Johan Rydberg <[EMAIL PROTECTED]> writes: > This code can be shorter; you only have to compare the lengths. If > they match, you can do a memcmp on the whole device path. It could look something like this; /* Returns zero if device path SUBPATH is a subpath of device p

Re: [PATCH] generic ELF loading

2006-10-24 Thread Yoshinori K. Okuji
On Tuesday 24 October 2006 22:03, Hollis Blanchard wrote: > Actually I'm not using the heap, I'm just directly copying wherever > phdr->p_paddr says to. That's not a good thing actually; in the future > we should add some error checking to make sure we don't clobber GRUB > itself. OK, then it's ev