Re: [PATCH] Set size of partition correctly in grub_disk_open()

2006-07-09 Thread Jeroen Dekkers
At Sun, 9 Jul 2006 03:11:33 +0200, Yoshinori K. Okuji wrote: > > > No. When you open something, you usually have no interest in the size. > > > > Yes, but those unusual places that do have interest in it want to know > > the size of the partition and not the size of the disk that contains > > the p

Re: [PATCH] Set size of partition correctly in grub_disk_open()

2006-07-09 Thread Yoshinori K. Okuji
On Sunday 09 July 2006 14:01, Jeroen Dekkers wrote: > I don't see anything like that in the code when I grep for > total_sectors. The only code that is using total_sectors as the size > of the disk is the grub_disk_check_range(), but that function is also > interested in whether the offset/size fit

Re: [PATCH] Set size of partition correctly in grub_disk_open()

2006-07-09 Thread Tomáš Ebenlendr
Maybe Jeroen (and me) thinks that a 'disk' and 'partition' does not differ, as there can be some strange disk with filesystem directly on it (some flash memories, etc.) and also partitions containing another partitions. Standard terminology typically defines 'disk' as "root" partition. I.e. its pa

Re: [PATCH] Set size of partition correctly in grub_disk_open()

2006-07-09 Thread Jeroen Dekkers
At Sun, 9 Jul 2006 15:29:17 +0200, Yoshinori K. Okuji wrote: > > On Sunday 09 July 2006 14:01, Jeroen Dekkers wrote: > > I don't see anything like that in the code when I grep for > > total_sectors. The only code that is using total_sectors as the size > > of the disk is the grub_disk_check_range(