Re: [PATCH] Set size of partition correctly in grub_disk_open()

2006-07-08 Thread Yoshinori K. Okuji
Hi Jeroen, On Wednesday 05 July 2006 22:54, Jeroen Dekkers wrote: >if (p) > -disk->partition = grub_partition_probe (disk, p + 1); > +{ > + disk->partition = grub_partition_probe (disk, p + 1); > + if (! disk->partition) > + { > + grub_error (GRUB_ERR_UNKNOWN_DEVICE

Re: [PATCH] Set size of partition correctly in grub_disk_open()

2006-07-08 Thread Jeroen Dekkers
At Sat, 8 Jul 2006 18:07:44 +0200, Yoshinori K. Okuji wrote: > > Hi Jeroen, > > On Wednesday 05 July 2006 22:54, Jeroen Dekkers wrote: > > + > > + disk->total_sectors = grub_partition_get_len (disk->partition); > > +} > > But I don't agree with this part. The member "total_sectors" must

Re: [PATCH] Set size of partition correctly in grub_disk_open()

2006-07-08 Thread Yoshinori K. Okuji
On Saturday 08 July 2006 22:39, Jeroen Dekkers wrote: > But it's a little bit illogical that the size you get from the same > disk structure isn't the size of the partition, but the size of > something else. It is not illogical from my point of view. The disk structure should describe the informa

Re: [PATCH] Set size of partition correctly in grub_disk_open()

2006-07-08 Thread Jeroen Dekkers
At Sat, 8 Jul 2006 23:10:56 +0200, Yoshinori K. Okuji wrote: > > On Saturday 08 July 2006 22:39, Jeroen Dekkers wrote: > > But it's a little bit illogical that the size you get from the same > > disk structure isn't the size of the partition, but the size of > > something else. > > It is not illo

Re: [PATCH] Set size of partition correctly in grub_disk_open()

2006-07-08 Thread Yoshinori K. Okuji
On Sunday 09 July 2006 01:35, Jeroen Dekkers wrote: > The illogical thing for me is: You ask to open a partition, you get > back a structure that has half the properties of the partition, and > the other half has the properties of the disk the partition is on. I don't see this. When you open a par