Re: patch for kern/efi/mm.c (big memmap)

2006-09-28 Thread Marco Gerards
Johan Rydberg <[EMAIL PROTECTED]> writes: > Marco Gerards <[EMAIL PROTECTED]> writes: > >>> + memory_map = grub_efi_allocate_pages >>> +(0, 2 * BYTES_TO_PAGES (memory_map_size + 0x1000)); >>> >>> I suppose you add 0x1000 to round it up. Maybe we should change >>> the BYTES_TO_PAGES macro to

Re: patch for kern/efi/mm.c (big memmap)

2006-09-28 Thread Johan Rydberg
Marco Gerards <[EMAIL PROTECTED]> writes: >> + memory_map = grub_efi_allocate_pages >> +(0, 2 * BYTES_TO_PAGES (memory_map_size + 0x1000)); >> >> I suppose you add 0x1000 to round it up. Maybe we should change >> the BYTES_TO_PAGES macro to do roundup. > > Agreed. Can you make this change a

Re: patch for kern/efi/mm.c (big memmap)

2006-09-28 Thread Marco Gerards
Johan Rydberg <[EMAIL PROTECTED]> writes: > + memory_map = grub_efi_allocate_pages > +(0, 2 * BYTES_TO_PAGES (memory_map_size + 0x1000)); > > I suppose you add 0x1000 to round it up. Maybe we should change the > BYTES_TO_PAGES macro to do roundup. Agreed. Can you make this change as well?

Re: patch for kern/efi/mm.c (big memmap)

2006-09-28 Thread Johan Rydberg
[EMAIL PROTECTED] writes: > some systems have a really big memmap. This patch remove the memmap > size limit. Overall the patch looks good, I have one comment through; (the patch is for kern/efi/mm.c if someone wonders.) + memory_map = grub_efi_allocate_pages +(0, 2 * BYTES_TO_PAGES (memor

Re: patch for kern/efi/mm.c (big memmap)

2006-09-28 Thread Marco Gerards
[EMAIL PROTECTED] writes: > This is on an ia64 system (Tiger). I just noticed that because of your other patches, neat! :-) >> Cool. Can you please send in this patch in unified diff format (diff >> -up) and provide a changelog entry? And while you on it, most people >> here prefer patches bei

Re: patch for kern/efi/mm.c (big memmap)

2006-09-28 Thread tgingold
Quoting Marco Gerards <[EMAIL PROTECTED]>: > [EMAIL PROTECTED] writes: > > Hi, > > First of all, thanks a lot for this patch. > > > some systems have a really big memmap. > > What kind of system are you testing GRUB 2 (EFI) on? It would be nice > to know which systems are already supported. This

Re: patch for kern/efi/mm.c (big memmap)

2006-09-28 Thread Marco Gerards
[EMAIL PROTECTED] writes: Hi, First of all, thanks a lot for this patch. > some systems have a really big memmap. What kind of system are you testing GRUB 2 (EFI) on? It would be nice to know which systems are already supported. > This patch remove the memmap size limit. Cool. Can you pleas

patch for kern/efi/mm.c (big memmap)

2006-09-28 Thread tgingold
Hi, some systems have a really big memmap. This patch remove the memmap size limit. Tristan. mm.diffs Description: Binary data ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel