Re: menu loop (patch)

2008-08-05 Thread Vesa Jääskeläinen
Robert Millan wrote: On Sun, Jul 20, 2008 at 09:21:47AM +0300, [EMAIL PROTECTED] wrote: I also like no wrapping mode. But lets assume we have nice graphical menu with "cylinder" of menu entries that roll when you press key up/down. Oh my god. Tell me you're not planning to implement OpenGL in

Re: menu loop (patch)

2008-07-22 Thread Robert Millan
On Sun, Jul 20, 2008 at 09:21:47AM +0300, [EMAIL PROTECTED] wrote: > > I also like no wrapping mode. But lets assume we have nice graphical menu > with "cylinder" of menu entries that roll when you press key up/down. Oh my god. Tell me you're not planning to implement OpenGL in GRUB! ;-) -- R

Re: menu loop (patch)

2008-07-20 Thread Carles Pina i Estany
Hi, On Jul/20/2008, [EMAIL PROTECTED] wrote: > In every case I would prefer that home and end keys would go to always > to start and to end of the list. Page up/down would rely a bit for > wrapping setting so they can clamp to list edges if needed. home-end keys (without wrapping) are handled i

Re: menu loop (patch)

2008-07-19 Thread chaac
"Yoshinori K. Okuji" [EMAIL PROTECTED] kirjoitti: On Saturday 19 July 2008 21:58:09 Robert Millan wrote: > On Sat, Jul 19, 2008 at 10:34:46AM -0700, Colin D Bennett wrote: > > [...] We could support a setting such as "set menuwrap=1" which > > would enable this feature for users who care about i

Re: menu loop (patch)

2008-07-19 Thread Colin D Bennett
On Sun, 20 Jul 2008 01:31:55 +0200 Carles Pina i Estany <[EMAIL PROTECTED]> wrote: > > Hello, > > On Jul/19/2008, Isaac Dupree wrote: > > Carles Pina i Estany wrote: > >> fast check in KDE: it's looping > >> > >> Also, Iceweasel menus are looping here (maybe because it's executed > >> in KDE and

Re: menu loop (patch)

2008-07-19 Thread Isaac Dupree
Carles Pina i Estany wrote: Hello, On Jul/19/2008, Isaac Dupree wrote: Carles Pina i Estany wrote: fast check in KDE: it's looping Also, Iceweasel menus are looping here (maybe because it's executed in KDE and there is some GTK Widget with a different behaviour? I have no idea) GTK menubar-me

Re: menu loop (patch)

2008-07-19 Thread Carles Pina i Estany
Hello, On Jul/19/2008, Isaac Dupree wrote: > Carles Pina i Estany wrote: >> fast check in KDE: it's looping >> >> Also, Iceweasel menus are looping here (maybe because it's executed >> in KDE and there is some GTK Widget with a different behaviour? I have >> no idea) > > GTK menubar-menus are loo

Re: menu loop (patch)

2008-07-19 Thread Isaac Dupree
Carles Pina i Estany wrote: fast check in KDE: it's looping Also, Iceweasel menus are looping here (maybe because it's executed in KDE and there is some GTK Widget with a different behaviour? I have no idea) GTK menubar-menus are looping for me. But I'm not sure about menus that consist of s

Re: menu loop (patch)

2008-07-19 Thread Colin D Bennett
On Sun, 20 Jul 2008 00:06:40 +0200 Carles Pina i Estany <[EMAIL PROTECTED]> wrote: > > Hello, > > On Jul/19/2008, Colin D Bennett wrote: > > On Sat, 19 Jul 2008 17:40:43 +0200 > > Robert Millan <[EMAIL PROTECTED]> wrote: > > > > > On Thu, Jul 17, 2008 at 11:22:27PM +0200, Carles Pina i Estany >

Re: menu loop (patch)

2008-07-19 Thread Robert Millan
On Sun, Jul 20, 2008 at 12:06:40AM +0200, Carles Pina i Estany wrote: > > > > This would be no problem at all; it's essentially identical to how the > > text mode menu from normal.mod works. It could go either way, and > > certainly would be easy to make it a setting in the theme file (or more >

Re: menu loop (patch)

2008-07-19 Thread Carles Pina i Estany
Hi, On Jul/19/2008, Robert Millan wrote: > On Sat, Jul 19, 2008 at 07:21:34PM +0200, Carles Pina i Estany wrote: > > > I'm not sure if this is intentional. Size is not important in this > > > part of the code, but in other UI menus (e.g. Iceweasel or GNOME) I > > > > fast check in KDE: it's loo

Re: menu loop (patch)

2008-07-19 Thread Carles Pina i Estany
Hello, On Jul/19/2008, Colin D Bennett wrote: > On Sat, 19 Jul 2008 17:40:43 +0200 > Robert Millan <[EMAIL PROTECTED]> wrote: > > > On Thu, Jul 17, 2008 at 11:22:27PM +0200, Carles Pina i Estany wrote: > > > I'm a Grub user (thanks for your nice work!) and I always wanted to > > > have a menu t

Re: menu loop (patch)

2008-07-19 Thread Yoshinori K. Okuji
On Saturday 19 July 2008 21:58:09 Robert Millan wrote: > On Sat, Jul 19, 2008 at 10:34:46AM -0700, Colin D Bennett wrote: > > [...] We could support a setting such as "set menuwrap=1" which > > would enable this feature for users who care about it. > > Isn't this a bit overkill? The time spent ad

Re: menu loop (patch)

2008-07-19 Thread Robert Millan
On Sat, Jul 19, 2008 at 10:34:46AM -0700, Colin D Bennett wrote: > > [...] We could support a setting such as "set menuwrap=1" which > would enable this feature for users who care about it. Isn't this a bit overkill? The time spent adding this config option vastly exceeds any time that could be

Re: menu loop (patch)

2008-07-19 Thread Robert Millan
On Sat, Jul 19, 2008 at 07:21:34PM +0200, Carles Pina i Estany wrote: > > I'm not sure if this is intentional. Size is not important in this > > part of the code, but in other UI menus (e.g. Iceweasel or GNOME) I > > fast check in KDE: it's looping > > Also, Iceweasel menus are looping here (may

Re: menu loop (patch)

2008-07-19 Thread Colin D Bennett
On Sat, 19 Jul 2008 17:40:43 +0200 Robert Millan <[EMAIL PROTECTED]> wrote: > On Thu, Jul 17, 2008 at 11:22:27PM +0200, Carles Pina i Estany wrote: > > > > Hello, > > Carles! Que n'és de petit el món ;-) > > > I'm a Grub user (thanks for your nice work!) and I always wanted to > > have a menu

Re: menu loop (patch)

2008-07-19 Thread Carles Pina i Estany
Hello, On Jul/19/2008, Robert Millan wrote: > On Thu, Jul 17, 2008 at 11:22:27PM +0200, Carles Pina i Estany wrote: > > > > Hello, > > Carles! Que n'és de petit el món ;-) exacte! :-) > > I'm a Grub user (thanks for your nice work!) and I always wanted to have > > a menu that "loops". Like,

Re: menu loop (patch)

2008-07-19 Thread Robert Millan
On Thu, Jul 17, 2008 at 11:22:27PM +0200, Carles Pina i Estany wrote: > > Hello, Carles! Que n'és de petit el món ;-) > I'm a Grub user (thanks for your nice work!) and I always wanted to have > a menu that "loops". Like, if you press down and you are in the last > option it goes to the first o

menu loop (patch)

2008-07-17 Thread Carles Pina i Estany
Hello, I'm a Grub user (thanks for your nice work!) and I always wanted to have a menu that "loops". Like, if you press down and you are in the last option it goes to the first one, and if you press up but you are int he first option goes to the last. Attached comes a patch against revision 1718