Re: keyboard layout patches

2010-01-19 Thread Carles Pina i Estany
Hi, On Jan/20/2010, Robert Millan wrote: > On Mon, Jan 18, 2010 at 07:25:37PM +, Carles Pina i Estany wrote: > > > Also keyboard_layouts is pretty small. Perhaps we can just make > > > *_keyboard depend on it and put US keyboard into it as default and shave > > > some complexity this way > >

Re: keyboard layout patches

2010-01-19 Thread Robert Millan
On Mon, Jan 18, 2010 at 08:04:35PM +, Carles Pina i Estany wrote: > On Jan/18/2010, Vladimir '??-coder/phcoder' Serbinenko wrote: > > > + grub_util_write_image ("GRUBLAY", 7, fp); > > + grub_util_write_image ((char *) &version, 4, fp); > > > > should be macroified and put somewhere in a hea

Re: keyboard layout patches

2010-01-19 Thread Robert Millan
On Mon, Jan 18, 2010 at 07:25:37PM +, Carles Pina i Estany wrote: > > Also keyboard_layouts is pretty small. Perhaps we can just make > > *_keyboard depend on it and put US keyboard into it as default and shave > > some complexity this way > > How it would work in rescue mode and at_keyboard?

Re: keyboard layout patches

2010-01-19 Thread Robert Millan
On Mon, Jan 18, 2010 at 02:53:36PM +0100, Carles Pina i Estany wrote: > > Can you think of a way to restoring keyboard map to English? > > unloading the module restores the original keyboard (so, English one). I save > the original one when the module is loaded. Don't confuse keyboard layouts wit

Re: keyboard layout patches

2010-01-18 Thread Carles Pina i Estany
Hi, On Jan/18/2010, Carles Pina i Estany wrote: > I've done a first version of keyboard_layout. Find a patch attached, or Thanks to the comments from different people in the thread, I send a new version. It does, on from my head: a) Constants used in util/ and Grub are in a common header file.

Re: keyboard layout patches

2010-01-18 Thread Carles Pina i Estany
Hi, On Jan/18/2010, Colin Watson wrote: > On Mon, Jan 18, 2010 at 07:25:37PM +, Carles Pina i Estany wrote: > > a) very short term: what about to register a command to "something" > > (like "1234", numbers doesn't usually change between keyboard, right? > > The standard counterexample is Fre

Re: keyboard layout patches

2010-01-18 Thread Carles Pina i Estany
Hi, On Jan/18/2010, Vladimir '??-coder/phcoder' Serbinenko wrote: > + grub_util_write_image ("GRUBLAY", 7, fp); > + grub_util_write_image ((char *) &version, 4, fp); > > should be macroified and put somewhere in a header instead of duplicating I agree. Any reason that I don't see that in uti

Re: keyboard layout patches

2010-01-18 Thread Colin Watson
On Mon, Jan 18, 2010 at 07:25:37PM +, Carles Pina i Estany wrote: > a) very short term: what about to register a command to "something" > (like "1234", numbers doesn't usually change between keyboard, right? The standard counterexample is French. Function keys do stay constant, though. -- C

Re: keyboard layout patches

2010-01-18 Thread Carles Pina i Estany
Hi, On Jan/18/2010, Vladimir '??-coder/phcoder' Serbinenko wrote: > Carles Pina i Estany wrote: > > Actually if prefix (that it's a variable) is "/" then args[0] acts as a > > filename. Would be like "///test/filename" and it's a valid directory. > > > > > Perhaps we should remove prefix var

Re: keyboard layout patches

2010-01-18 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Carles Pina i Estany wrote: > Hi, > > I answer in fast way... more at evening. Items that I don't comment I > understand and agree. > > On Jan/18/2010, Vladimir '??-coder/phcoder' Serbinenko wrote: > > >>> How could grub-mkinstall (00_header.in) know the current keyboard in the >>> system? >>>

Re: keyboard layout patches

2010-01-18 Thread Carles Pina i Estany
Hi, I answer in fast way... more at evening. Items that I don't comment I understand and agree. On Jan/18/2010, Vladimir '??-coder/phcoder' Serbinenko wrote: > > How could grub-mkinstall (00_header.in) know the current keyboard in the > > system? > setxkbmap -print will give you the x layout b

Re: keyboard layout patches

2010-01-18 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Carles Pina i Estany wrote: > Hello, > > I've done a first version of keyboard_layout. Find a patch attached, or > check the branch: > bzr.savannah.gnu.org/srv/bzr/grub/people/cpina/keyboard_layouts > > I've tested only in at_keyboard. Using something like: > > insmod at_keyboard > terminal_input a

Re: keyboard layout patches

2010-01-18 Thread Felix Zielcke
Am Montag, den 18.01.2010, 00:10 + schrieb Carles Pina i Estany: > Hello, > > I've done a first version of keyboard_layout. Find a patch attached, or > check the branch: > bzr.savannah.gnu.org/srv/bzr/grub/people/cpina/keyboard_layouts Nice work, though I haven't yet looked at the patch itsel

keyboard layout patches

2010-01-17 Thread Carles Pina i Estany
Hello, I've done a first version of keyboard_layout. Find a patch attached, or check the branch: bzr.savannah.gnu.org/srv/bzr/grub/people/cpina/keyboard_layouts I've tested only in at_keyboard. Using something like: insmod at_keyboard terminal_input at_keyboard insmod keyboard_layouts set keyma