On Sun, Feb 08, 2009 at 12:54:29AM +0100, Javier Martín wrote:
> Well, the only thing left to do is adding
> flex_bg - here goes the patch. It also clarifies a comment and corrects
> those added in my original patch and Robert's cleaned-up version that
> don't end with ". */" as they should.
Comm
El sáb, 07-02-2009 a las 20:30 +0100, Felix Zielcke escribió:
> Am Mittwoch, den 04.02.2009, 14:08 +0100 schrieb Javier Martín:
>
> > Well, I am happy to post a diff of the patch against current SVN head
> > (r1973). I have personally confirmed (in a VM) that it:
> > 1) Still builds (and even runs
Am Mittwoch, den 04.02.2009, 14:08 +0100 schrieb Javier Martín:
> Well, I am happy to post a diff of the patch against current SVN head
> (r1973). I have personally confirmed (in a VM) that it:
> 1) Still builds (and even runs! ^^)
> 2) Works with existing ext2/3 file systems (I haven't checked ex
El mié, 04-02-2009 a las 08:41 +0100, Felix Zielcke escribió:
> Am Montag, den 11.08.2008, 16:14 +0200 schrieb Javier Martín:
> > Hi there,
> >
> > After reading Felix's reply I've once again found your post and
> > implemented your request, so here is a new version of the patch
> > ("version 6").
Am Montag, den 11.08.2008, 16:14 +0200 schrieb Javier Martín:
> Hi there,
>
> After reading Felix's reply I've once again found your post and
> implemented your request, so here is a new version of the patch
> ("version 6"). Sorry for missing your message in the first instance...
> u_u
I'd like t
Well, seeing that Robert is back (and what a torrent of activity!), I'll
shamelessly try to resubmit my last post from nearly a month ago in the
hope that he'll notice it.
El sáb, 30-08-2008 a las 23:28 +0200, Javier Martín escribió:
> Hello there! It's nice to be in town again, though post-vacati
Hello there! It's nice to be in town again, though post-vacation
syndrome is hitting me full... Resuming the thread,
El sáb, 30-08-2008 a las 13:17 +0200, Robert Millan escribió:
> On Mon, Aug 11, 2008 at 04:14:00PM +0200, Javier Martín wrote:
> > >> > This overrides the grub_errno and grub_errmsg
On Mon, Aug 11, 2008 at 04:14:00PM +0200, Javier Martín wrote:
> >> > This overrides the grub_errno and grub_errmsg provided by grub_disk_read
> >> > and
> >> > replaces them with values that hide the true problem. If there was a
> >> > disk
> >> > read error, we really want to know about it fro
Hello list,
Am Montag, den 11.08.2008, 16:14 +0200 schrieb Javier Martín:
> Hi there,
>
> After reading Felix's reply I've once again found your post and
> implemented your request, so here is a new version of the patch
> ("version 6"). Sorry for missing your message in the first instance...
> u_
Hi there,
After reading Felix's reply I've once again found your post and
implemented your request, so here is a new version of the patch
("version 6"). Sorry for missing your message in the first instance...
u_u
2008/7/19 Robert Millan <[EMAIL PROTECTED]>:
> On Sat, Jul 05, 2008 at 08:36:13PM +0
Am Montag, den 11.08.2008, 02:35 +0200 schrieb Javier Martín:
> El mié, 06-08-2008 a las 12:36 +0200, Felix Zielcke escribió:
> > [0] http://lists.gnu.org/archive/html/grub-devel/2008-07/msg8.html
> > [1] http://lists.gnu.org/archive/html/grub-devel/2008-07/msg00333.html
> >
> >
>
> Thanks f
El mié, 06-08-2008 a las 12:36 +0200, Felix Zielcke escribió:
> Am Dienstag, den 05.08.2008, 19:23 +0200 schrieb Felix Zielcke:
> > Am Freitag, den 04.07.2008, 03:20 +0200 schrieb Javier Martín:
> >
> > > That was it. I will post no more in this thread. Do whatever you please
> > > with the patch
Am Dienstag, den 05.08.2008, 19:23 +0200 schrieb Felix Zielcke:
> Am Freitag, den 04.07.2008, 03:20 +0200 schrieb Javier Martín:
>
> > That was it. I will post no more in this thread. Do whatever you please
> > with the patch - I'll just request some more people from the GRUB dev
> > team to revie
Am Freitag, den 04.07.2008, 03:20 +0200 schrieb Javier Martín:
> That was it. I will post no more in this thread. Do whatever you please
> with the patch - I'll just request some more people from the GRUB dev
> team to review the thing, instead of the tennis match we've had here
> (and I appreciat
On Sat, Jul 05, 2008 at 08:36:13PM +0200, Javier Martín wrote:
> > >grub_disk_read (disk, 1 * 2, 0, sizeof (struct grub_ext2_sblock),
> > >(char *) &data->sblock);
> > >if (grub_errno)
> > > -goto fail;
> > > +EXT2_DRIVER_MOUNT_FAIL("could not read the superblock
From: "JavierMartín" <[EMAIL PROTECTED]>
Sent: Wednesday, July 16, 2008 9:07 PM
To: "The development of GRUB 2"
Subject: Re: grub-probe detects ext4 wronly as ext2
OK, so this is what I get from your 3 posts, and my proposals for the
driver future:
* meta_bg i
El mié, 16-07-2008 a las 19:44 +0200, Felix Zielcke escribió:
> > Oh well I should have used grep with -i
> > meta_bg and META_BG does make a difference
> >
> > Anyway in release-notes I now found this:
> >
> > Add support for the an alternative block group descriptor layout which
> > allows for on
Oh well I should have used grep with -i
meta_bg and META_BG does make a difference
Anyway in release-notes I now found this:
Add support for the an alternative block group descriptor layout which
allows for on-line resizing without needing to prepare the filesystem
in advance. (This is the in
Oh well I should have used grep with -i
meta_bg and META_BG does make a difference
Anyway in release-notes I now found this:
Add support for the an alternative block group descriptor layout which
allows for on-line resizing without needing to prepare the filesystem
in advance. (This is the inco
From: "JavierMartín" <[EMAIL PROTECTED]>
Sent: Wednesday, July 16, 2008 6:38 PM
To: "The development of GRUB 2"
Subject: Re: grub-probe detects ext4 wronly as ext2
Er... of course, the Linux extN implementation is the de-facto
reference
implementation. Some incompat
El mié, 16-07-2008 a las 17:27 +0200, Felix Zielcke escribió:
> From: "JavierMartín" <[EMAIL PROTECTED]>
> Sent: Wednesday, July 16, 2008 5:09 PM
> To: "The development of GRUB 2"
> Subject: Re: grub-probe detects ext4 wronly as ext2
>
> > I see
From: "JavierMartín" <[EMAIL PROTECTED]>
Sent: Wednesday, July 16, 2008 5:09 PM
To: "The development of GRUB 2"
Subject: Re: grub-probe detects ext4 wronly as ext2
I see the ext4 patch was checked in recently. Can the "forbid-incompat"
patch with the new,
I see the ext4 patch was checked in recently. Can the "forbid-incompat"
patch with the new, specific error messages be committed too then? I'm
submitting an updated version (i.e. against the current HEAD) because
new lines were added.
PS: does the ext4 patch add support for META_BG? it should be a
El sáb, 05-07-2008 a las 14:07 +0200, Robert Millan escribió:
> However, adding new strings is expensive, since they tend to take size more
> easily than code. I would be careful about that.
I checked the space requirements, and seemingly there was a bit of space
available in the .rodata zone, sin
On Fri, Jul 04, 2008 at 10:41:35PM +0200, Javier Martín wrote:
> Wonderful! I was sick of jumping through hoops with cvs diff.
I wasn't even using cvs diff! (you don't want to know what my replacement
dance was) ;-)
> > I'd suggest making the "RW compatible" etc notes a bit more ellaborate to
OK, I've addressed all your concerns and here is a new version of the
patch. With it, the delta-size of the compiled ext2.mod against a
completely unpatched one is just 148 bytes.
El vie, 04-07-2008 a las 20:57 +0200, Robert Millan escribió:
> On Fri, Jul 04, 2008 at 04:45:02PM +0200, Javier Martí
On Fri, Jul 04, 2008 at 04:45:02PM +0200, Javier Martín wrote:
>
> By the way, I'm already using SVN (and thus svn diff) for this patch. Is
> that right? Was the migration completed already?
Yep.
> +/* Superblock filesystem feature flags (RW compatible) */
> +#define EXT2_FEATURE_COMPAT_DIR_PREA
El vie, 04-07-2008 a las 16:21 +0200, Robert Millan escribió:
> If you wish to send a patch for the user environment check you proposed,
> could send it separately? I'm inclined to commit the flag check, but not
> the environment stuff.
Ok, here is the old version of the patch without the user ove
El vie, 04-07-2008 a las 22:11 +0800, Bean escribió:
> About the flags, no one can guarantee that the incompat bit would
> result in an unreadable fs. The journal is a good example. Even with
> journal enabled, we can read from it most of the time.
The journal: EXT3_FEATURE_COMPAT_HAS_JOURNAL (R/W
El vie, 04-07-2008 a las 16:09 +0200, Robert Millan escribió:
> On Fri, Jul 04, 2008 at 02:00:34PM +0200, Javier Martín wrote:
> > In the nearly eight years from ext2 release to the merge of ext3 into
> > the kernel, some incompatible features were introduced in ext2 proper,
> > like filetype and c
On Fri, Jul 04, 2008 at 04:04:56PM +0200, Robert Millan wrote:
>
> If this is really to be considered a problem, we might as well be conservative
> in both grub-probe and real GRUB, and reject unknown flags. Not a big deal,
> since unknown flags aren't really going to use their "experimental" sta
If you wish to send a patch for the user environment check you proposed,
could send it separately? I'm inclined to commit the flag check, but not
the environment stuff.
Afterwards if you like we could discuss about whether we should be
"best-effort" in real GRUB or not. It's really not such a b
On Fri, Jul 4, 2008 at 8:00 PM, Javier Martín <[EMAIL PROTECTED]> wrote:
> El vie, 04-07-2008 a las 19:29 +0800, Bean escribió:
>> On Fri, Jul 4, 2008 at 6:34 PM, Javier Martín <[EMAIL PROTECTED]> wrote:
>> > I know I promised not to keep posting but... I just cannot xD
>> >
>> > El vie, 04-07-2008
On Fri, Jul 04, 2008 at 02:00:34PM +0200, Javier Martín wrote:
> In the nearly eight years from ext2 release to the merge of ext3 into
> the kernel, some incompatible features were introduced in ext2 proper,
> like filetype and compression. Even now, with ext4 in development and
> merged into the k
On Fri, Jul 04, 2008 at 12:34:50PM +0200, Javier Martín wrote:
> > And, grub WILL follow the evolution the extN, because it's the primary
> > boot loader for linux. The only reason we don't have ext4 support at
> > present is because it's not stable. If major distro starts to use it
> > as default,
El vie, 04-07-2008 a las 19:29 +0800, Bean escribió:
> On Fri, Jul 4, 2008 at 6:34 PM, Javier Martín <[EMAIL PROTECTED]> wrote:
> > I know I promised not to keep posting but... I just cannot xD
> >
> > El vie, 04-07-2008 a las 14:49 +0800, Bean escribió:
> >> Hi,
> >>
> >> This is an example of goo
On Fri, Jul 4, 2008 at 6:34 PM, Javier Martín <[EMAIL PROTECTED]> wrote:
> I know I promised not to keep posting but... I just cannot xD
>
> El vie, 04-07-2008 a las 14:49 +0800, Bean escribió:
>> Hi,
>>
>> This is an example of good practice, which check the driver
>> by function, not by flags.
>
I know I promised not to keep posting but... I just cannot xD
El vie, 04-07-2008 a las 14:49 +0800, Bean escribió:
> Hi,
>
> This is an example of good practice, which check the driver
> by function, not by flags.
This will find and check core.img. As my previous post showed, one file
being rea
From: "Bean" <[EMAIL PROTECTED]>
Sent: Friday, July 04, 2008 8:49 AM
First of all, grub-setup is conservative enough. It read the data
twice, one using host os, one using grub, and compare result. If the
data is corrupted, the comparison will fail and it will refuse to
install.
I thought a fe
Hi,
First of all, grub-setup is conservative enough. It read the data
twice, one using host os, one using grub, and compare result. If the
data is corrupted, the comparison will fail and it will refuse to
install. This is an example of good practice, which check the driver
by function, not by fla
And, after writing all that, I forgot to append the patch. Sigh.
Index: fs/ext2.c
===
--- fs/ext2.c (revisión: 1687)
+++ fs/ext2.c (copia de trabajo)
@@ -50,6 +50,7 @@
#include
#include
#include
+#include
/* Log2 size of ext
El vie, 04-07-2008 a las 02:08 +0200, Robert Millan escribió:
> On Thu, Jul 03, 2008 at 07:07:55PM +0200, Javier Martín wrote:
> > > The question here is whether we should increase complexity with interfaces
> > > that don't provide any usefulness to the user, just to make it easier to
> > > do pot
On Thu, Jul 03, 2008 at 07:07:55PM +0200, Javier Martín wrote:
> > The question here is whether we should increase complexity with interfaces
> > that don't provide any usefulness to the user, just to make it easier to
> > do potentially dangerous things. If a user understands the implications
> >
El jue, 03-07-2008 a las 16:02 +0200, Robert Millan escribió:
> On Wed, Jul 02, 2008 at 09:32:40PM +0200, Javier Martín wrote:
> > El mié, 02-07-2008 a las 16:22 +0200, Robert Millan escribió:
> > > On Wed, Jul 02, 2008 at 01:28:47AM +0200, Javier Martín wrote:
> > > > > A --ignore-incompatible fla
Robert Millan wrote:
A more elegant solution (also may be interesting for security at some point)
would be for update-grub to hash each file it generates access commands for
and embed the sum in grub.cfg as a check parameter, like
if verify_hash /file x ; then
do_something_with_file /f
On Wed, Jul 02, 2008 at 09:32:40PM +0200, Javier Martín wrote:
> El mié, 02-07-2008 a las 16:22 +0200, Robert Millan escribió:
> > On Wed, Jul 02, 2008 at 01:28:47AM +0200, Javier Martín wrote:
> > > > A --ignore-incompatible flag doesn't sound like a nice thing to do; it
> > > > means
> > > > we
El mié, 02-07-2008 a las 16:22 +0200, Robert Millan escribió:
> On Wed, Jul 02, 2008 at 01:28:47AM +0200, Javier Martín wrote:
> > > A --ignore-incompatible flag doesn't sound like a nice thing to do; it
> > > means
> > > we're passing our own problem to the user instead of solving it.
> > We don
On Wed, 2008-07-02 at 16:22 +0200, Robert Millan wrote:
> I don't think this is necessary. First, let's take for granted that our code
> is in every situation smart enough not to crash when a filesystem isn't
> readable (this should always be the case, since we might occasionaly be asked
> to rea
On Wed, Jul 02, 2008 at 01:28:47AM +0200, Javier Martín wrote:
> > A --ignore-incompatible flag doesn't sound like a nice thing to do; it
> > means
> > we're passing our own problem to the user instead of solving it.
> We don't have any "problem" to pass to users: ext4 is not supported
We don't
El mar, 01-07-2008 a las 22:48 +0200, Robert Millan escribió:
> On Tue, Jul 01, 2008 at 08:42:39PM +0200, Javier Martín wrote:
> > partition as "unrecognized" and then I had to specifically request it to
> > be mounted as ext2 with a possible --ignore-incompatible flag,
>
> A --ignore-incompatible
El mar, 01-07-2008 a las 22:48 +0200, Robert Millan escribió:
> On Tue, Jul 01, 2008 at 08:42:39PM +0200, Javier Martín wrote:
> > partition as "unrecognized" and then I had to specifically request it to
> > be mounted as ext2 with a possible --ignore-incompatible flag,
>
> A --ignore-incompatible
On Tue, Jul 01, 2008 at 08:42:39PM +0200, Javier Martín wrote:
> partition as "unrecognized" and then I had to specifically request it to
> be mounted as ext2 with a possible --ignore-incompatible flag,
A --ignore-incompatible flag doesn't sound like a nice thing to do; it means
we're passing our
On Tue, 2008-07-01 at 20:42 +0200, Javier Martín wrote:
> Well, what can I say about this: INCOMPAT_* flags are so for a reason,
> and they are telling us "don't even try to read this filesystem if you
> don't implement this". It's true that _maybe_ the files we need don't
> have extents, or compr
El mar, 01-07-2008 a las 12:25 -0400, Pavel Roskin escribió:
> On Tue, 2008-07-01 at 18:08 +0200, Robert Millan wrote:
>
> > > We must not quit if the journal flag is set, even if we don't handle
> > > it. grub-setup runs in a active system, the journal wouldn't be empty.
> > > If we just quit, we
On Tue, 2008-07-01 at 18:08 +0200, Robert Millan wrote:
> > We must not quit if the journal flag is set, even if we don't handle
> > it. grub-setup runs in a active system, the journal wouldn't be empty.
> > If we just quit, we can't even install.
>
> I think we should be more conservative here,
On Mon, Jun 30, 2008 at 08:27:50PM +0800, Bean wrote:
> On Mon, Jun 30, 2008 at 8:12 PM, Javier Martín <[EMAIL PROTECTED]> wrote:
> > El lun, 30-06-2008 a las 07:14 -0400, Isaac Dupree escribió:
> >> > +#define EXT3_FEATURE_INCOMPAT_RECOVER 0x0004 /* Needs
> >> > recovery */
> >>
> >>
On Mon, Jun 30, 2008 at 05:02:50AM +0200, Javier Martín wrote:
>
> Here is the patch I was talking about, one step farther than I had first
> envisioned, i.e. not just about ext4 but an (solid?) implementation of
> "xenophobia" in the filesystem driver. This code checks the superblock
> backwards-
Hi there,
El lun, 30-06-2008 a las 20:27 +0800, Bean escribió:
> Hi,
>
> We must not quit if the journal flag is set, even if we don't handle
> it. grub-setup runs in a active system, the journal wouldn't be empty.
> If we just quit, we can't even install.
>
If you mean the "needs_recovery" fla
On Mon, Jun 30, 2008 at 8:12 PM, Javier Martín <[EMAIL PROTECTED]> wrote:
> El lun, 30-06-2008 a las 07:14 -0400, Isaac Dupree escribió:
>> > +#define EXT3_FEATURE_INCOMPAT_RECOVER 0x0004 /* Needs
>> > recovery */
>>
>> > +#define EXT2_DRIVER_SUPPORTED_INCOMPAT ( EXT2_FEATURE_INCOMPAT
El lun, 30-06-2008 a las 07:14 -0400, Isaac Dupree escribió:
> > +#define EXT3_FEATURE_INCOMPAT_RECOVER 0x0004 /* Needs
> > recovery */
>
> > +#define EXT2_DRIVER_SUPPORTED_INCOMPAT ( EXT2_FEATURE_INCOMPAT_FILETYPE )
>
> I suspect this will mean that journalled ext3 when the system
+#define EXT3_FEATURE_INCOMPAT_RECOVER 0x0004 /* Needs recovery */
+#define EXT2_DRIVER_SUPPORTED_INCOMPAT ( EXT2_FEATURE_INCOMPAT_FILETYPE )
I suspect this will mean that journalled ext3 when the system crashed
(so the filesystem "needs recovery" from the journal) won't load. (O
From: "JavierMartín" <[EMAIL PROTECTED]>
Sent: Monday, June 30, 2008 5:02 AM
Phew, that was all (I hope)
Cheers!
Habbit
Thank you for the patch. Just tried it out, it works fine
___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.or
El dom, 29-06-2008 a las 23:19 +0200, Robert Millan escribió:
> On Sun, Jun 29, 2008 at 09:53:50PM +0200, Javier Martín wrote:
> > Ext4 is as of today in development and unstable; in fact, the FS name in
> > Linux is "ext4dev", but I _think_ the on-disk format is already frozen
> > and thus a reado
On Sun, Jun 29, 2008 at 09:53:50PM +0200, Javier Martín wrote:
> Ext4 is as of today in development and unstable; in fact, the FS name in
> Linux is "ext4dev", but I _think_ the on-disk format is already frozen
> and thus a readonly driver can be written. I'm not saying that we should
> delay the i
El lun, 30-06-2008 a las 03:17 +0800, Bean escribió:
> Hi,
>
> I think it's not difficult to add extents support for grub2. Is the
> feature stable now, how many distro enable it by default ?
>
Ext4 is as of today in development and unstable; in fact, the FS name in
Linux is "ext4dev", but I _thi
On Mon, Jun 30, 2008 at 2:46 AM, Javier Martín <[EMAIL PROTECTED]> wrote:
> El dom, 29-06-2008 a las 20:11 +0200, Felix Zielcke escribió:
>> Hello,
>>
>> I reported this already on Debian as #488235
>>
>> grub-probe -t fs shows ext2 for a filesystem created with e2fsprogs 1.41WIP
>> from Debian exp
El dom, 29-06-2008 a las 20:11 +0200, Felix Zielcke escribió:
> Hello,
>
> I reported this already on Debian as #488235
>
> grub-probe -t fs shows ext2 for a filesystem created with e2fsprogs 1.41WIP
> from Debian experimental
> with extent and flex_bg
> I didn't get grub-probe working with the
Hello,
I reported this already on Debian as #488235
grub-probe -t fs shows ext2 for a filesystem created with e2fsprogs 1.41WIP
from Debian experimental
with extent and flex_bg
I didn't get grub-probe working with the loopback device even though I added
it to device.map it still complained.
T
68 matches
Mail list logo
