Re: errno handling

2009-11-23 Thread Robert Millan
On Sun, Nov 22, 2009 at 11:24:14PM +, Carles Pina i Estany wrote: > > discussed in irc with phcoder: no changes here because would be a caller > bug. Some day I will take a look on a possible callers that are not > resetting grub_errno after functions that are setting up (so can lead to > prob

Re: errno handling

2009-11-22 Thread Carles Pina i Estany
Hi, On Nov/22/2009, Carles Pina i Estany wrote: > > Hello, > > On Nov/22/2009, Robert Millan wrote: > > On Sun, Nov 22, 2009 at 05:19:19PM +, Carles Pina i Estany wrote: > > > > > > Hello, > > > > > > Last night I spent some time with a confussion that maybe it can be > > > avoided (or ma

Re: errno handling

2009-11-22 Thread Carles Pina i Estany
Hello, On Nov/22/2009, Robert Millan wrote: > On Sun, Nov 22, 2009 at 05:19:19PM +, Carles Pina i Estany wrote: > > > > Hello, > > > > Last night I spent some time with a confussion that maybe it can be > > avoided (or maybe not). > > > > Let's say that a module calls grub_file_open and it

Re: errno handling

2009-11-22 Thread Robert Millan
oes. Help is much welcome on cleaning this kind of problems up. But it needs to be done carefully; it's very easy to unadvertedly work around the problem instead of fixing it (this happened sometimes in the past when sorting out errno handling problems). -- Robert Millan The DRM opt-

errno handling

2009-11-22 Thread Carles Pina i Estany
Hello, Last night I spent some time with a confussion that maybe it can be avoided (or maybe not). Let's say that a module calls grub_file_open and it fails (file doesn't exist or whatever). grub_errno is setted up. This module is not resetting grub_errno and makes another call to grub_file_ope