Re: [PATCH v7] efi: new 'connectefi' command

2025-06-18 Thread Daniel Kiper
On Tue, Jun 10, 2025 at 11:54:25AM +0200, Renaud Métrich via Grub-devel wrote: > When network booting is used, trying to chainload to the local disk > (which is used in deployment tools such as Red Hat Satellite) may fail > when searching for the boot loader, e.g. /EFI/redhat/shimx64.efi: > the boo

Re: [PATCH v7] efi: new 'connectefi' command

2025-06-16 Thread Renaud Métrich via Grub-devel
Please see inline, thanks for reviewing. Le 6/10/25 à 7:36 PM, sudhakar a écrit : On 2025-06-10 15:24, Renaud Métrich via Grub-devel wrote: When network booting is used, trying to chainload to the local disk (which is used in deployment tools such as Red Hat Satellite) may fail when searching f

Re: [PATCH v7] efi: new 'connectefi' command

2025-06-10 Thread sudhakar
On 2025-06-10 15:24, Renaud Métrich via Grub-devel wrote: When network booting is used, trying to chainload to the local disk (which is used in deployment tools such as Red Hat Satellite) may fail when searching for the boot loader, e.g. /EFI/redhat/shimx64.efi: the boot loader file is listed, bu

[PATCH v7] efi: new 'connectefi' command

2025-06-10 Thread Renaud Métrich via Grub-devel
When network booting is used, trying to chainload to the local disk (which is used in deployment tools such as Red Hat Satellite) may fail when searching for the boot loader, e.g. /EFI/redhat/shimx64.efi: the boot loader file is listed, but not readable, because UEFI DISK I/O and/or SCSI DISK I/O d

Re: [PATCH v6 2/2] efi: new 'connectefi' command

2025-06-01 Thread Andrew Hamilton
Thank you for explaining. I would suggest adding some maximum number of iterations to prevent an infinite loop if perhaps the EFI is misbehaving inside the "loop:" section. Not sure the right limit, but there must be some maximum allowed assuming worst case conditions or maximum allow based on pr

Re: [PATCH v6 2/2] efi: new 'connectefi' command

2025-05-31 Thread Renaud Métrich via Grub-devel
Hi Daniel, Sorry I missed your email, please see inline. Le 3/21/25 à 3:51 PM, Daniel Kiper a écrit : On Wed, Mar 19, 2025 at 01:47:57PM +0100, Renaud Métrich via Grub-devel wrote: When network booting is used, trying to chainload to the local disk (which is used in deployment tools such as Re

Re: [PATCH v6 2/2] efi: new 'connectefi' command

2025-05-31 Thread Renaud Métrich via Grub-devel
Hi Andrew, Sorry I missed your email. IMHO the "goto" is useful here to be able to loop again at same "s" level: we actually want to redo the operation without going one step further. Let me explain with an example. We want to connect PCIROOT, then PCI level, then SCSI I/O level. There is

Re: [PATCH v6 2/2] efi: new 'connectefi' command

2025-03-21 Thread Daniel Kiper
On Wed, Mar 19, 2025 at 01:47:57PM +0100, Renaud Métrich via Grub-devel wrote: > When network booting is used, trying to chainload to the local disk > (which is used in deployment tools such as Red Hat Satellite) may fail > when searching for the boot loader, e.g. /EFI/redhat/shimx64.efi: > the boo

Re: [PATCH v6 2/2] efi: new 'connectefi' command

2025-03-19 Thread Andrew Hamilton
Hello, I just had one question about the use of the 'goto' and the 'loop' label in the below code... see my question below the 'loop' label. Let me know if I just misunderstand or am wrong. Thank you! Andrew On Wed, Mar 19, 2025 at 7:53 AM Renaud Métrich via Grub-devel wrote: > > When network b

[PATCH v6 2/2] efi: new 'connectefi' command

2025-03-19 Thread Renaud Métrich via Grub-devel
When network booting is used, trying to chainload to the local disk (which is used in deployment tools such as Red Hat Satellite) may fail when searching for the boot loader, e.g. /EFI/redhat/shimx64.efi: the boot loader file is listed, but not readable, because UEFI DISK I/O and/or SCSI DISK I/O d

Re: [PATCH v5 2/2] efi: new 'connectefi' command

2024-07-16 Thread Renaud Métrich
It could indeed be done automatically, but not always, because by default it's not needed and also because connecting EFI devices can be long apparently. So I fear that as soon as a "search" would fail, triggering the connection internally will slow down the boot, even though the search was s

Re: [PATCH v5 2/2] efi: new 'connectefi' command

2024-06-28 Thread Vladimir 'phcoder' Serbinenko
The need to connect looks like an internal implementation detail. Can we treat it as such and connect when needed automatically rather than having an extra configuration knob? On Fri, Jun 28, 2024 at 2:14 PM Renaud Métrich wrote: > > When efi.quickboot is enabled on VMWare (which is the default f

[PATCH v5 2/2] efi: new 'connectefi' command

2024-06-28 Thread Renaud Métrich
When efi.quickboot is enabled on VMWare (which is the default for hardware release 16 and later), it may happen that not all EFI devices are connected. Due to this, browsing the devices in make_devices() just fails to find devices, in particular disks or partitions for a given disk. This typically

Re: efi: new 'connectefi' command

2022-09-01 Thread Renaud Métrich
Hi Glenn, Thanks for reviewing this. I reworked the feature based on your comments: - used grub_list - renamed into "eficonnect" - added "all" option See "[PATCH v4 1/2] lsefi: fixed memory leaks (unchanged)" and "[PATCH v4 2/2] efi: new 'eficonnect' command" Renaud. Le 8/28/22 à 21:51, G

Re: [PATCH v3 2/2] efi: new 'connectefi' command

2022-08-28 Thread Glenn Washburn
On Tue, 15 Feb 2022 14:05:22 +0100 Renaud Métrich wrote: > When efi.quickboot is enabled on VMWare (which is the default for > hardware release 16 and later), it may happen that not all EFI devices > are connected. Due to this, browsing the devices in make_devices() just > fails to find devices,

Re: efi: new 'connectefi' command

2022-08-28 Thread Glenn Washburn
On Tue, 15 Feb 2022 14:05:20 +0100 Renaud Métrich wrote: > This set of patches fixes a memory leak in 'lsefi' command and > introduces a new 'connectefi pciroot|scsi' command which recursively > connects the corresponding EFI handles. I think both of these patches would be great to get in before

Re: [PATCH v2 1/2] efi: new 'connectefi' command

2022-02-15 Thread Renaud Métrich
Please ignore, deprecated by "efi: new 'connectefi' command" (v3). Sorry for the mess. Le 2/14/22 à 14:23, Renaud Métrich a écrit : When efi.quickboot is enabled on VMWare (which is the default for hardware release 16 and later), it may happen that not all EFI devices a

[PATCH v3 2/2] efi: new 'connectefi' command

2022-02-15 Thread Renaud Métrich
When efi.quickboot is enabled on VMWare (which is the default for hardware release 16 and later), it may happen that not all EFI devices are connected. Due to this, browsing the devices in make_devices() just fails to find devices, in particular disks or partitions for a given disk. This typically

efi: new 'connectefi' command

2022-02-15 Thread Renaud Métrich
This set of patches fixes a memory leak in 'lsefi' command and introduces a new 'connectefi pciroot|scsi' command which recursively connects the corresponding EFI handles. This is required on VMWare with efi.quickBoot enabled when chainloading to grub on the harddisk from a network boot, otherwise

[PATCH v2 1/2] efi: new 'connectefi' command

2022-02-14 Thread Renaud Métrich
When efi.quickboot is enabled on VMWare (which is the default for hardware release 16 and later), it may happen that not all EFI devices are connected. Due to this, browsing the devices in make_devices() just fails to find devices, in particular disks or partitions for a given disk. This typically