Re: default menuentry matching similar entries is broken

2012-03-03 Thread Andreas Vogel
>> BTW, one of the features which are missing and about what i read in >> different forums is that it's not possible to reference entries in the >> menu tree by number, e.g. "0>2>4>2". > > This should work but isn't recommended if it doesn't please supply a > testcase or a fix. > > Just to let

Re: default menuentry matching similar entries is broken

2012-03-03 Thread Vladimir 'φ-coder/phcoder' Serbinenko
BTW, one of the features which are missing and about what i read in different forums is that it's not possible to reference entries in the menu tree by number, e.g. "0>2>4>2". This should work but isn't recommended if it doesn't please supply a testcase or a fix. -- Regards Vladimir 'φ-

Re: default menuentry matching similar entries is broken

2012-03-03 Thread Andreas Vogel
Am 03.03.2012 19:20, schrieb Vladimir 'φ-coder/phcoder' Serbinenko: > On 03.03.2012 19:10, Andreas Vogel wrote: >>> Hi, >>> >>>This code in menu.c::menuentry_eq() looks wrong: >>> >>> { >>>const char *ptr1, *ptr2; >>>ptr1 = title; >>>ptr2 = spec; >>>while (1) >>> { >>>

Re: default menuentry matching similar entries is broken

2012-03-03 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 03.03.2012 19:10, Andreas Vogel wrote: Hi, This code in menu.c::menuentry_eq() looks wrong: { const char *ptr1, *ptr2; ptr1 = title; ptr2 = spec; while (1) { if (*ptr2 == '>'&& ptr2[1] != '>'&& *ptr1 == 0) return 1; if (*ptr2 == '>'&& ptr2[1] !=

Re: default menuentry matching similar entries is broken

2012-03-03 Thread Andreas Vogel
> Hi, > > This code in menu.c::menuentry_eq() looks wrong: > > { > const char *ptr1, *ptr2; > ptr1 = title; > ptr2 = spec; > while (1) > { > if (*ptr2 == '>' && ptr2[1] != '>' && *ptr1 == 0) > return 1; > if (*ptr2 == '>' && ptr2[1] != '>') > return 0; >

Re: default menuentry matching similar entries is broken

2012-03-03 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 03.03.2012 15:02, Seth Goldberg wrote: Sigh. I thought I tracked it down to this code, but it was late. I'll double-check. The buggy behavior is as I described -- this just may not be the actual root cause. BTW, with the code below, does this mean that having '>' characters in the title

Re: default menuentry matching similar entries is broken

2012-03-03 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 03.03.2012 08:33, Seth Goldberg wrote: Hi, This code in menu.c::menuentry_eq() looks wrong: { const char *ptr1, *ptr2; ptr1 = title; ptr2 = spec; while (1) { if (*ptr2 == '>'&& ptr2[1] != '>'&& *ptr1 == 0) return 1; if (*ptr2 == '>'&& ptr2[1] !=

default menuentry matching similar entries is broken

2012-03-02 Thread Seth Goldberg
Hi, This code in menu.c::menuentry_eq() looks wrong: { const char *ptr1, *ptr2; ptr1 = title; ptr2 = spec; while (1) { if (*ptr2 == '>' && ptr2[1] != '>' && *ptr1 == 0) return 1; if (*ptr2 == '>' && ptr2[1] != '>') return 0; if (*ptr2 == '>')