Re: chmod of generated grub.cfg

2009-09-10 Thread Felix Zielcke
Am Donnerstag, den 10.09.2009, 20:56 +0200 schrieb Robert Millan: > On Tue, Sep 08, 2009 at 04:51:41PM +0200, Felix Zielcke wrote: > > Am Dienstag, den 08.09.2009, 16:48 +0200 schrieb Robert Millan: > > > On Sun, Sep 06, 2009 at 07:22:36PM +0200, Vladimir 'phcoder' Serbinenko > > > wrote: > > > >

Re: chmod of generated grub.cfg

2009-09-10 Thread Robert Millan
On Tue, Sep 08, 2009 at 04:51:41PM +0200, Felix Zielcke wrote: > Am Dienstag, den 08.09.2009, 16:48 +0200 schrieb Robert Millan: > > On Sun, Sep 06, 2009 at 07:22:36PM +0200, Vladimir 'phcoder' Serbinenko > > wrote: > > > On Sun, Sep 6, 2009 at 3:38 PM, Colin Watson wrote: > > > > On Sun, Sep 06,

Re: chmod of generated grub.cfg

2009-09-08 Thread Felix Zielcke
Am Dienstag, den 08.09.2009, 16:48 +0200 schrieb Robert Millan: > On Sun, Sep 06, 2009 at 07:22:36PM +0200, Vladimir 'phcoder' Serbinenko wrote: > > On Sun, Sep 6, 2009 at 3:38 PM, Colin Watson wrote: > > > On Sun, Sep 06, 2009 at 02:29:03PM +0200, Felix Zielcke wrote: > > >> Currently grub-mkconfi

Re: chmod of generated grub.cfg

2009-09-08 Thread Robert Millan
On Sun, Sep 06, 2009 at 07:22:36PM +0200, Vladimir 'phcoder' Serbinenko wrote: > On Sun, Sep 6, 2009 at 3:38 PM, Colin Watson wrote: > > On Sun, Sep 06, 2009 at 02:29:03PM +0200, Felix Zielcke wrote: > >> Currently grub-mkconfig uses chmod 444 on the newly generated grub.cfg > >> Wouldn't it be bet

Re: chmod of generated grub.cfg

2009-09-07 Thread Felix Zielcke
Am Sonntag, den 06.09.2009, 20:21 -0500 schrieb richardvo...@gmail.com: > On Sun, Sep 6, 2009 at 12:22 PM, Vladimir 'phcoder' > Serbinenko wrote: > > On Sun, Sep 6, 2009 at 3:38 PM, Colin Watson wrote: > >> On Sun, Sep 06, 2009 at 02:29:03PM +0200, Felix Zielcke wrote: > >>> Currently grub-mkconfig

Re: chmod of generated grub.cfg

2009-09-06 Thread richardvo...@gmail.com
On Sun, Sep 6, 2009 at 12:22 PM, Vladimir 'phcoder' Serbinenko wrote: > On Sun, Sep 6, 2009 at 3:38 PM, Colin Watson wrote: >> On Sun, Sep 06, 2009 at 02:29:03PM +0200, Felix Zielcke wrote: >>> Currently grub-mkconfig uses chmod 444 on the newly generated grub.cfg >>> Wouldn't it be better to use 4

Re: chmod of generated grub.cfg

2009-09-06 Thread Robert Millan
On Sun, Sep 06, 2009 at 05:17:34PM +0200, Felix Zielcke wrote: > Am Sonntag, den 06.09.2009, 17:09 +0200 schrieb Robert Millan: > > On Sun, Sep 06, 2009 at 04:58:40PM +0200, Felix Zielcke wrote: > > > > > > Ok here's now a patch. > > > Robert do you think this can go into 1.97? > > > > For 1.97 I

Re: chmod of generated grub.cfg

2009-09-06 Thread Vladimir 'phcoder' Serbinenko
On Sun, Sep 6, 2009 at 3:38 PM, Colin Watson wrote: > On Sun, Sep 06, 2009 at 02:29:03PM +0200, Felix Zielcke wrote: >> Currently grub-mkconfig uses chmod 444 on the newly generated grub.cfg >> Wouldn't it be better to use 400 now that we have plaintext password >> support? >> Or should we add supp

Re: chmod of generated grub.cfg

2009-09-06 Thread Felix Zielcke
Am Sonntag, den 06.09.2009, 17:09 +0200 schrieb Robert Millan: > On Sun, Sep 06, 2009 at 04:58:40PM +0200, Felix Zielcke wrote: > > > > Ok here's now a patch. > > Robert do you think this can go into 1.97? > > For 1.97 I'd be more comfortable with a simple s/444/400/. An automated check > smells

Re: chmod of generated grub.cfg

2009-09-06 Thread Robert Millan
On Sun, Sep 06, 2009 at 04:58:40PM +0200, Felix Zielcke wrote: > > Ok here's now a patch. > Robert do you think this can go into 1.97? For 1.97 I'd be more comfortable with a simple s/444/400/. An automated check smells like it could have corner cases. In fact I found one: > @@ -260,6 +260,11

Re: chmod of generated grub.cfg

2009-09-06 Thread Robert Millan
On Sun, Sep 06, 2009 at 02:38:18PM +0100, Colin Watson wrote: > > A GRUB_CHMOD > variable seems overkill, though. Yes. Please not a new config option just for this. Just pick a reasonable mode and set to it. Auto-detection doesn't sound bad, although I'd be fine with just using 0400. > > Else

Re: chmod of generated grub.cfg

2009-09-06 Thread Felix Zielcke
Am Sonntag, den 06.09.2009, 14:57 +0100 schrieb Colin Watson: > On Sun, Sep 06, 2009 at 03:43:46PM +0200, Felix Zielcke wrote: > > Am Sonntag, den 06.09.2009, 14:38 +0100 schrieb Colin Watson: > > > I think it'd be more sensible to do this in grub-mkconfig itself - it > > > doesn't really fit well

Re: chmod of generated grub.cfg

2009-09-06 Thread Colin Watson
On Sun, Sep 06, 2009 at 03:43:46PM +0200, Felix Zielcke wrote: > Am Sonntag, den 06.09.2009, 14:38 +0100 schrieb Colin Watson: > > I think it'd be more sensible to do this in grub-mkconfig itself - it > > doesn't really fit well into the /etc/grub.d/ hook system, which is > > really just for genera

Re: chmod of generated grub.cfg

2009-09-06 Thread Felix Zielcke
Am Sonntag, den 06.09.2009, 14:38 +0100 schrieb Colin Watson: > On Sun, Sep 06, 2009 at 02:29:03PM +0200, Felix Zielcke wrote: > > Currently grub-mkconfig uses chmod 444 on the newly generated grub.cfg > > Wouldn't it be better to use 400 now that we have plaintext password > > support? > > Or shou

Re: chmod of generated grub.cfg

2009-09-06 Thread Colin Watson
On Sun, Sep 06, 2009 at 02:29:03PM +0200, Felix Zielcke wrote: > Currently grub-mkconfig uses chmod 444 on the newly generated grub.cfg > Wouldn't it be better to use 400 now that we have plaintext password > support? > Or should we add support for a GRUB_CHMOD variable so users can override > this

chmod of generated grub.cfg

2009-09-06 Thread Felix Zielcke
Currently grub-mkconfig uses chmod 444 on the newly generated grub.cfg Wouldn't it be better to use 400 now that we have plaintext password support? Or should we add support for a GRUB_CHMOD variable so users can override this setting as they please? Else I'd need to add a /etc/grub.d/999_chmod fi