Re: ZFS boot environment patch

2017-09-15 Thread Konrad Rzeszutek Wilk
On Fri, Sep 15, 2017 at 12:57:39AM +0100, Colin Watson wrote: > On Thu, Sep 14, 2017 at 09:22:01PM +0200, Paul Lagerweij wrote: > > On Wed, 13 Sep 2017 at 09:17:42PM +0100, Colin Watson wrote: > > > > On Wed, Sep 13, 2017 at 11:02:48AM -0400, Konrad Rzeszutek Wilk wrote: > > > > > @@ -62,9 +63,15 @

Re: ZFS boot environment patch

2017-09-15 Thread Vladimir 'phcoder' Serbinenko
On Fri, Sep 15, 2017, 01:58 Colin Watson wrote: > On Thu, Sep 14, 2017 at 09:22:01PM +0200, Paul Lagerweij wrote: > > On Wed, 13 Sep 2017 at 09:17:42PM +0100, Colin Watson wrote: > > > > On Wed, Sep 13, 2017 at 11:02:48AM -0400, Konrad Rzeszutek Wilk > wrote: > > > > > @@ -62,9 +63,15 @@ case x"$

Re: ZFS boot environment patch

2017-09-15 Thread Paul Lagerweij
On Fri, 15 Sep 2017 at 00:57:39AM +0100, Colin Watson wrote: > A reasonable solution to this kind of thing is to set > PATH="$PATH:/sbin:/usr/sbin" to ensure that utilities there are > available. I edited the patch and tested it. Now everywhere where I use the zpool or zfs commands I temporarily e

Re: ZFS boot environment patch

2017-09-14 Thread Colin Watson
On Thu, Sep 14, 2017 at 09:22:01PM +0200, Paul Lagerweij wrote: > On Wed, 13 Sep 2017 at 09:17:42PM +0100, Colin Watson wrote: > > > On Wed, Sep 13, 2017 at 11:02:48AM -0400, Konrad Rzeszutek Wilk wrote: > > > > @@ -62,9 +63,15 @@ case x"$GRUB_FS" in > > > > + zfs_active_bootfs="`zpool list -H -o

Re: ZFS boot environment patch

2017-09-14 Thread Paul Lagerweij
Thanks for answering. On Wed, Sep 13, 2017 at 11:02:48AM -0400, Konrad Rzeszutek Wilk wrote: > You seem to be missing an Signed off? Signed-off-by: Paul Lagerweij I'm quite new with submitting code like this. I asked questions about where to start at Ubuntu and they sent me here. > And perhaps

Re: ZFS boot environment patch

2017-09-13 Thread Colin Watson
On Wed, Sep 13, 2017 at 11:02:48AM -0400, Konrad Rzeszutek Wilk wrote: > On Fri, Sep 01, 2017 at 01:31:28PM +0200, Paul Lagerweij wrote: > > +zfs_be="0" > > Why not just > > zfs_be= > > And then you can just check for zfs_be having an value instead of for 1 or 0? > > Or alternatively, > > zfs_

Re: ZFS boot environment patch

2017-09-13 Thread Konrad Rzeszutek Wilk
On Fri, Sep 01, 2017 at 01:31:28PM +0200, Paul Lagerweij wrote: > Hello, > > I've created a patch for util/grub.d/10_linux.in for dynamic ZFS boot > environment entries. I've only tested the patch in Ubuntu 16.04.2 with GRUB > 2.02~beta2, ZFS on Linux 0.6.5.6, Linux 4.4.0-83 and 4.4.0-81, but the

ZFS boot environment patch

2017-09-01 Thread Paul Lagerweij
Hello, I've created a patch for util/grub.d/10_linux.in for dynamic ZFS boot environment entries. I've only tested the patch in Ubuntu 16.04.2 with GRUB 2.02~beta2, ZFS on Linux 0.6.5.6, Linux 4.4.0-83 and 4.4.0-81, but the patch should work with any root ZFS configuration, because it only changes