Re: Warnings in kern/dl.c

2008-07-18 Thread Pavel Roskin
On Fri, 2008-07-18 at 23:35 +0800, Bean wrote: > Actually, GRUB_CPU_SIZEOF_VOID_P is the right one to use. It would > only cause problem in grub-mkimage, but kern/dl.c is not used by > grub-mkimage. Committed. -- Regards, Pavel Roskin ___ Grub-devel

Re: Warnings in kern/dl.c

2008-07-18 Thread Bean
On Fri, Jul 18, 2008 at 11:20 PM, Pavel Roskin <[EMAIL PROTECTED]> wrote: > On Fri, 2008-07-18 at 17:14 +0300, [EMAIL PROTECTED] wrote: > >> I think that using grub-emu might be a good idea for testing. I think >> there should be grub-emu architecture that could be compiled and in >> example there

Re: Warnings in kern/dl.c

2008-07-18 Thread Pavel Roskin
On Fri, 2008-07-18 at 17:14 +0300, [EMAIL PROTECTED] wrote: > I think that using grub-emu might be a good idea for testing. I think > there should be grub-emu architecture that could be compiled and in > example there would be grub-emu specific disk layer, input layer and > so on. So we could use

Re: Warnings in kern/dl.c

2008-07-18 Thread chaac
Pavel Roskin [EMAIL PROTECTED] kirjoitti: The warnings could be suppressed somehow, but I don't think it's the right thing to do. 64-bit grub-emu cannot load 32-bit modules (and vice versa). 64-bit grub-emu could load 64-bit modules in principle, although we don't compile them. We could

Re: Warnings in kern/dl.c

2008-07-18 Thread Bean
Hi, Oh, it seems kern/dl.c is not used by grub-mkimage, so it should be ok to revert back to GRUB_CPU_SIZEOF_VOID_P. -- Bean ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: Warnings in kern/dl.c

2008-07-18 Thread Bean
Hi, I have another thought about this issue, it's actually caused by different working environment for the same file. For kern/dl.c, there are three modes: 1. Target mode When it's used in boot environment, it's in target mode, for example, i386. 2. Host mode When it's used in tools like grub-em

Re: Warnings in kern/dl.c

2008-07-17 Thread Bean
On Fri, Jul 18, 2008 at 2:18 PM, Bean <[EMAIL PROTECTED]> wrote: > On Fri, Jul 18, 2008 at 1:38 PM, Pavel Roskin <[EMAIL PROTECTED]> wrote: >> Hello, Bean! >> >> I think this change from the x86_64 EFI patch should be reverted: >> >>* kern/dl.c (GRUB_CPU_SIZEOF_VOID_P): Changed to >>

Re: Warnings in kern/dl.c

2008-07-17 Thread Bean
On Fri, Jul 18, 2008 at 1:38 PM, Pavel Roskin <[EMAIL PROTECTED]> wrote: > Hello, Bean! > > I think this change from the x86_64 EFI patch should be reverted: > >* kern/dl.c (GRUB_CPU_SIZEOF_VOID_P): Changed to > GRUB_TARGET_SIZEOF_VOID_P. > > It causes warnings when compiling grub-e

Warnings in kern/dl.c

2008-07-17 Thread Pavel Roskin
Hello, Bean! I think this change from the x86_64 EFI patch should be reverted: * kern/dl.c (GRUB_CPU_SIZEOF_VOID_P): Changed to GRUB_TARGET_SIZEOF_VOID_P. It causes warnings when compiling grub-emu on x64_64 for i386: kern/dl.c: In function 'grub_dl_resolve_symbols': kern/dl.c