Re: Unreachable code in mkimagexx (Fwd: New Defects reported by Coverity Scan for GRUB)

2017-01-23 Thread Vladimir 'phcoder' Serbinenko
They're used only for arm (32-bit). So they don't need to work for 64-bit. On Mon, 14 Mar 2016, 10:01 Andrei Borzenkov wrote: > On Sun, Mar 13, 2016 at 10:38 AM, Andrei Borzenkov > wrote: > > > > We probably need to #ifdef this section for MKIMAGE_ELF64 case only, it > > makes no sense to compi

Re: Unreachable code in mkimagexx (Fwd: New Defects reported by Coverity Scan for GRUB)

2016-03-14 Thread Andrei Borzenkov
On Sun, Mar 13, 2016 at 10:38 AM, Andrei Borzenkov wrote: > > We probably need to #ifdef this section for MKIMAGE_ELF64 case only, it > makes no sense to compile it for 32 bit target. > Hmm ... why translate_relocation_pe, translate_relocation_raw and classify_raw_reloc are not target size specif

Unreachable code in mkimagexx (Fwd: New Defects reported by Coverity Scan for GRUB)

2016-03-12 Thread Andrei Borzenkov
We probably need to #ifdef this section for MKIMAGE_ELF64 case only, it makes no sense to compile it for 32 bit target. *** CID 158599:(DEADCODE) /util/grub-mkimagexx.c: 1317 in translate_