Re: [PATCH v2 0/7] Add xHCI USB support

2021-02-26 Thread Glenn Washburn
Good day Patrick, On Wed, 24 Feb 2021 07:46:48 +0100 Patrick Rudolph wrote: > Hi Glenn, > yes it's the same patch series, but has been cleaned and improved a > lot. I've addressed most of the comments received earlier. I see that I implied that you hadn't and I didn't mean to. I only meant to s

Re: [PATCH v2 0/7] Add xHCI USB support

2021-02-23 Thread Patrick Rudolph
Hi Glenn, yes it's the same patch series, but has been cleaned and improved a lot. I've addressed most of the comments received earlier. As stated in the commit message, USB 3.1 and USB 3.2 are not tested, as I lack hardware to test this. I'm not going to look into this any further into this as it

Re: [PATCH v2 0/7] Add xHCI USB support

2021-02-19 Thread Glenn Washburn
Hi Patrick, Thanks for the contribution. I think this would be a great addition to GRUB. However, there are a few issues I see at the moment. On Mon, 7 Dec 2020 08:41:20 +0100 Patrick Rudolph wrote: > Add basic support for xHCI USB controllers and non root xHCI hubs. > The motivation is to use

[PATCH v2 0/7] Add xHCI USB support

2020-12-06 Thread Patrick Rudolph
Add basic support for xHCI USB controllers and non root xHCI hubs. The motivation is to use this code on platforms that do not provide user input by runtime services (like BIOS or UEFI platform) do. This is the case when GRUB is used as coreboot payload for example. The code is based on seabios im

[PATCH 0/6] Add xHCI USB support

2020-12-02 Thread Patrick Rudolph
Add basic support for xHCI USB controllers. The code is based on seabios implementation, but has been heavily modified to match grubs internals. Changes done in version 2: * Code cleanup * Code style fixes * Don't leak memory buffers * Compile without warnings * Add more defines * Add more h

Re: USB support merge (Re: [PATCH] (ata.mod) Fix ATAPI protocol)

2009-02-16 Thread Marco Gerards
r problems, but this is > much better than leaving it to bitrot. Then we can work on fixing them more > easily. Thanks, I am happy it is merged now. It would help if people reported success/failure with USB support. > Let's enumerate them again: > > - OHCI works on qemu

USB support merge (Re: [PATCH] (ata.mod) Fix ATAPI protocol)

2009-02-08 Thread Robert Millan
On Mon, Jan 19, 2009 at 11:15:41AM +0100, Marco Gerards wrote: > Perhaps my USB code might help in some occasions > for scsi.c, I am not completely sure if they are in sync. I sent in > the USB code earlier. This code can be committed, although endianess > is not handled correctly at all places.

Re: USB support

2008-11-04 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Tue, Nov 04, 2008 at 04:21:39PM +0100, Felix Zielcke wrote: >> Am Dienstag, den 04.11.2008, 06:17 -0800 schrieb Viswesh S: >> > Hi, >> > >> > Is the USB support for grub2 completed or still in progr

Re: USB support

2008-11-04 Thread Robert Millan
On Tue, Nov 04, 2008 at 04:21:39PM +0100, Felix Zielcke wrote: > Am Dienstag, den 04.11.2008, 06:17 -0800 schrieb Viswesh S: > > Hi, > > > > Is the USB support for grub2 completed or still in progress ? > > > > Is it possible to know,if incomplete, till what l

Re: USB support

2008-11-04 Thread Felix Zielcke
Am Dienstag, den 04.11.2008, 06:17 -0800 schrieb Viswesh S: > Hi, > > Is the USB support for grub2 completed or still in progress ? > > Is it possible to know,if incomplete, till what level we have reached ? Hello, Only UHCI controllers are supported, OHCI not. UHCI is mostly us

USB support

2008-11-04 Thread Viswesh S
Hi, Is the USB support for grub2 completed or still in progress ? Is it possible to know,if incomplete, till what level we have reached ? Thanks, Viswesh Add more friends to your messenger and enjoy! Go to http://messenger.yahoo.com/invite

Re: [RFC] USB Support

2008-08-31 Thread Colin D Bennett
On Sun, 31 Aug 2008 18:13:56 +0200 Felix Zielcke <[EMAIL PROTECTED]> wrote: > Thanks for the copy&paste and even the link to it. > I still find it weird and I even wasn't able yet to produce them in > Emacs. > Control-L is the wrong key combination for it ;) Try C-q C-L. Cheers, Colin

Re: [RFC] USB Support

2008-08-31 Thread Felix Zielcke
Am Sonntag, den 31.08.2008, 08:59 -0700 schrieb Colin D Bennett: Hello Colin, > > > > Weird ` ' character which seems not to make sense. > > Actually that is a form feed character, which the GNU coding standard > recommends to be used to break up source code at logical places: Yep Marco alread

Re: [RFC] USB Support

2008-08-31 Thread Colin D Bennett
On Thu, 28 Aug 2008 12:16:59 +0200 Felix Zielcke <[EMAIL PROTECTED]> wrote: > + grub_usb_iterate (usb_iterate); > +} > + > + > > Weird ` ' character which seems not to make sense. Actually that is a form feed character, which the GNU coding standard recommends to be used to break up source cod

Re: [RFC] USB Support

2008-08-30 Thread Robert Millan
On Wed, Aug 27, 2008 at 09:56:22PM +0200, Marco Gerards wrote: > Index: disk/usbms.c > === > --- disk/usbms.c (revision 0) > +++ disk/usbms.c (revision 0) I think 'usbms' is a cryptic name. I'd personally prefer something m

Re: [RFC] USB Support

2008-08-28 Thread Felix Zielcke
Am Mittwoch, den 27.08.2008, 21:56 +0200 schrieb Marco Gerards: > Hi, Hello Marco, not that big as you might have expected, but maybe not that bad start. I try to get more used to this :) > - Broken OHCI support, it works in QEMu but I haven't tested on real > hardware. Please do not review

Re: USB Support

2008-08-18 Thread Vesa Jääskeläinen
y.volta wrote: > Hi, > >Great work! > >BTW. Did you know there is an existing Grub2 USB project from coreboot? Yes, and Marco is aware of it. ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: USB Support

2008-08-17 Thread y.volta
Hi, Great work! BTW. Did you know there is an existing Grub2 USB project from coreboot? y.volta Lately I have been working on USB support for GRUB 2. It's not completely ready yet. The code was only tested on QEMu and supports UHCI, OHCI, USB Mass Storage and HID. Most like

USB Support

2008-08-17 Thread Marco Gerards
Hi, Lately I have been working on USB support for GRUB 2. It's not completely ready yet. The code was only tested on QEMu and supports UHCI, OHCI, USB Mass Storage and HID. Most likely it will not immediately work on real hardware. But please test and report if you want to be sure ;-)