Re: gzio is broken (fix)

2005-10-19 Thread Yoshinori K. Okuji
On Sunday 16 October 2005 11:24 am, Timothy Baldwin wrote: > The patch fixes it: Thank you. I have checked it in right now. > Did you apply my test patch and use a test file with an uncompressed size > larger than 32KiB? Probably it was too small. Okuji ___

Re: gzio is broken (fix)

2005-10-16 Thread Timothy Baldwin
On Saturday 15 Oct 2005 18:34, Yoshinori K. Okuji wrote: > On Saturday 15 October 2005 10:07 am, Yoshinori K. Okuji wrote: > > > Problem 2: Reading gzip files all at once results in corruption of the > > > data. It can be exposed by this patch: > > > > Can you investigate this problem? The patch f

Re: gzio is broken

2005-10-15 Thread Timothy Baldwin
On Saturday 15 Oct 2005 21:53, Marco Gerards wrote: > Timothy Baldwin <[EMAIL PROTECTED]> writes: > > On Saturday 15 Oct 2005 18:34, Yoshinori K. Okuji wrote: > >> On Saturday 15 October 2005 10:07 am, Yoshinori K. Okuji wrote: > >> > > Problem 2: Reading gzip files all at once results in corruptio

Re: gzio is broken

2005-10-15 Thread Marco Gerards
Timothy Baldwin <[EMAIL PROTECTED]> writes: > On Saturday 15 Oct 2005 18:34, Yoshinori K. Okuji wrote: >> On Saturday 15 October 2005 10:07 am, Yoshinori K. Okuji wrote: >> > > Problem 2: Reading gzip files all at once results in corruption of the >> > > data. It can be exposed by this patch: >> >

Re: gzio is broken

2005-10-15 Thread Timothy Baldwin
On Saturday 15 Oct 2005 18:34, Yoshinori K. Okuji wrote: > On Saturday 15 October 2005 10:07 am, Yoshinori K. Okuji wrote: > > > Problem 2: Reading gzip files all at once results in corruption of the > > > data. It can be exposed by this patch: > > > > Can you investigate this problem? > > I don't

Re: gzio is broken

2005-10-15 Thread Yoshinori K. Okuji
On Saturday 15 October 2005 10:07 am, Yoshinori K. Okuji wrote: > > Problem 2: Reading gzip files all at once results in corruption of the > > data. It can be exposed by this patch: > > Can you investigate this problem? I don't see any problem on my laptop (i386). So this might be specific to ARM.

Re: gzio is broken

2005-10-15 Thread Yoshinori K. Okuji
On Saturday 15 October 2005 02:47 am, Timothy Baldwin wrote: > Problem 1: In the function test_header, the array buf is accessed via > pointers to grub_uint32_t and grub_uint16_t without ensuring correct > alignment of the pointers. This does not work on ARM. Fixed by: Thank you for your report.