Re: Update for NTFS file system driver

2007-06-13 Thread Marco Gerards
Bean <[EMAIL PROTECTED]> writes: [...] > Another thing I notice, the blocklist command generate messy result when > compared to GRUB Legacy, is it supposed to be so ? What do you mean? Can you give an example? > BTW, is it possible for me to join the GRUB2 development term ? I really > want to

Re: Update for NTFS file system driver

2007-06-10 Thread Bean
On Sun, Jun 10, 2007 at 05:15:53PM +0200, Robert Millan wrote: > > I noticed that your patch isn't adding ntfs to the utils (grub-probe, etc). > > I'm attaching a fix for that. ChangeLog entries: > > * conf/powerpc-ieee1275.rmk: Add fs/ntfs.c to grub-probe and grub-emu. > > * conf/

Re: Update for NTFS file system driver

2007-06-10 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > I noticed that your patch isn't adding ntfs to the utils (grub-probe, etc). > > I'm attaching a fix for that. ChangeLog entries: > > * conf/powerpc-ieee1275.rmk: Add fs/ntfs.c to grub-probe and grub-emu. > > * conf/i386-efi.rmk: Likewise. Al

Re: Update for NTFS file system driver

2007-06-10 Thread Robert Millan
I noticed that your patch isn't adding ntfs to the utils (grub-probe, etc). I'm attaching a fix for that. ChangeLog entries: * conf/powerpc-ieee1275.rmk: Add fs/ntfs.c to grub-probe and grub-emu. * conf/i386-efi.rmk: Likewise. Also remove unused grub-setup definition.

Re: Update for NTFS file system driver

2007-06-10 Thread Bean
Ok, I reformat the patch, hopefully it will conform to standard. -- Bean <[EMAIL PROTECTED]> 2007-06-10 Bean <[EMAIL PROTECTED]> * conf/common.rmk (pkgdata_MODULES): Add ntfs.mod. * fs/ntfs.c: New file. * kern/misc.c (grub_utf16_to_utf8): Fix unicode conversi

Re: history of fsys_ntfs.c (Re: Update for NTFS file system driver)

2007-06-10 Thread Bean
On Sun, Jun 10, 2007 at 12:18:47PM +0200, Robert Millan wrote: > I had a look at that file, trying to trace its origin. As for the file > header, > it seems that Samuel Leo <[EMAIL PROTECTED]> wrote it. GRUB maintainers, do > we need to contact Samuel about this, or can we take the copyright as

history of fsys_ntfs.c (Re: Update for NTFS file system driver)

2007-06-10 Thread Robert Millan
On Sun, Jun 10, 2007 at 11:42:53AM +0800, Bean wrote: > > Did you write all the code yourself or did you use code from another > > project, like Linux or grub4dos or so? > > > > Yes, I write the code myself, which is based on the NTFS driver fsys_ntfs.c > in grub4dos. I had a look at that file,

Re: Update for NTFS file system driver

2007-06-10 Thread Marco Gerards
Thomas Schwinge <[EMAIL PROTECTED]> writes: > Hello! > > On Sun, Jun 10, 2007 at 09:57:44AM +0200, Marco Gerards wrote: >> Bean <[EMAIL PROTECTED]> writes: >> > On Sat, Jun 09, 2007 at 08:05:45PM +0200, Marco Gerards wrote: >> >> The normal procedure for patches is to make them consistent with the

Re: Update for NTFS file system driver

2007-06-10 Thread Thomas Schwinge
Hello! On Sun, Jun 10, 2007 at 09:57:44AM +0200, Marco Gerards wrote: > Bean <[EMAIL PROTECTED]> writes: > > On Sat, Jun 09, 2007 at 08:05:45PM +0200, Marco Gerards wrote: > >> The normal procedure for patches is to make them consistent with the > >> GCS (GNU Coding Standards), include a changelog

Re: Update for NTFS file system driver

2007-06-10 Thread Marco Gerards
Bean <[EMAIL PROTECTED]> writes: > On Sat, Jun 09, 2007 at 08:05:45PM +0200, Marco Gerards wrote: >> >> The normal procedure for patches is to make them consistent with the >> GCS (GNU Coding Standards), include a changelog. That way it is >> easier to review the patch and to include it in GRUB 2

Re: Update for NTFS file system driver

2007-06-09 Thread Bean
On Sat, Jun 09, 2007 at 08:05:45PM +0200, Marco Gerards wrote: > > The normal procedure for patches is to make them consistent with the > GCS (GNU Coding Standards), include a changelog. That way it is > easier to review the patch and to include it in GRUB 2. > Can you give me an example ? > > D

Re: Update for NTFS file system driver

2007-06-09 Thread Marco Gerards
Bean <[EMAIL PROTECTED]> writes: > Add unicode support for NTFS file system driver > Fix a bug in the unicode conversion function grub_utf16_to_utf8 in kern/misc.c Can you please include the patches inline? That way they are easier to review. The normal procedure for patches is to make them con