On Tue, 2009-04-28 at 01:59 -0700, David Miller wrote:
> I think it's overkill at the moment.
I've committed the patch with grub_malloc() and the patch making
grub_fs_uuid_close() use grub_device_close().
> > +/* Return partition to be freed if it can be freed. */
> > +static inline grub_partit
From: Pavel Roskin
Date: Mon, 27 Apr 2009 18:26:11 -0400
> On Sun, 2009-04-26 at 22:57 -0700, David Miller wrote:
>
>> grub_disk_open() isn't used, but a grub_device_open() does occur
>> during the iterator that has us find the FS_UUID device. This
>> happens search_fs_uuid().
>>
>> If we don'
From: Pavel Roskin
Date: Mon, 27 Apr 2009 23:50:45 -0400
> On Mon, 2009-04-27 at 18:45 -0700, David Miller wrote:
>
>> Thanks for fixing this Pavel. I suspect this bug is why the close was
>> left as a NOP function all of this time.
>
> Maybe.
>
>> Please commit this as it seems you haven't a
On Mon, 2009-04-27 at 18:45 -0700, David Miller wrote:
> Thanks for fixing this Pavel. I suspect this bug is why the close was
> left as a NOP function all of this time.
Maybe.
> Please commit this as it seems you haven't already :-)
I was about to commit it when I realized that the same could
From: Pavel Roskin
Date: Mon, 27 Apr 2009 21:37:52 -0400
> On Mon, 2009-04-27 at 18:26 -0400, Pavel Roskin wrote:
>
>> It's entirely possible that the problem is elsewhere. But I have no
>> experience debugging memory problems in GRUB, so it will take time
>> before I find out.
>
> Done! disk
On Mon, 2009-04-27 at 18:26 -0400, Pavel Roskin wrote:
> It's entirely possible that the problem is elsewhere. But I have no
> experience debugging memory problems in GRUB, so it will take time
> before I find out.
Done! disk->partition should not be copied by reference. This patch
fixes the b
On Sun, 2009-04-26 at 22:57 -0700, David Miller wrote:
> grub_disk_open() isn't used, but a grub_device_open() does occur
> during the iterator that has us find the FS_UUID device. This
> happens search_fs_uuid().
>
> If we don't do this, we leave a device reference open and dangling.
Then we s
From: Pavel Roskin
Date: Mon, 27 Apr 2009 01:25:37 -0400
> Hello!
>
> Since the revision 2136, I'm getting a non-fatal error message:
>
> GRUB loading.
> Welcome to GRUB!
>
> alloc magic is broken at 0x7fdaf20
> Aborted. Press any key to exit.
>
> After pressing enter, the menu appears and I
