Re: Remove trailing space from FAT label

2009-02-07 Thread Robert Millan
On Wed, Feb 04, 2009 at 01:01:55PM +0100, phcoder wrote: > Hello. Here is the patch to remove trailing spaces from FAT label. These > spaces generally aren't considiered to be part of label > Thanks > Vladimir 'phcoder' Serbinenko > Index: fs/fat.c > ==

Re: Remove trailing space from FAT label

2009-02-04 Thread phcoder
Hello Suppose the label is "DOS \0", Such a label is incorrect. But I agree with you that we should reuse the code and be fault-tolerant (I regularly see FAT volumes breaking the specifications). Additionally there is a mechanism of nice fat label which works the same way as long name

Re: Remove trailing space from FAT label

2009-02-04 Thread Pavel Roskin
On Wed, 2009-02-04 at 13:01 +0100, phcoder wrote: > Hello. Here is the patch to remove trailing spaces from FAT label. These > spaces generally aren't considiered to be part of label Suppose the label is "DOS \0", then your algorithm will fail to strip the final space, as it would iterate