Re: [PATCH] Re: Multiple partition maps

2008-09-09 Thread Robert Millan
On Tue, Sep 09, 2008 at 03:16:26PM +0200, phcoder wrote: > I don't think that this is enough since with bootcamp you can have a MBR > without a protective entry. Then it looks like an MSDOS partition map to me. Is this a normal use case, or something weird? Also, what do others (e.g. Linux) do?

Re: [PATCH] Re: Multiple partition maps

2008-09-09 Thread phcoder
Robert Millan wrote: > On Tue, Sep 09, 2008 at 02:47:11AM +0200, phcoder wrote: >> Robert Millan wrote: >>> On Mon, Sep 08, 2008 at 08:27:05PM +0200, phcoder wrote: Robert Millan wrote: > On Thu, Sep 04, 2008 at 11:54:43PM +0200, phcoder wrote: >> BTW GPT module checks the protective M

Re: [PATCH] Re: Multiple partition maps

2008-09-09 Thread Robert Millan
On Tue, Sep 09, 2008 at 02:47:11AM +0200, phcoder wrote: > Robert Millan wrote: > > On Mon, Sep 08, 2008 at 08:27:05PM +0200, phcoder wrote: > >> Robert Millan wrote: > >>> On Thu, Sep 04, 2008 at 11:54:43PM +0200, phcoder wrote: > BTW GPT module checks the protective MBR. In some cases when l

[PATCH] Re: Multiple partition maps

2008-09-08 Thread phcoder
Robert Millan wrote: > On Mon, Sep 08, 2008 at 08:27:05PM +0200, phcoder wrote: >> Robert Millan wrote: >>> On Thu, Sep 04, 2008 at 11:54:43PM +0200, phcoder wrote: BTW GPT module checks the protective MBR. In some cases when legay OS modified the MBR it's no longer "protective MBR". And

Re: Multiple partition maps

2008-09-08 Thread phcoder
Robert Millan wrote: > On Mon, Sep 08, 2008 at 08:27:05PM +0200, phcoder wrote: >> Robert Millan wrote: >>> On Thu, Sep 04, 2008 at 11:54:43PM +0200, phcoder wrote: BTW GPT module checks the protective MBR. In some cases when legay OS modified the MBR it's no longer "protective MBR". And

Re: Multiple partition maps

2008-09-08 Thread Robert Millan
On Mon, Sep 08, 2008 at 08:27:05PM +0200, phcoder wrote: > Robert Millan wrote: > > On Thu, Sep 04, 2008 at 11:54:43PM +0200, phcoder wrote: > >> BTW GPT module checks the protective MBR. In some cases when legay OS > >> modified the MBR it's no longer "protective MBR". And in theese cases > >> GRU

Re: Multiple partition maps

2008-09-08 Thread phcoder
Robert Millan wrote: > On Thu, Sep 04, 2008 at 11:54:43PM +0200, phcoder wrote: >> BTW GPT module checks the protective MBR. In some cases when legay OS >> modified the MBR it's no longer "protective MBR". And in theese cases >> GRUB will refuse to boot. Isn't the magic number check enough? > > If

Re: Multiple partition maps

2008-09-08 Thread Robert Millan
On Thu, Sep 04, 2008 at 11:54:43PM +0200, phcoder wrote: > BTW GPT module checks the protective MBR. In some cases when legay OS > modified the MBR it's no longer "protective MBR". And in theese cases > GRUB will refuse to boot. Isn't the magic number check enough? If there's at least one protecti

Re: Multiple partition maps

2008-09-05 Thread Robert Millan
On Thu, Sep 04, 2008 at 11:49:21PM +0200, phcoder wrote: > Robert Millan wrote: > > On Wed, Sep 03, 2008 at 08:08:50PM +0200, phcoder wrote: > >> Hello. I was looking at the grub code and seen that if a disk has > >> multiple partition tables (e.g. macintel with bootcamp) then only first > >> one w

Re: Multiple partition maps

2008-09-04 Thread phcoder
BTW GPT module checks the protective MBR. In some cases when legay OS modified the MBR it's no longer "protective MBR". And in theese cases GRUB will refuse to boot. Isn't the magic number check enough? Vladimir 'phcoder' Serbinenko Robert Millan wrote: > On Wed, Sep 03, 2008 at 08:08:50PM +0200, p

Re: Multiple partition maps

2008-09-04 Thread phcoder
Robert Millan wrote: > On Wed, Sep 03, 2008 at 08:08:50PM +0200, phcoder wrote: >> Hello. I was looking at the grub code and seen that if a disk has >> multiple partition tables (e.g. macintel with bootcamp) then only first >> one will be detected. In some cases it can lead to unreachable >> partit

Re: Multiple partition maps

2008-09-04 Thread Robert Millan
On Wed, Sep 03, 2008 at 08:08:50PM +0200, phcoder wrote: > Hello. I was looking at the grub code and seen that if a disk has > multiple partition tables (e.g. macintel with bootcamp) then only first > one will be detected. In some cases it can lead to unreachable > partitions if for some reason par