-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
> The Mercurial code is not up to date with the GRUB2 trunk, but is only
> missing
> a minor addition to the new crypto code. I've created a tarball[1] of the
> latest code if that helps.
>
Thanks a lot! I'll check that out tomorrow.
I've
On Tuesday 18 August 2009 18:18:31 Duboucher Thomas wrote:
> Actually, I wanted to know if the code in the mercurial repository was
> the same as the one in the Bazaar repository. The reason is I made
> previously a patch from hg and I do not have what I need to diff the two
> repositories. :|
The
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Michael Gorven a écrit :
> On Monday 17 August 2009 19:15:23 Duboucher Thomas wrote:
>> I have a stupid question what's the difference between the tip in
>> your Mercurial repository[1] and the head in your Bazaar repository[2]?
>
> The Mercurial
On Monday 17 August 2009 19:15:23 Duboucher Thomas wrote:
> I have a stupid question what's the difference between the tip in
> your Mercurial repository[1] and the head in your Bazaar repository[2]?
The Mercurial repo is deprecated. I'll actually remove it.
--
http://michael.gorven.za.net
On Mon, Aug 17, 2009 at 6:21 PM, Michael Gorven wrote:
> On Monday 17 August 2009 18:07:07 Vladimir 'phcoder' Serbinenko wrote:
>> Diff would be nice. Because not all developpers (including me) are
>> familiar with bzr and it would take time for me to find out how to
>> request specifically the pat
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
> [1] http://michael.gorven.za.net/bzr/grub/luks
>
I have a stupid question what's the difference between the tip in
your Mercurial repository[1] and the head in your Bazaar repository[2]?
[1] http://michael.gorven.za.net/hg/grub/luks/
[2] http
On Monday 17 August 2009 18:07:07 Vladimir 'phcoder' Serbinenko wrote:
> Diff would be nice. Because not all developpers (including me) are
> familiar with bzr and it would take time for me to find out how to
> request specifically the patch I want to review. Additionally not
> posting diff makes i
>+#define MAX(a, b) (a > b ? a : b)
Dangerous. Use ((a)>(b)?(a):(b))
>+ grub_printf("%c%c", hexchars[(buffer[i]>>4)&0xF],
>hexchars[buffer[i]&0xF] );
Use %02x instead of ad-hoc code. Where is print_buffer used at all?
Perhaps grub_printf or grub_dprintf will be better?
>+struct
On Mon, Aug 17, 2009 at 5:51 PM, Michael Gorven wrote:
> Hi
>
> I posted my copyright assignment last weekend,
Nice.
> so hopefully that will arrive
> at the FSF soon. In the meantime I have attached some code for review. These
> are the crypto module which manages ciphers and hashes, the SHA1 hash
