Re: Bugfix: directories: not reported as such on case-insensitive fs

2009-03-13 Thread phcoder
Robert Millan wrote: On Mon, Feb 09, 2009 at 05:16:52PM +0100, phcoder wrote: - if (filetype == GRUB_FSHELP_DIR) + if ((filetype & GRUB_FSHELP_TYPE_MASK) == GRUB_FSHELP_DIR) Uhm actually I don't understand why you need a mask for this. filetype is an enum, which we define ourselves.

Re: Bugfix: directories: not reported as such on case-insensitive fs

2009-03-13 Thread Robert Millan
On Mon, Feb 09, 2009 at 05:16:52PM +0100, phcoder wrote: > - if (filetype == GRUB_FSHELP_DIR) > + if ((filetype & GRUB_FSHELP_TYPE_MASK) == GRUB_FSHELP_DIR) Uhm actually I don't understand why you need a mask for this. filetype is an enum, which we define ourselves. What's the root of

Re: Bugfix: directories: not reported as such on case-insensitive fs

2009-03-13 Thread Robert Millan
On Mon, Feb 09, 2009 at 05:16:52PM +0100, phcoder wrote: > - > - if (filetype == GRUB_FSHELP_DIR) > + > + if ((filetype & GRUB_FSHELP_TYPE_MASK) == GRUB_FSHELP_DIR) Please don't remove those spaces, they're intentional (see http://www.gnu.org/prep/standards/html_node/Formatting.htm