Re: [patch] rough Mac OS X loader

2006-01-03 Thread Marco Gerards
Hollis Blanchard <[EMAIL PROTECTED]> writes: > Here is the updated patch. I believe I've resolved all your other > comments. Great! Feel free to commit it, although it would be nice if you could test it first (I am really curious if it all works now). ;-) Thanks, Marco __

Re: [patch] rough Mac OS X loader

2006-01-02 Thread Hollis Blanchard
On Jan 2, 2006, at 12:02 PM, Marco Gerards wrote: Hollis Blanchard <[EMAIL PROTECTED]> writes: +void EXPORT_FUNC (grub_jump) (unsigned long text, unsigned long stack, + unsigned long arg1, unsigned long arg2); Shouldn't a pointer be used here? Used where? For

Re: [patch] rough Mac OS X loader

2006-01-02 Thread Marco Gerards
Hollis Blanchard <[EMAIL PROTECTED]> writes: >>> +void EXPORT_FUNC (grub_jump) (unsigned long text, unsigned long >>> stack, >>> + unsigned long arg1, unsigned long arg2); >> >> Shouldn't a pointer be used here? > > Used where? For grub_jump's arguments. It jumps to some

Re: [patch] rough Mac OS X loader

2006-01-02 Thread Hollis Blanchard
Thanks for your comments. On Jan 2, 2006, at 11:29 AM, Marco Gerards wrote: Index: include/grub/xcoff.h === Is it possible to use the grub_ namespace in this file? In elf.h this is not done because it should be possible to upda

Re: [patch] rough Mac OS X loader

2006-01-02 Thread Marco Gerards
Hollis Blanchard <[EMAIL PROTECTED]> writes: Hi Hollis, > I've been working on a Mac OS X loader for GRUB. During the usual OS X > boot process, the firmware loads the BootX bootloader (which is a > hybrid CHRP script and XCOFF binary), which has a Mach-O loader and > loads the OS X Mach kernel.