Re: [patch] background_image: image centering and scaling

2008-09-02 Thread Olaf Mandel
Colin D Bennett schrieb: -Snipp- > Thanks for your work! It would be great if you wanted to enhance my > code by adding a preserve-aspect-ratio mode; currently my > background_image command scales to fit the screen without regard for > the image's original aspect ratio. [...] -Snipp- Hello, I h

Re: [patch] background_image: image centering and scaling

2008-08-31 Thread Colin D Bennett
On Fri, 29 Aug 2008 22:11:02 -0700 Olaf Mandel <[EMAIL PROTECTED]> wrote: > Vesa Jääskeläinen schrieb: > -Snipp- > > I will however look at if there are some ideas that you have > > provided what is still missing from new graphical menu > > implementation that should be there. > -Snipp- > > Hello

Re: [patch] background_image: image centering and scaling

2008-08-30 Thread Vesa Jääskeläinen
[EMAIL PROTECTED] wrote: > On Sat, 30 Aug 2008 18:00:27 +0300, Vesa Jääskeläinen <[EMAIL PROTECTED]> >> Olaf Mandel wrote: >> Basically there is no background_image command anymore in new >> implementation. Idea is that you specify behavior in theme file. In >> theme file you could have attributes

Re: [patch] background_image: image centering and scaling

2008-08-30 Thread colin
On Sat, 30 Aug 2008 18:00:27 +0300, Vesa Jääskeläinen <[EMAIL PROTECTED]> wrote: > Olaf Mandel wrote: >> thanks. I must admit to not looking at the source code for the project. >> Will scaling also be used for "simple" background_image commands? If yes >> and if the scaling does preserve the aspect

Re: [patch] background_image: image centering and scaling

2008-08-30 Thread Vesa Jääskeläinen
Olaf Mandel wrote: > thanks. I must admit to not looking at the source code for the project. > Will scaling also be used for "simple" background_image commands? If yes > and if the scaling does preserve the aspect ratio of the image, then the > background picture is not necessarily in the upper lef

Re: [patch] background_image: image centering and scaling

2008-08-30 Thread Robert Millan
On Fri, Aug 29, 2008 at 05:56:21PM +0300, Vesa Jääskeläinen wrote: > > Thanks for your effort, but there is already code that does this, > altought not committed yet. My apologises; I was unaware of this when I told Olaf to go ahead and bring this to grub-devel. Olaf, sorry if I wasted your tim

Re: [patch] background_image: image centering and scaling

2008-08-29 Thread Olaf Mandel
Vesa Jääskeläinen schrieb: -Snipp- > I will however look at if there are some ideas that you have provided > what is still missing from new graphical menu implementation that should > be there. -Snipp- Hello, thanks. I must admit to not looking at the source code for the project. Will scaling als

Re: [patch] background_image: image centering and scaling

2008-08-29 Thread Felix Zielcke
Am Freitag, den 29.08.2008, 17:56 +0300 schrieb Vesa Jääskeläinen: > Next time, try to discuss it first before implementing ;) Actually this is more my fault, because I hadn't Colin's GsoC project in mind. Shame on me :( He send a different patch to Debian BTS, related to this and then he just c

Re: [patch] background_image: image centering and scaling

2008-08-29 Thread Vesa Jääskeläinen
Olaf Mandel wrote: > Hello, > > on (some) computers with LCD monitors, the image is not automatically > scaled to full screen if the video mode is set to a lower resolution. So > the user has to set the gfxmode variable to the correct value in this > case. But then the background image provided by