Re: [coreboot] RFC: Changing CBMEM console to run as a persistent ring-buffer

2017-04-25 Thread Julius Werner
Managed to get it working with serial input now. Found a few issues with my patch. Will send a new, tested version out. On Tue, Apr 25, 2017 at 11:48 AM, Julius Werner wrote: > Did you check that all implementations use unsigned? >> > > Yes, all the ones that I'm now aware of used unsigned, 32-b

Re: [coreboot] RFC: Changing CBMEM console to run as a persistent ring-buffer

2017-04-25 Thread Julius Werner
> > Did you check that all implementations use unsigned? > Yes, all the ones that I'm now aware of used unsigned, 32-bit. > I am able to build it, I just had to figure out how and install some >> dependencies. But I tried booting it on an HP Chromebook 14 2013 (falco) >> and it doesn't seem to r

Re: [coreboot] RFC: Changing CBMEM console to run as a persistent ring-buffer

2017-04-25 Thread Vladimir 'phcoder' Serbinenko
On Tue, Apr 25, 2017, 20:15 Julius Werner wrote: > I'm very concerned with compatibility. You can't guarantee that coreboot >> and payload match. And in case of mismatch you get a memory corruption that >> is very hard to trace. Can we please change signature of cbmem entry? > > > I would rather

Re: [coreboot] RFC: Changing CBMEM console to run as a persistent ring-buffer

2017-04-25 Thread Julius Werner
> > I'm very concerned with compatibility. You can't guarantee that coreboot > and payload match. And in case of mismatch you get a memory corruption that > is very hard to trace. Can we please change signature of cbmem entry? I would rather allow older implementations to continue working as best

Re: [coreboot] RFC: Changing CBMEM console to run as a persistent ring-buffer

2017-04-24 Thread Vladimir 'phcoder' Serbinenko
I'm very concerned with compatibility. You can't guarantee that coreboot and payload match. And in case of mismatch you get a memory corruption that is very hard to trace. Can we please change signature of cbmem entry? You mentioned having trouble building GRUB. Can you detail those? What do you m

Re: [coreboot] RFC: Changing CBMEM console to run as a persistent ring-buffer

2017-04-24 Thread Julius Werner
[-seabios for the GRUB part of the thread] > Could you please also check, if GRUB’s CBMEM console driver, and the > the command cbmemc to display it need any updates? > Thanks, I wasn't aware that GRUB also had a driver for this. I'm happy to write a patch for it, but unfortunately I'm having so

Re: [coreboot] RFC: Changing CBMEM console to run as a persistent ring-buffer

2017-04-22 Thread Paul Menzel
[For the GRUB folks, this is about coreboot commit d67c6876 (Turn CBMEM console into a ring buffer that can persist across reboots) [1]. Julius’ message can be find in the coreboot list archive [2].] Dear Julius, Am Montag, den 10.04.2017, 15:50 -0700 schrieb Julius Werner: […] > The change m