Re: [bug #44238] Add support for menu.c32 and vesamenu.c32 in lib/syslinux_parse

2015-03-17 Thread The Gluglug
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, see my other message that I sent a few minutes ago. Those problems that I reported "elsewhere" no longer exist with the latest rebased patch. On 14/02/15 06:15, Andrei Borzenkov wrote: > В Fri, 13 Feb 2015 22:09:04 +0100 Lunar > пишет: > >> Andr

Re: [bug #44238] Add support for menu.c32 and vesamenu.c32 in lib/syslinux_parse

2015-03-17 Thread The Gluglug
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, This is a new rebased version of the patch that Lunar linked me to: https://people.torproject.org/~lunar/volatile/2015-03-17-e3Yp1d7FifQ/0001-lib-syslinux_parse-add-support-for-vesa-menu.c32.patch I also attached it. Debian ISOLINUX menu is stil

Re: [bug #44238] Add support for menu.c32 and vesamenu.c32 in lib/syslinux_parse

2015-02-14 Thread Andrei Borzenkov
В Sat, 14 Feb 2015 09:22:19 +0100 Lunar пишет: > Andrei Borzenkov: > > В Fri, 13 Feb 2015 22:09:04 +0100 > > Lunar пишет: > > > > > Andrei Borzenkov: > > > > [… review and comments …] > > > > > > Ok, here's another try. > > > > > > > It looks OK but as someone reported that your patches seem

Re: [bug #44238] Add support for menu.c32 and vesamenu.c32 in lib/syslinux_parse

2015-02-14 Thread Lunar
Andrei Borzenkov: > В Fri, 13 Feb 2015 22:09:04 +0100 > Lunar пишет: > > > Andrei Borzenkov: > > > [… review and comments …] > > > > Ok, here's another try. > > > > It looks OK but as someone reported that your patches seem to cause > problems elsewhere let's wait for confirmation. > > @glugl

Re: [bug #44238] Add support for menu.c32 and vesamenu.c32 in lib/syslinux_parse

2015-02-13 Thread Andrei Borzenkov
В Fri, 13 Feb 2015 22:09:04 +0100 Lunar пишет: > Andrei Borzenkov: > > [… review and comments …] > > Ok, here's another try. > It looks OK but as someone reported that your patches seem to cause problems elsewhere let's wait for confirmation. @gluglug - could you test both update versions? Th

Re: [bug #44238] Add support for menu.c32 and vesamenu.c32 in lib/syslinux_parse

2015-02-13 Thread The Gluglug
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Lunar^, I updated to the latest GRUB and tested those 2 patches. Tails does indeed boot as you said. However, Trisquel ISOLINUX menu now no longer appears: I see these 3 messages: "error: syntax error.", "error: Incorrect command.", "error: syntax err

Re: [bug #44238] Add support for menu.c32 and vesamenu.c32 in lib/syslinux_parse

2015-02-13 Thread Lunar
Andrei Borzenkov: > [… review and comments …] Ok, here's another try. -- Lunar From 9ce42bf6373bdf4c8c66e897e8b00908b5df03bf Mon Sep 17 00:00:00 2001 From: Lunar Date: Fri, 13 Feb 2015 22:08:11 +0100 Subject: [PATCH] lib/syslinux_parse: add support f

Re: [bug #44238] Add support for menu.c32 and vesamenu.c32 in lib/syslinux_parse

2015-02-13 Thread Andrei Borzenkov
В Fri, 13 Feb 2015 21:20:23 +0100 Lunar пишет: > From 9b441e5e6c602c71e522c594ca6cff72a12c078c Mon Sep 17 00:00:00 2001 > From: Lunar > Date: Sat, 14 Feb 2015 14:14:25 +0100 > Subject: [PATCH 1/2] lib/syslinux_parse: add support for (vesa)menu.c32 > > Fixes Savannah bug #44238. > --- > grub-co

Re: [bug #44238] Add support for menu.c32 and vesamenu.c32 in lib/syslinux_parse

2015-02-13 Thread Lunar
Andrei Borzenkov: > Follow-up Comment #1, bug #44238 (project grub): > > + while (*ptr) > + { > + end = ptr; > + for (end = ptr; *end && !grub_isspace (*end); end++); > + if (*end) > + *end++ = '\0'; > + > + /* "~" is