Re: [RFC PATCH v2 1/1] kern/dl: Add module version check

2023-01-10 Thread Glenn Washburn
On Fri, 23 Dec 2022 16:18:43 +0800 Zhang Boyang wrote: > Hi, Hi, sorry I missed this til now. > On 2022/12/22 14:31, Glenn Washburn wrote: > > On Wed, 21 Dec 2022 20:11:57 +0800 > > Zhang Boyang wrote: > >> + grub_printf_ (N_("warning: module %.63s has incorrect > >> version: %.63s != %s\

Re: [RFC PATCH v2 1/1] kern/dl: Add module version check

2022-12-23 Thread Zhang Boyang
Hi, On 2022/12/22 14:31, Glenn Washburn wrote: On Wed, 21 Dec 2022 20:11:57 +0800 Zhang Boyang wrote: + grub_printf_ (N_("warning: module %.63s has incorrect version: %.63s != %s\n"), + mod->name, modver, PACKAGE_VERSION); I don't quite like this, but I could live with

Re: [RFC PATCH v2 1/1] kern/dl: Add module version check

2022-12-21 Thread Glenn Washburn
On Wed, 21 Dec 2022 20:11:57 +0800 Zhang Boyang wrote: > This patch add version information to GRUB modules. Specifically, > PACKAGE_VERSION is embedded as null-terminated string in .modver > section. This string is checked at module loading time. > > If GRUB is locked down, modules with mismatc

Re: [RFC PATCH v2 1/1] kern/dl: Add module version check

2022-12-21 Thread Pete Batard via Grub-devel
Hi again Zhang, I hadn't had a chance to properly look at your v2 before replying earlier, and it looks like it addresses the elements I had an issue with. On 2022.12.21 12:11, Zhang Boyang wrote: This patch add version information to GRUB modules. Specifically, PACKAGE_VERSION is embedded as