Re: [PATH] grub-mkrelpath

2009-11-11 Thread Felix Zielcke
Am Sonntag, den 01.11.2009, 16:39 +0100 schrieb Felix Zielcke: > New version avaible at > sftp://bzr.savannah.gnu.org/srv/bzr/grub/people/fzielcke/mkrelpath Ah Vladimir you aren't anymore on IRC. So that I don't forget to ask you, I pushed this now: 2009-11-11 Felix Zielcke * util/gr

Re: [PATH] grub-mkrelpath

2009-11-04 Thread Felix Zielcke
Am Mittwoch, den 04.11.2009, 15:59 +0100 schrieb rubisher: > btw I just find a small typo in your branch: Thanks fixed. I should have taken another look at that part when I imported in bzr. -- Felix Zielcke Proud Debian Maintainer and GNU GRUB developer ___

Re: [PATH] grub-mkrelpath

2009-11-04 Thread rubisher
On Wed, 04 Nov 2009 12:07:29 +0100, Felix Zielcke wrote: > Am Mittwoch, den 04.11.2009, 10:55 +0100 schrieb rubisher: > >> > Right trunk contains my -I($srcdir)/include fix. >> > merged now. >> Sorry I don't agree with your fix: > > As you might have thought already from the following sentence,

Re: [PATH] grub-mkrelpath

2009-11-04 Thread Felix Zielcke
Am Mittwoch, den 04.11.2009, 10:55 +0100 schrieb rubisher: > > Right trunk contains my -I($srcdir)/include fix. > > merged now. > Sorry I don't agree with your fix: As you might have thought already from the following sentence, I already suspected that it's not the proper way. By the way this to

Re: [PATH] grub-mkrelpath

2009-11-04 Thread rubisher
Felix, On Tue, 03 Nov 2009 15:09:33 +0100, Felix Zielcke wrote: > Am Dienstag, den 03.11.2009, 14:51 +0100 schrieb rubisher: >> On Tue, 03 Nov 2009 11:33:42 +0100, Felix Zielcke >> wrote: >> > Am Dienstag, den 03.11.2009, 11:21 +0100 schrieb rubisher: >> >> Hello Felix, >> >> >> >> On Mon, 02 N

Re: [PATH] grub-mkrelpath

2009-11-03 Thread Felix Zielcke
Am Dienstag, den 03.11.2009, 14:51 +0100 schrieb rubisher: > On Tue, 03 Nov 2009 11:33:42 +0100, Felix Zielcke > wrote: > > Am Dienstag, den 03.11.2009, 11:21 +0100 schrieb rubisher: > >> Hello Felix, > >> > >> On Mon, 02 Nov 2009 09:54:43 +0100, Felix Zielcke > >> wrote: > >> > Am Sonntag, den

Re: [PATH] grub-mkrelpath

2009-11-03 Thread rubisher
On Tue, 03 Nov 2009 11:33:42 +0100, Felix Zielcke wrote: > Am Dienstag, den 03.11.2009, 11:21 +0100 schrieb rubisher: >> Hello Felix, >> >> On Mon, 02 Nov 2009 09:54:43 +0100, Felix Zielcke >> wrote: >> > Am Sonntag, den 01.11.2009, 23:04 +0100 schrieb Robert Millan: >> >> On Sun, Nov 01, 2009 a

Re: [PATH] grub-mkrelpath

2009-11-03 Thread Felix Zielcke
Am Dienstag, den 03.11.2009, 11:21 +0100 schrieb rubisher: > Hello Felix, > > On Mon, 02 Nov 2009 09:54:43 +0100, Felix Zielcke > wrote: > > Am Sonntag, den 01.11.2009, 23:04 +0100 schrieb Robert Millan: > >> On Sun, Nov 01, 2009 at 04:39:42PM +0100, Felix Zielcke wrote: > >> > > >> > I added no

Re: [PATH] grub-mkrelpath

2009-11-03 Thread rubisher
Hello Felix, On Mon, 02 Nov 2009 09:54:43 +0100, Felix Zielcke wrote: > Am Sonntag, den 01.11.2009, 23:04 +0100 schrieb Robert Millan: >> On Sun, Nov 01, 2009 at 04:39:42PM +0100, Felix Zielcke wrote: >> > >> > I added now a comment that this shouldn't ever happen. >> > >> > New version avaible

Re: [PATH] grub-mkrelpath

2009-11-02 Thread Felix Zielcke
Am Montag, den 02.11.2009, 14:45 +0100 schrieb Robert Millan: > > I wasn't sure if I should do it at the same time or not. > > The just grub-mkrelpath way has the advantage that if something in > the > > function is still broken (which I don't think) then just > grub-mkrelpath > > is broken not als

Re: [PATH] grub-mkrelpath

2009-11-02 Thread Robert Millan
On Mon, Nov 02, 2009 at 09:54:43AM +0100, Felix Zielcke wrote: > Am Sonntag, den 01.11.2009, 23:04 +0100 schrieb Robert Millan: > > On Sun, Nov 01, 2009 at 04:39:42PM +0100, Felix Zielcke wrote: > > > > > > I added now a comment that this shouldn't ever happen. > > > > > > New version avaible at

Re: [PATH] grub-mkrelpath

2009-11-02 Thread Felix Zielcke
Am Sonntag, den 01.11.2009, 23:04 +0100 schrieb Robert Millan: > On Sun, Nov 01, 2009 at 04:39:42PM +0100, Felix Zielcke wrote: > > > > I added now a comment that this shouldn't ever happen. > > > > New version avaible at > > bzr+ssh://bzr.savannah.gnu.org/grub/people/fzielcke/mkrelpath > > Vlad

Re: [PATH] grub-mkrelpath

2009-11-01 Thread Robert Millan
On Sun, Nov 01, 2009 at 04:39:42PM +0100, Felix Zielcke wrote: > > I added now a comment that this shouldn't ever happen. > > New version avaible at > bzr+ssh://bzr.savannah.gnu.org/grub/people/fzielcke/mkrelpath Vladimir, could you review and consider for inclusion in experimental? Or if you'r

Re: [PATH] grub-mkrelpath

2009-11-01 Thread Felix Zielcke
Am Samstag, den 29.08.2009, 09:51 +0200 schrieb Felix Zielcke: > Am Samstag, den 29.08.2009, 01:55 +0200 schrieb Robert Millan: > > On Fri, Aug 28, 2009 at 07:58:39PM +0200, Felix Zielcke wrote: > > > +#else /* ! HAVE_REALPATH */ > > > + grub_util_warn ("grub-mkrelpath might not work on your OS co

Re: [PATH] grub-mkrelpath

2009-08-29 Thread Felix Zielcke
Am Samstag, den 29.08.2009, 01:55 +0200 schrieb Robert Millan: > On Fri, Aug 28, 2009 at 07:58:39PM +0200, Felix Zielcke wrote: > > +#else /* ! HAVE_REALPATH */ > > + grub_util_warn ("grub-mkrelpath might not work on your OS correctly."); > > + /* make relative path absolute. */ > > + if (*path

Re: [PATH] grub-mkrelpath

2009-08-28 Thread Vladimir 'phcoder' Serbinenko
On Sat, Aug 29, 2009 at 1:55 AM, Robert Millan wrote: > On Fri, Aug 28, 2009 at 07:58:39PM +0200, Felix Zielcke wrote: >> +#else /* ! HAVE_REALPATH */ >> +  grub_util_warn ("grub-mkrelpath might not work on your OS correctly."); >> +  /* make relative path absolute.  */ >> +  if (*path != '/') >> +

Re: [PATH] grub-mkrelpath

2009-08-28 Thread Robert Millan
On Fri, Aug 28, 2009 at 07:58:39PM +0200, Felix Zielcke wrote: > +#else /* ! HAVE_REALPATH */ > + grub_util_warn ("grub-mkrelpath might not work on your OS correctly."); > + /* make relative path absolute. */ > + if (*path != '/') > +{ > + len = 1024; > + buf2 = xmalloc (len); > +

Re: [PATH] grub-mkrelpath

2009-08-28 Thread Felix Zielcke
Am Freitag, den 28.08.2009, 18:28 +0200 schrieb Robert Millan: > On Fri, Aug 28, 2009 at 02:53:12PM +0200, Felix Zielcke wrote: > > + if (stat (buf, &st) < 0) > > + grub_util_error ("can not stat %s", buf); > > We should give a reason. E.g: > > grub_util_error ("can not stat %s: %s", p,

Re: [PATH] grub-mkrelpath

2009-08-28 Thread Robert Millan
On Fri, Aug 28, 2009 at 02:53:12PM +0200, Felix Zielcke wrote: > + if (stat (buf, &st) < 0) > + grub_util_error ("can not stat %s", buf); We should give a reason. E.g: grub_util_error ("can not stat %s: %s", p, strerror (errno)); Also, I believe some of the comments in the old shell