Re: [PATCH v6 1/1] plainmount: Support plain encryption mode

2022-09-16 Thread Glenn Washburn
On Thu, 15 Sep 2022 05:28:40 + Maxim Fomin wrote: > --- Original Message --- > On Thursday, September 15th, 2022 at 12:54 AM, Glenn Washburn > wrote: > > > > On Wed, 14 Sep 2022 16:15:56 + > > Maxim Fomin ma...@fomin.one wrote: > > > > > --- Original Message --- > > >

Re: [PATCH v6 1/1] plainmount: Support plain encryption mode

2022-09-14 Thread Maxim Fomin
--- Original Message --- On Thursday, September 15th, 2022 at 12:54 AM, Glenn Washburn wrote: > > On Wed, 14 Sep 2022 16:15:56 + > Maxim Fomin ma...@fomin.one wrote: > > > --- Original Message --- > > On Tuesday, August 23rd, 2022 at 6:14 AM, Glenn Washburn > > developm...@

Re: [PATCH v6 1/1] plainmount: Support plain encryption mode

2022-09-14 Thread Glenn Washburn
On Wed, 14 Sep 2022 16:15:56 + Maxim Fomin wrote: > --- Original Message --- > On Tuesday, August 23rd, 2022 at 6:14 AM, Glenn Washburn > wrote: > > > Why does the return type changed from v5? I like it was better before, > > and I'm thinking the signature should be more like hash(

Re: [PATCH v6 1/1] plainmount: Support plain encryption mode

2022-09-14 Thread Maxim Fomin
--- Original Message --- On Tuesday, August 23rd, 2022 at 6:14 AM, Glenn Washburn wrote: > Why does the return type changed from v5? I like it was better before, > and I'm thinking the signature should be more like hash() in > cryptsetup, that is have password and password_size arguments

Re: [PATCH v6 1/1] plainmount: Support plain encryption mode

2022-08-27 Thread Maxim Fomin
--- Original Message --- On Saturday, August 27th, 2022 at 5:05 PM, Glenn Washburn wrote: > > > On Sat, 27 Aug 2022 12:06:30 + > Maxim Fomin ma...@fomin.one wrote: > > > Also, I am confused about maximum key data and password size allowed by > > cryptomount.h. It > > limits GRUB_

Re: [PATCH v6 1/1] plainmount: Support plain encryption mode

2022-08-27 Thread Glenn Washburn
On Sat, 27 Aug 2022 12:06:30 + Maxim Fomin wrote: > --- Original Message --- > On Tuesday, August 23rd, 2022 at 6:14 AM, Glenn Washburn > wrote: > > > +/ Hashes a password into a key and stores it with cipher. / > > > +static grub_uint8_t > > > +plainmount_configure_password (grub_c

Re: [PATCH v6 1/1] plainmount: Support plain encryption mode

2022-08-27 Thread Maxim Fomin
--- Original Message --- On Tuesday, August 23rd, 2022 at 6:14 AM, Glenn Washburn wrote: > > +/ Hashes a password into a key and stores it with cipher. / > > +static grub_uint8_t > > +plainmount_configure_password (grub_cryptodisk_t dev, const char *hash, > > + grub_uint8_t *key_data, gru

Re: [PATCH v6 1/1] plainmount: Support plain encryption mode

2022-08-22 Thread Glenn Washburn
I noticed that you've not been including Daniel Kiper on these patches. I don't expect him to look at these until I'm satisfied with the patch, but its always good practice to include him. So please do on the next version of this patch. On Sun, 31 Jul 2022 17:32:50 + Maxim Fomin wrote: > Fro