Re: [PATCH v4 09/12] tests/tpm2_key_protector_test: Reset 'ret' on fail

2025-04-04 Thread Gary Lin via Grub-devel
On Mon, Mar 24, 2025 at 10:35:13AM -0400, Stefan Berger wrote: > > > On 3/24/25 10:29 AM, Vladimir 'phcoder' Serbinenko wrote: > > Is there a risk here of missing the failures? It's common that no one > > looks at the output unless it causes a failed build on some CI/CD Le > > Good point. Maybe

Re: [PATCH v4 09/12] tests/tpm2_key_protector_test: Reset 'ret' on fail

2025-03-24 Thread Stefan Berger
On 3/24/25 10:29 AM, Vladimir 'phcoder' Serbinenko wrote: Is there a risk here of missing the failures? It's common that no one looks at the output unless it causes a failed build on some CI/CD Le Good point. Maybe the test script should return '1' when a single error occurred but run all t

Re: [PATCH v4 09/12] tests/tpm2_key_protector_test: Reset 'ret' on fail

2025-03-24 Thread Vladimir 'phcoder' Serbinenko
Is there a risk here of missing the failures? It's common that no one looks at the output unless it causes a failed build on some CI/CD Le ven. 21 mars 2025, 11:01, Gary Lin via Grub-devel a écrit : > Reset 'ret' to 0 when a test case fails so that the other test cases > could continue. > > Sign

Re: [PATCH v4 09/12] tests/tpm2_key_protector_test: Reset 'ret' on fail

2025-03-24 Thread Stefan Berger
On 3/21/25 3:59 AM, Gary Lin via Grub-devel wrote: Reset 'ret' to 0 when a test case fails so that the other test cases could continue. Signed-off-by: Gary Lin --- tests/tpm2_key_protector_test.in | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/tpm2_key_protector_test.in b/test