Re: [PATCH v4] ofdisk: add sas disks to the device list

2015-11-11 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 11.11.2015 14:14, Paulo Flabiano Smorigo wrote: > + ptr = (grub_uint64_t *) (table + sizeof (grub_uint64_t) * i); > + grub_snprintf (bufptr, 32, "/disk@%" PRIxGRUB_UINT64_T, *ptr); Please declare table as being grub_uint64_t * and then just use table[i]. This code violates cast

Re: [PATCH v4] ofdisk: add sas disks to the device list

2015-11-11 Thread Paulo Flabiano Smorigo
Yes, that could be an option. phcoder, can I commit using andrei's approach? -- P. F. Smorigo On Wed, Nov 11, 2015 at 3:28 PM, Andrei Borzenkov wrote: > 11.11.2015 16:14, Paulo Flabiano Smorigo пишет: > >> Same patch with the fix. >> --- >> grub-core/disk/ieee1275/ofdisk.c | 75 >>

Re: [PATCH v4] ofdisk: add sas disks to the device list

2015-11-11 Thread Andrei Borzenkov
11.11.2015 16:14, Paulo Flabiano Smorigo пишет: Same patch with the fix. --- grub-core/disk/ieee1275/ofdisk.c | 75 1 file changed, 75 insertions(+) diff --git a/grub-core/disk/ieee1275/ofdisk.c b/grub-core/disk/ieee1275/ofdisk.c index 297f058..ef290bc