On Fri, Oct 06, 2023 at 05:58:21PM -0400, Jon DeVree wrote:
> On Wed, Oct 04, 2023 at 00:43:18 +, Lidong Chen wrote:
> > - if (filename + direntry->len - 1 > (char *) tail)
> > + if (filename + direntry->len + 1 > (char *) end)
> > return grub_error (GRUB_ERR_BAD_FS, "invalid XFS directory ent
On Wed, Oct 04, 2023 at 00:43:18 +, Lidong Chen wrote:
> - if (filename + direntry->len - 1 > (char *) tail)
> + if (filename + direntry->len + 1 > (char *) end)
> return grub_error (GRUB_ERR_BAD_FS, "invalid XFS directory entry");
>
> There were these lines in the source after the diff:
>
>
On Sep 27, 2023, at 5:43 PM, Jon DeVree wrote:
The XFS directory entry parsing code has never been completely correct
for extent based directories. The parser correctly handles the case
where the directory is contained in a single extent, but then mistakenly
assumes the data blocks for the mult