Re: [PATCH v2 3/3] grub-core/kern/disk.c: handle LUKS2 devices

2022-06-12 Thread Patrick Steinhardt
On Mon, Jun 06, 2022 at 12:11:39PM -0500, Glenn Washburn wrote: > On Mon, 6 Jun 2022 07:32:40 +0200 > Patrick Steinhardt wrote: > > > On Sun, Jun 05, 2022 at 01:43:18PM -0500, Glenn Washburn wrote: > > > On Sun, 29 May 2022 09:09:38 +0200 > > > Patrick Steinhardt wrote: > > > > > > > On Tue, Ma

Re: [PATCH v2 3/3] grub-core/kern/disk.c: handle LUKS2 devices

2022-06-06 Thread Glenn Washburn
On Mon, 6 Jun 2022 07:32:40 +0200 Patrick Steinhardt wrote: > On Sun, Jun 05, 2022 at 01:43:18PM -0500, Glenn Washburn wrote: > > On Sun, 29 May 2022 09:09:38 +0200 > > Patrick Steinhardt wrote: > > > > > On Tue, May 10, 2022 at 10:55:52PM -0500, Glenn Washburn wrote: > > > > On Mon, 09 May 202

Re: [PATCH v2 3/3] grub-core/kern/disk.c: handle LUKS2 devices

2022-06-05 Thread Patrick Steinhardt
On Sun, Jun 05, 2022 at 01:43:18PM -0500, Glenn Washburn wrote: > On Sun, 29 May 2022 09:09:38 +0200 > Patrick Steinhardt wrote: > > > On Tue, May 10, 2022 at 10:55:52PM -0500, Glenn Washburn wrote: > > > On Mon, 09 May 2022 22:27:30 +0200 > > > Josselin Poiret wrote: > > > > > > > Hello everyo

Re: [PATCH v2 3/3] grub-core/kern/disk.c: handle LUKS2 devices

2022-06-05 Thread Glenn Washburn
On Sun, 29 May 2022 09:09:38 +0200 Patrick Steinhardt wrote: > On Tue, May 10, 2022 at 10:55:52PM -0500, Glenn Washburn wrote: > > On Mon, 09 May 2022 22:27:30 +0200 > > Josselin Poiret wrote: > > > > > Hello everyone, > > > > > > Glenn Washburn writes: > > > > > > > I don't really like this

Re: [PATCH v2 3/3] grub-core/kern/disk.c: handle LUKS2 devices

2022-06-05 Thread Glenn Washburn
On Sun, 29 May 2022 08:58:20 +0200 Patrick Steinhardt wrote: > On Wed, May 04, 2022 at 04:47:08PM -0500, Glenn Washburn wrote: > > On Tue, 29 Mar 2022 12:31:58 +0200 > > Pierre-Louis Bonicoli wrote: > > > > > Unlike LUKS1, the sector size of LUKS2 devices isn't hardcoded. > > > > > > Regarding

Re: [PATCH v2 3/3] grub-core/kern/disk.c: handle LUKS2 devices

2022-05-29 Thread Patrick Steinhardt
On Tue, May 10, 2022 at 10:55:52PM -0500, Glenn Washburn wrote: > On Mon, 09 May 2022 22:27:30 +0200 > Josselin Poiret wrote: > > > Hello everyone, > > > > Glenn Washburn writes: > > > > > I don't really like this, but it gets the job done and is a work-around > > > for a peculiarity of the LU

Re: [PATCH v2 3/3] grub-core/kern/disk.c: handle LUKS2 devices

2022-05-28 Thread Patrick Steinhardt
On Wed, May 04, 2022 at 04:47:08PM -0500, Glenn Washburn wrote: > On Tue, 29 Mar 2022 12:31:58 +0200 > Pierre-Louis Bonicoli wrote: > > > Unlike LUKS1, the sector size of LUKS2 devices isn't hardcoded. > > > > Regarding the probe command, the following values of --target switch > > are affected:

Re: [PATCH v2 3/3] grub-core/kern/disk.c: handle LUKS2 devices

2022-05-10 Thread Glenn Washburn
On Mon, 09 May 2022 22:27:30 +0200 Josselin Poiret wrote: > Hello everyone, > > Glenn Washburn writes: > > > I don't really like this, but it gets the job done and is a work-around > > for a peculiarity of the LUKS2 backend. The cheat mount code for > > cryptodisk does only calls scan() and no

Re: [PATCH v2 3/3] grub-core/kern/disk.c: handle LUKS2 devices

2022-05-09 Thread Josselin Poiret via Grub-devel
Hello everyone, Glenn Washburn writes: > I don't really like this, but it gets the job done and is a work-around > for a peculiarity of the LUKS2 backend. The cheat mount code for > cryptodisk does only calls scan() and not recover_key(). For LUKS1 scan > will return a grub_cryptodisk_t with log

Re: [PATCH v2 3/3] grub-core/kern/disk.c: handle LUKS2 devices

2022-05-04 Thread Glenn Washburn
On Tue, 29 Mar 2022 12:31:58 +0200 Pierre-Louis Bonicoli wrote: > Unlike LUKS1, the sector size of LUKS2 devices isn't hardcoded. > > Regarding the probe command, the following values of --target switch > are affected: abstraction, arc_hints, baremetal_hints, bios_hints, > cryptodisk_uuid, drive