Re: [PATCH v2 22/23] x86: make Xen early boot code relocatable

2015-08-28 Thread Andrew Cooper
On 28/08/15 07:54, Jan Beulich wrote: > >> Therefore I am very much +1 get grub working. > Then you kind of misunderstood: I'm not against getting grub2 > working (i.e. patches prior to this one are fine in principle). What > I'm against is hacking around firmware+grub2 combinations not > suitable

Re: [PATCH v2 22/23] x86: make Xen early boot code relocatable

2015-08-27 Thread Jan Beulich
>>> On 27.08.15 at 20:04, wrote: > On 27/08/15 16:29, Jan Beulich wrote: > On 27.08.15 at 17:10, wrote: >>> On Thu, Aug 27, 2015 at 07:12:38AM -0600, Jan Beulich wrote: >>> On 20.07.15 at 16:29, wrote: > /* Copy bootstrap trampoline to low memory, below 1MB. */ > -

Re: [PATCH v2 22/23] x86: make Xen early boot code relocatable

2015-08-27 Thread Andrew Cooper
On 27/08/15 16:29, Jan Beulich wrote: On 27.08.15 at 17:10, wrote: >> On Thu, Aug 27, 2015 at 07:12:38AM -0600, Jan Beulich wrote: >> On 20.07.15 at 16:29, wrote: /* Copy bootstrap trampoline to low memory, below 1MB. */ -mov $sym_phys(trampoline_start),%es

Re: [PATCH v2 22/23] x86: make Xen early boot code relocatable

2015-08-27 Thread Ben Hildred
On Thu, Aug 27, 2015 at 9:29 AM, Jan Beulich wrote: > >>> On 27.08.15 at 17:10, wrote: > > On Thu, Aug 27, 2015 at 07:12:38AM -0600, Jan Beulich wrote: > >> >>> On 20.07.15 at 16:29, wrote: > >> > /* Copy bootstrap trampoline to low memory, below 1MB. */ > >> > -mov $sym_ph

Re: [PATCH v2 22/23] x86: make Xen early boot code relocatable

2015-08-27 Thread Jan Beulich
>>> On 27.08.15 at 17:10, wrote: > On Thu, Aug 27, 2015 at 07:12:38AM -0600, Jan Beulich wrote: >> >>> On 20.07.15 at 16:29, wrote: >> > /* Copy bootstrap trampoline to low memory, below 1MB. */ >> > -mov $sym_phys(trampoline_start),%esi >> > +lea sym_offset(tramp

Re: [PATCH v2 22/23] x86: make Xen early boot code relocatable

2015-08-27 Thread Daniel Kiper
On Thu, Aug 27, 2015 at 07:12:38AM -0600, Jan Beulich wrote: > >>> On 20.07.15 at 16:29, wrote: [...] > > /* Copy bootstrap trampoline to low memory, below 1MB. */ > > -mov $sym_phys(trampoline_start),%esi > > +lea sym_offset(trampoline_start)(%ebp),%esi > >

Re: [PATCH v2 22/23] x86: make Xen early boot code relocatable

2015-08-27 Thread Jan Beulich
>>> On 20.07.15 at 16:29, wrote: > - %fs register is filled with segment descriptor which describes memory > region > with Xen image (it could be relocated or not); This is too fuzzy. Please be very precise which region it is that %fs is supposed to point to (so that reviewers have a chanc