Re: [PATCH v2 2/6] json: Implement wrapping interface

2019-11-13 Thread Daniel Kiper
On Thu, Nov 07, 2019 at 02:51:30AM +, Max Tottenham via Grub-devel wrote: > On 11/06, Patrick Steinhardt wrote: > > On Wed, Nov 06, 2019 at 02:57:52PM +, Max Tottenham wrote: > > > On 11/06, Daniel Kiper wrote: > > > > On Tue, Nov 05, 2019 at 02:12:13PM +0100, Patrick Steinhardt wrote: > >

Re: [PATCH v2 2/6] json: Implement wrapping interface

2019-11-10 Thread Patrick Steinhardt
On Fri, Nov 08, 2019 at 01:30:28PM +, Max Tottenham wrote: > On 11/07, Patrick Steinhardt wrote: > > On Thu, Nov 07, 2019 at 02:51:30AM +, Max Tottenham via Grub-devel > > wrote: > > > On 11/06, Patrick Steinhardt wrote: > > > > > > > > The reason is that we'd have to include "jsmn.h" in

Re: [PATCH v2 2/6] json: Implement wrapping interface

2019-11-08 Thread Max Tottenham via Grub-devel
On 11/07, Patrick Steinhardt wrote: > On Thu, Nov 07, 2019 at 02:51:30AM +, Max Tottenham via Grub-devel wrote: > > On 11/06, Patrick Steinhardt wrote: > > > > > > The reason is that we'd have to include "jsmn.h" in > > > "include/grub/json.h" to make `jsmntok_t` available. I definitely > > >

Re: [PATCH v2 2/6] json: Implement wrapping interface

2019-11-06 Thread Patrick Steinhardt
On Thu, Nov 07, 2019 at 02:51:30AM +, Max Tottenham via Grub-devel wrote: > On 11/06, Patrick Steinhardt wrote: > > On Wed, Nov 06, 2019 at 02:57:52PM +, Max Tottenham wrote: > > > I had one more comment about this patch which I forgot to send > > > last time: > > > > > > +struct grub_json

Re: [PATCH v2 2/6] json: Implement wrapping interface

2019-11-06 Thread Max Tottenham via Grub-devel
On 11/05, Patrick Steinhardt wrote: > While the newly added jsmn library provides the parsing interface, it > does not provide any kind of interface to act on parsed tokens. Instead, > the caller is expected to handle pointer arithmetics inside of the token > array in order to extract required info

Re: [PATCH v2 2/6] json: Implement wrapping interface

2019-11-06 Thread Max Tottenham via Grub-devel
On 11/06, Patrick Steinhardt wrote: > On Wed, Nov 06, 2019 at 02:57:52PM +, Max Tottenham wrote: > > On 11/06, Daniel Kiper wrote: > > > On Tue, Nov 05, 2019 at 02:12:13PM +0100, Patrick Steinhardt wrote: > > > > On Tue, Nov 05, 2019 at 12:54:38PM +, Max Tottenham via Grub-devel > > > > wr

Re: [PATCH v2 2/6] json: Implement wrapping interface

2019-11-06 Thread Patrick Steinhardt
On Wed, Nov 06, 2019 at 02:57:52PM +, Max Tottenham wrote: > On 11/06, Daniel Kiper wrote: > > On Tue, Nov 05, 2019 at 02:12:13PM +0100, Patrick Steinhardt wrote: > > > On Tue, Nov 05, 2019 at 12:54:38PM +, Max Tottenham via Grub-devel > > > wrote: > > > > On 11/05, Patrick Steinhardt wrot

Re: [PATCH v2 2/6] json: Implement wrapping interface

2019-11-06 Thread Max Tottenham via Grub-devel
On 11/06, Daniel Kiper wrote: > On Tue, Nov 05, 2019 at 02:12:13PM +0100, Patrick Steinhardt wrote: > > On Tue, Nov 05, 2019 at 12:54:38PM +, Max Tottenham via Grub-devel > > wrote: > > > On 11/05, Patrick Steinhardt wrote: > > > > +grub_err_t > > > > +grub_json_parse (grub_json_t **out, const

Re: [PATCH v2 2/6] json: Implement wrapping interface

2019-11-06 Thread Daniel Kiper
On Tue, Nov 05, 2019 at 02:12:13PM +0100, Patrick Steinhardt wrote: > On Tue, Nov 05, 2019 at 12:54:38PM +, Max Tottenham via Grub-devel wrote: > > On 11/05, Patrick Steinhardt wrote: > > > +grub_err_t > > > +grub_json_parse (grub_json_t **out, const char *string, grub_size_t > > > string_len)

Re: [PATCH v2 2/6] json: Implement wrapping interface

2019-11-05 Thread Patrick Steinhardt
On Tue, Nov 05, 2019 at 12:54:38PM +, Max Tottenham via Grub-devel wrote: > On 11/05, Patrick Steinhardt wrote: > > +grub_err_t > > +grub_json_parse (grub_json_t **out, const char *string, grub_size_t > > string_len) > > +{ > > + grub_size_t ntokens = 128; > > + grub_json_t *json = NULL; > >

Re: [PATCH v2 2/6] json: Implement wrapping interface

2019-11-05 Thread Max Tottenham via Grub-devel
I got a message from my MTA indicating my original mail may have been dropped. Attempting to resend. -- Max Tottenham | mtott...@akamai.com Senior Software Engineer, Server Platform Engineering /(* Akamai Technologies --- Begin Message --- On 11/05, Patrick Steinhardt wrote: > While the new