Re: [PATCH v2 08/23] x86: add multiboot2 protocol support

2015-08-18 Thread Jan Beulich
>>> On 18.08.15 at 14:00, wrote: > On Tue, Aug 18, 2015 at 02:12:58AM -0600, Jan Beulich wrote: >> >>> On 20.07.15 at 16:29, wrote: >> > @@ -119,10 +213,11 @@ __start: >> > >> > /* Save the Multiboot info struct (after relocation) for later >> > use. */ >> > mov $sym_phys(c

Re: [PATCH v2 08/23] x86: add multiboot2 protocol support

2015-08-18 Thread Daniel Kiper
On Tue, Aug 18, 2015 at 02:12:58AM -0600, Jan Beulich wrote: > >>> On 20.07.15 at 16:29, wrote: [...] > > @@ -119,10 +213,11 @@ __start: > > > > /* Save the Multiboot info struct (after relocation) for later > > use. */ > > mov $sym_phys(cpu0_stack)+1024,%esp > > +

Re: [PATCH v2 08/23] x86: add multiboot2 protocol support

2015-08-18 Thread Jan Beulich
>>> On 20.07.15 at 16:29, wrote: > v2 - not fixed yet: >- dynamic dependency generation for xen/arch/x86/boot/reloc.S; > this requires more work; I am not sure that it pays because > potential patch requires more changes than addition of just > multiboot2.h to Makefile > (s